From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 908E0C83F17 for ; Fri, 18 Jul 2025 10:24:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WdqP2JfgkIeSj/XihIppRjpKsQ7taFQ+rJpciVMKAdA=; b=KpoaMZtBDho0j3iZaAl0bUr3N4 zZQ0g9YijFNBNExNdtUb1nGWf0BNDE04XoXWvaiVo7aj5BOtvT6bxrlV3EPx7MYWCFJHa0AMxENB2 WFMkSDJdB5f1/BPWhxtu+i1XiNTxoawQ7LJodnoDlE8U4/SmFdMq++4THXQFw4IkjnsoupkrApi1l /ukYRL3CpvieSuoSno9IBDdG99hixN5D4rZv6bq7QpKY09uw5a1JJa3RqFVgKhYaB5Gg2sGIK9vBq 7DG9QipsBB38oQsJkUGiWiEhxPGFtmONMDfstukyPuORFzXv0q3JrFAIVeiMSiRZfgXu909c0cy1+ dlW0pl7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uciGZ-0000000CIAz-2m6o; Fri, 18 Jul 2025 10:24:35 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uchZH-0000000CDHh-1Eih; Fri, 18 Jul 2025 09:39:52 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6463C5C61C2; Fri, 18 Jul 2025 09:39:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8EB72C4CEEB; Fri, 18 Jul 2025 09:39:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752831590; bh=ATisPNWNr/NpB62B2F5Uq+5svo7dwS+kjzLt4tvM/K8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WRFPe2zzvXaR+wqRNqtPQ0xneaYD4yub6M6czL2yeoub91++wGWiWDAFotvunoArf ytw7tz8snJE802azQGmTAU3UPgOJ7Vg1gsmoB+xnrvHTPUH3LeV/rzUsgZTkFHpl5e BfcRST/FFoiyCpkeDlHD2QL5XKC7Ug0U1Sf+byuvZgXA+1JFdZ97Cilv3vNBvQVEMq 36DxwgcbDmr8beQG76QpT7U1grOV8jGxfwhYWsB2zlP1f0zNL5FHUTMGJ4IJqQDzMR g11qaPv6rNFYD2Vy+tgqUA56d4EoMAloVrjVW8V/74KBIjXCjwlJYtXPQCQvKqFIVF fAuM7vp+MMz8Q== Date: Fri, 18 Jul 2025 11:39:47 +0200 From: Lorenzo Bianconi To: Krzysztof Kozlowski Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH net-next v4 1/7] dt-bindings: net: airoha: npu: Add memory regions used for wlan offload Message-ID: References: <20250717-airoha-en7581-wlan-offlaod-v4-0-6db178391ed2@kernel.org> <20250717-airoha-en7581-wlan-offlaod-v4-1-6db178391ed2@kernel.org> <20250718-sceptical-blue-bird-7e96e3@kuoka> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3JqbMrQnCkpywZ9L" Content-Disposition: inline In-Reply-To: <20250718-sceptical-blue-bird-7e96e3@kuoka> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250718_023951_409428_8E500879 X-CRM114-Status: GOOD ( 20.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --3JqbMrQnCkpywZ9L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > On Thu, Jul 17, 2025 at 08:57:42AM +0200, Lorenzo Bianconi wrote: > > Document memory regions used by Airoha EN7581 NPU for wlan traffic > > offloading. The brand new added memory regions do not introduce any > > backward compatibility issues since they will be used just to offload > > traffic to/from the MT76 wireless NIC and the MT76 probing will not fail > > if these memory regions are not provide, it will just disable offloading > > via the NPU module. >=20 > That's not what I see entirely. I see the same problem I told you already. > of_reserved_mem_region_to_resource_byname returns error -> > airoha_npu_wlan_init_memory returns error -> your other patchset prints > big fat warning in mt7996_pci_probe(). Is it ok to use dev_info() instead dev_warn() or do you prefer to completely remove the log? >=20 > So all correct DTS now gets a warning. Warning is a state of failure, > even if probe proceeds. >=20 > I don't understand why you can't make it fully optional, so also fully > backwards compatible. I am completely fine to make it fully optional, but can you please explain what you mean here with 'optional'? At the moment in mt76_npu_init() we first look for the "airoha,npu" property in mt76 node to load the NPU pointer running airoha_npu_get(): wifi@0,0 { compatible =3D "mediatek,mt76"; ... airoha,npu =3D <&npu>; ... }; If this property is defined in the wifi node I guess it is fine to assume even the NPU memory regions are properly defined int the DTS. Is it ok to use dev_info() instead of dev_warn() in mt7996_pci_probe() if the mt76_npu_init() returns an error (e.g. if the "airoha,npu" is not defin= ed) or do you prefer to do something else to make this process optional? Regards, Lorenzo >=20 > Best regards, > Krzysztof >=20 --3JqbMrQnCkpywZ9L Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCaHoWYwAKCRA6cBh0uS2t rMH+AP9mKzNrRKajI0dIizZfVTYflu21cQpHgECLJi/0fBDXygEA5dRSNsUQcyo4 ll6BHt9geLz7bnYYSRTsginFvI+8iA4= =QkuP -----END PGP SIGNATURE----- --3JqbMrQnCkpywZ9L--