From: Catalin Marinas <catalin.marinas@arm.com>
To: Yeoreum Yun <yeoreum.yun@arm.com>
Cc: will@kernel.org, broonie@kernel.org, maz@kernel.org,
oliver.upton@linux.dev, shameerali.kolothum.thodi@huawei.com,
joey.gouly@arm.com, james.morse@arm.com, ardb@kernel.org,
scott@os.amperecomputing.com, suzuki.poulose@arm.com,
yuzenghui@huawei.com, mark.rutland@arm.com,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/5] arm64: cpufeature: add FEAT_LSUI
Date: Fri, 15 Aug 2025 18:33:15 +0100 [thread overview]
Message-ID: <aJ9vW8SgklYByjpB@arm.com> (raw)
In-Reply-To: <20250811163635.1562145-2-yeoreum.yun@arm.com>
On Mon, Aug 11, 2025 at 05:36:31PM +0100, Yeoreum Yun wrote:
> @@ -3131,6 +3132,13 @@ static const struct arm64_cpu_capabilities arm64_features[] = {
> .matches = has_cpuid_feature,
> ARM64_CPUID_FIELDS(ID_AA64PFR2_EL1, GCIE, IMP)
> },
> + {
> + .desc = "Unprivileged Load Store Instructions (LSUI)",
> + .capability = ARM64_HAS_LSUI,
> + .type = ARM64_CPUCAP_SYSTEM_FEATURE,
> + .matches = has_cpuid_feature,
> + ARM64_CPUID_FIELDS(ID_AA64ISAR3_EL1, LSUI, IMP)
> + },
> {},
> };
Since this is only used in the kernel, I wonder whether we should hide
it behind #ifdef CONFIG_AS_HAS_LSUI. Otherwise we report it as present
and one may infer that the kernel is going to use it. Not a strong view
and I don't think we have a precedent for this.
--
Catalin
next prev parent reply other threads:[~2025-08-15 20:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 16:36 [PATCH v6 0/5] support FEAT_LSUI and apply it on futex atomic ops Yeoreum Yun
2025-08-11 16:36 ` [PATCH v6 1/5] arm64: cpufeature: add FEAT_LSUI Yeoreum Yun
2025-08-15 17:33 ` Catalin Marinas [this message]
2025-08-16 11:04 ` Yeoreum Yun
2025-08-11 16:36 ` [PATCH v6 2/5] KVM: arm64: expose FEAT_LSUI to guest Yeoreum Yun
2025-08-11 16:36 ` [PATCH v6 3/5] arm64: Kconfig: add LSUI Kconfig Yeoreum Yun
2025-08-11 16:36 ` [PATCH v6 4/5] arm64: futex: refactor futex atomic operation Yeoreum Yun
2025-08-15 16:38 ` Catalin Marinas
2025-08-16 13:03 ` Yeoreum Yun
2025-08-11 16:36 ` [PATCH v6 5/5] arm64: futex: support futex with FEAT_LSUI Yeoreum Yun
2025-08-15 17:02 ` Catalin Marinas
2025-08-16 12:30 ` Yeoreum Yun
2025-08-16 14:57 ` Yeoreum Yun
2025-08-18 18:35 ` Catalin Marinas
2025-08-18 19:53 ` Yeoreum Yun
2025-08-19 8:38 ` Catalin Marinas
2025-08-19 9:11 ` Yeoreum Yun
2025-08-19 14:29 ` Catalin Marinas
2025-08-19 15:15 ` Yeoreum Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJ9vW8SgklYByjpB@arm.com \
--to=catalin.marinas@arm.com \
--cc=ardb@kernel.org \
--cc=broonie@kernel.org \
--cc=james.morse@arm.com \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=scott@os.amperecomputing.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yeoreum.yun@arm.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).