From: Cristian Marussi <cristian.marussi@arm.com>
To: Liao Yuanhong <liaoyuanhong@vivo.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Cristian Marussi <cristian.marussi@arm.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
"open list:MAILBOX ARM MHUv3" <linux-kernel@vger.kernel.org>,
"moderated list:MAILBOX ARM MHUv3"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] mailbox: arm_mhuv3: Remove no_free_ptr() to maintain the original form of the pointer
Date: Mon, 11 Aug 2025 10:30:51 +0100 [thread overview]
Message-ID: <aJm35DGRj2RZ7W9Q@pluto> (raw)
In-Reply-To: <20250811082536.377896-1-liaoyuanhong@vivo.com>
On Mon, Aug 11, 2025 at 04:25:36PM +0800, Liao Yuanhong wrote:
> Remove no_free_ptr() to ensure PTR_ERR() consistently retrieves the correct
> error code.
>
Hi,
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> ---
> drivers/mailbox/arm_mhuv3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mailbox/arm_mhuv3.c b/drivers/mailbox/arm_mhuv3.c
> index b97e79a5870f..0910da67f8a1 100644
> --- a/drivers/mailbox/arm_mhuv3.c
> +++ b/drivers/mailbox/arm_mhuv3.c
> @@ -945,7 +945,7 @@ static irqreturn_t mhuv3_mbx_comb_interrupt(int irq, void *arg)
> if (IS_ERR(data)) {
> dev_err(dev,
> "Failed to read in-band data. err:%ld\n",
> - PTR_ERR(no_free_ptr(data)));
> + PTR_ERR(data));
> goto rx_ack;
Yes indeed the cleanup kfree helper takes care to skip any ERR_OR_NULL
by itself...good catch, thanks for this.
Acked-by: Cristian Marussi <cristian.marussi@arm.com>
Thanks,
Cristian
next prev parent reply other threads:[~2025-08-11 9:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 8:25 [PATCH] mailbox: arm_mhuv3: Remove no_free_ptr() to maintain the original form of the pointer Liao Yuanhong
2025-08-11 9:30 ` Cristian Marussi [this message]
2025-08-11 11:01 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJm35DGRj2RZ7W9Q@pluto \
--to=cristian.marussi@arm.com \
--cc=jassisinghbrar@gmail.com \
--cc=liaoyuanhong@vivo.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox