From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53BF7CA0FE9 for ; Tue, 26 Aug 2025 09:34:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EZLmmxLsJLc5gk0wgGNitzJFT6rBOeESCPORDcRzzpg=; b=Ey2mFMfzOHiT18DTIcTmZtAsLn 5+VonR5UF7CalPcC3wHn02f79foN2oDNcOG3ELNhr6tuc5KS4Ohm+QrK3AsOlup6eif9PkSbpH741 iKpY0Ro6TfplD77Gk/cOqnX+Dy1M6Gsie/JbZy2DzJDuwofyGJrnF0qHvQXXZjniZEqfwdaM6D3fN gr83ZgFnVg1ycBv7tH9gLupNdGT9Z0Gp/Haqfo4RD9QvmoYwlOKnv7APTkrywosXnX2QvzfGGp0qm tiWZg1r5AXfICILrNz5IyABm1cJqYjUHExMKBozCL0wH+d6kXC5/Eay/Mb0niJvO7oV9RpewcDPVY 9NBdscag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uqq4F-0000000BQXc-16YX; Tue, 26 Aug 2025 09:34:15 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uqpvm-0000000BN1W-0w1c; Tue, 26 Aug 2025 09:25:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=EZLmmxLsJLc5gk0wgGNitzJFT6rBOeESCPORDcRzzpg=; b=FRQv3YmSJgzipze9JFAMvq5qaC V+BTLxR6lVRumi2AL350wCzKmYriTjqDERiPQ8fkSOaWtjnf96MWR9yPaq1moY8E4L25h9oVBja1U 4OBeidVNFkPVGjsDFObo2qaXiuW33nT3kXqrox3kqzJqf2cnlOVokin8LljE+xdW0idr0Q5GLpNn6 Arz2vEN6a0tlpRggAplvBJwn2GjUO6NHqyB23Ea/i3VgpCPO2VWnxbjiE3mMvrieDsXiZogBpRsBz iXcGxvpU2GJPFL5VATHFIoU8FeqZlH7eknIg1AyGmF+esZcv8Q6re+A2HSTJb7ZhD1y51p9xyoiNP VFhdIK0g==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:51124) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1uqpvQ-000000007eE-0erY; Tue, 26 Aug 2025 10:25:08 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1uqpvJ-0000000017V-3YDI; Tue, 26 Aug 2025 10:25:01 +0100 Date: Tue, 26 Aug 2025 10:25:01 +0100 From: "Russell King (Oracle)" To: Chaoyi Chen Cc: Marek Szyprowski , Chaoyi Chen , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Jonas Karlman , David Wu , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH net-next v3] net: ethernet: stmmac: dwmac-rk: Make the clk_phy could be used for external phy Message-ID: References: <20250815023515.114-1-kernel@airkyi.com> <809848c9-2ffa-4743-adda-b8b714b404de@samsung.com> <8240a3cc-aade-40d8-b2f4-09681f76be68@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8240a3cc-aade-40d8-b2f4-09681f76be68@rock-chips.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250826_022530_542777_CEB3C831 X-CRM114-Status: GOOD ( 32.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 26, 2025 at 04:08:40PM +0800, Chaoyi Chen wrote: > Hi Russell, > > On 8/25/2025 9:37 PM, Russell King (Oracle) wrote: > > On Mon, Aug 25, 2025 at 12:53:37PM +0200, Marek Szyprowski wrote: > > > On 25.08.2025 11:57, Chaoyi Chen wrote: > > > > On 8/25/2025 3:23 PM, Marek Szyprowski wrote: > > > > > On 15.08.2025 04:35, Chaoyi Chen wrote: > > > > > > From: Chaoyi Chen > > > > > > > > > > > > For external phy, clk_phy should be optional, and some external phy > > > > > > need the clock input from clk_phy. This patch adds support for setting > > > > > > clk_phy for external phy. > > > > > > > > > > > > Signed-off-by: David Wu > > > > > > Signed-off-by: Chaoyi Chen > > > > > > --- > > > > > > > > > > > > Changes in v3: > > > > > > - Link to V2: > > > > > > https://lore.kernel.org/netdev/20250812012127.197-1-kernel@airkyi.com/ > > > > > > - Rebase to net-next/main > > > > > > > > > > > > Changes in v2: > > > > > > - Link to V1: > > > > > > https://lore.kernel.org/netdev/20250806011405.115-1-kernel@airkyi.com/ > > > > > > - Remove get clock frequency from DT prop > > > > > > > > > > > >    drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 11 +++++++---- > > > > > >    1 file changed, 7 insertions(+), 4 deletions(-) > > > > > > > > > > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c > > > > > > b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c > > > > > > index ac8288301994..5d921e62c2f5 100644 > > > > > > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c > > > > > > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c > > > > > > @@ -1412,12 +1412,15 @@ static int rk_gmac_clk_init(struct > > > > > > plat_stmmacenet_data *plat) > > > > > >            clk_set_rate(plat->stmmac_clk, 50000000); > > > > > >        } > > > > > >    -    if (plat->phy_node && bsp_priv->integrated_phy) { > > > > > > +    if (plat->phy_node) { > > > > > >            bsp_priv->clk_phy = of_clk_get(plat->phy_node, 0); > > > > > >            ret = PTR_ERR_OR_ZERO(bsp_priv->clk_phy); > > > > > > -        if (ret) > > > > > > -            return dev_err_probe(dev, ret, "Cannot get PHY clock\n"); > > > > > > -        clk_set_rate(bsp_priv->clk_phy, 50000000); > > > > > > +        /* If it is not integrated_phy, clk_phy is optional */ > > > > > > +        if (bsp_priv->integrated_phy) { > > > > > > +            if (ret) > > > > > > +                return dev_err_probe(dev, ret, "Cannot get PHY > > > > > > clock\n"); > > > > > > +            clk_set_rate(bsp_priv->clk_phy, 50000000); > > > > > > +        } > > > > I think  we should set bsp_priv->clk_phy to NULL here if we failed to > > > > get the clock. > > > > > > > > Could you try this on your board? Thank you. > > > Right, the following change also fixes this issue: > > > > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c > > > b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c > > > index 9fc41207cc45..2d19d48be01f 100644 > > > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c > > > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c > > > @@ -1415,6 +1415,8 @@ static int rk_gmac_clk_init(struct > > > plat_stmmacenet_data *plat) > > >         if (plat->phy_node) { > > >                 bsp_priv->clk_phy = of_clk_get(plat->phy_node, 0); > > >                 ret = PTR_ERR_OR_ZERO(bsp_priv->clk_phy); > > > +               if (ret) > > > +                       bsp_priv->clk_phy = NULL; > > Or just: > > > > clk = of_clk_get(plat->phy_node, 0); > > if (clk == ERR_PTR(-EPROBE_DEFER)) > > Do we actually need this? Maybe other devm_clk_get() before it would fail in advance. Is it the same clock as devm_clk_get()? If it is, what's the point of getting it a second time. If it isn't, then it could be a different clock which may be yet to probe. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!