From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCF0DCA0FFC for ; Wed, 27 Aug 2025 15:49:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XXWW7WAxER/aFBi0e1G0TlXxoqZgrlenJ6xILJsnmTg=; b=wi3XYGZSY1LNQ4qwdZNpdbtGbj t0j/SCl35IwiNeTztQf4difskLUcFQpEvNBm+0gtN4o+uy61xlnOBvWlOusQPwzvsxHIxkIu7SH6/ QI1FEDhH1wFvqx/RvemrSJOl0kiAV3uvERW+FNJ08+t4NyeV/zkVaNOIiAu4jHn/yG8xfvYsznj7D yY9q5iSlmn6Iq8QqUZ5LxgCmP6jCw/dWTIqJcGnbc0sUSeKTNFvHeGyKyDCWcA4pCiRxjp1pxfDKv vf5Xw/qUs1EErX1BrDce1038cN14V8RyqJWoKrhqVo5xfF9dyq+hKAHhSSf+fY72MGSud4GB9SLgt OPo9GPHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1urIOZ-0000000Fy6U-2rHR; Wed, 27 Aug 2025 15:49:07 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1urEGW-0000000FFqx-38Ee for linux-arm-kernel@bombadil.infradead.org; Wed, 27 Aug 2025 11:24:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:CC:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XXWW7WAxER/aFBi0e1G0TlXxoqZgrlenJ6xILJsnmTg=; b=Qsb50CQGyw7my7Mm1GgOquC85g 0oxYzKizR6cRvfN+bOcdg33VFm5SbEYARDxRnoRkf4e9t/3StZAYCYNj3uVmeto3M/tqMIsLRpHKm vanp3mEuOOPklzdYeUt8yFFuqHMoeJw7DOGUPQpFPS9LWFZXRSZFfdxbSQRsJF1OAG3j7t3I0GNoH 45fEQrH26BIrHoJ5D4sMeDatZMvGyjMRAxiyLUJjdxBTPfShOMsmxPPkgYDqQOCkp50cg2Sv+VHF5 TQc6csL6pQUjW7QvoNRazVLXpZxuet6wPOGVSxOEcUTAQ+gASnGACfbjDxiq6IlXJqZYhVT3JzEvy sQIpcwOQ==; Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]) by desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1urEGT-00000002QKi-2O5l for linux-arm-kernel@lists.infradead.org; Wed, 27 Aug 2025 11:24:31 +0000 Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57R0X1D4018088; Wed, 27 Aug 2025 04:24:04 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pfpt0220; bh=XXWW7WAxER/aFBi0e1G0TlXxo qZgrlenJ6xILJsnmTg=; b=QjI4Xl9f5KxQXZn4CXSAoH9GCyEnVWSP8+IncNvk5 TkgPEFst5HqdsIoIijWW8ESvCxgjLl6g7F7Zz7tCdBImUracFmdqa42vNzTycVNq wlHkUhBMaxN95YKTsqLngzBkKIM5r/UZ5wI14SZ44spIUc9bXiJKOWiVXorPCr/N eCEhEjBzI1pnFFoDYcP+V6tXIzVEmARLTx7FtHMNiki0+4YufAmm/uAlVcY4J6zk T1OLrpajotRudat1j2D3kUL1yYLOjfhuc+1QVOb3ZqQhIj+z1CI9gCSyyPH552jZ 0v/VuAXcsq1N7Ejzd5AecKd5qnWjViSDMlwxlC27X/eDQ== Received: from dc6wp-exch02.marvell.com ([4.21.29.225]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 48spmm9b01-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Aug 2025 04:24:03 -0700 (PDT) Received: from DC6WP-EXCH02.marvell.com (10.76.176.209) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25; Wed, 27 Aug 2025 04:24:02 -0700 Received: from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server id 15.2.1544.25 via Frontend Transport; Wed, 27 Aug 2025 04:24:02 -0700 Received: from opensource (unknown [10.29.8.22]) by maili.marvell.com (Postfix) with SMTP id CE4453F706B; Wed, 27 Aug 2025 04:23:58 -0700 (PDT) Date: Wed, 27 Aug 2025 11:23:57 +0000 From: Subbaraya Sundeep To: "Russell King (Oracle)" CC: Andrew Lunn , Heiner Kallweit , Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , , Maxime Coquelin , , Paolo Abeni Subject: Re: [PATCH net-next] net: stmmac: mdio: use netdev_priv() directly Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Proofpoint-ORIG-GUID: fMcyWFOQZuVFKBAbYKMRqgneaqPJlFCJ X-Proofpoint-GUID: fMcyWFOQZuVFKBAbYKMRqgneaqPJlFCJ X-Authority-Analysis: v=2.4 cv=RMyzH5i+ c=1 sm=1 tr=0 ts=68aeead3 cx=c_pps a=gIfcoYsirJbf48DBMSPrZA==:117 a=gIfcoYsirJbf48DBMSPrZA==:17 a=kj9zAlcOel0A:10 a=2OwXVqhp2XgA:10 a=PHq6YzTAAAAA:8 a=M5GUcnROAAAA:8 a=QyAlcnm2dVGNXgeYg58A:9 a=CjuIK1q_8ugA:10 a=ZKzU8r6zoKMcqsNulkmm:22 a=OBjm3rFKGHvpk9ecZwUJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI2MDIwNSBTYWx0ZWRfX8k+P0IlW1oW5 PSSPsuASQ4fmrK9jLrJ/BUqs+FaiIeAhtve2OFysMLuoQY8SVfhGGv1CCCNicguI/i3V0m4NDYT SZKzeU1DmlsNtcSUo6FBGmzIYiqK9O/YrHgyLZNtYzanDsHLQ4qCFBL/89fNq0TypENOpkNJpTD /f3Q9tjFifz0VWrUtjwmZYlMIhAo2qlWjncqZDsse8YG05LrHlWdO/M9/kECDEknqiKUhVBVKT7 XtlHsXK4S8el7duZ1DHmJpRtBQx+uMD4kO5ddKeEZ70aK8ZZleP+FZGMGN1FPmyV7Bg5u/XHU4F 5fMX3FyC6SBdsUh35yNealXIF00zmxwKf9p5GF1OJc0mHl04XABUxhhIjtugBopZspLiLqPWa0F XYJtX/jq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-27_02,2025-08-26_01,2025-03-28_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250827_122430_023314_5B9997D8 X-CRM114-Status: GOOD ( 21.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2025-08-27 at 08:41:48, Russell King (Oracle) (rmk+kernel@armlinux.org.uk) wrote: > netdev_priv() is an inline function, taking a struct net_device > pointer. When passing in the MII bus->priv, which is a void pointer, > there is no need to go via a local ndev variable to type it first. > > Thus, instead of: > > struct net_device *ndev = bus->priv; > struct stmmac_priv *priv; > ... > priv = netdev_priv(ndev); > > we can simply do: > > struct stmmac_priv *priv = netdev_priv(bus->priv); > > which simplifies the code. > > Signed-off-by: Russell King (Oracle) Reviewed-by: Subbaraya Sundeep Thanks, Sundeep > --- > .../net/ethernet/stmicro/stmmac/stmmac_mdio.c | 38 +++++-------------- > 1 file changed, 10 insertions(+), 28 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > index 836f2848dfeb..86021e6b67b2 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > @@ -131,12 +131,9 @@ static int stmmac_xgmac2_mdio_read(struct stmmac_priv *priv, u32 addr, > static int stmmac_xgmac2_mdio_read_c22(struct mii_bus *bus, int phyaddr, > int phyreg) > { > - struct net_device *ndev = bus->priv; > - struct stmmac_priv *priv; > + struct stmmac_priv *priv = netdev_priv(bus->priv); > u32 addr; > > - priv = netdev_priv(ndev); > - > /* Until ver 2.20 XGMAC does not support C22 addr >= 4 */ > if (priv->synopsys_id < DWXGMAC_CORE_2_20 && > phyaddr > MII_XGMAC_MAX_C22ADDR) > @@ -150,12 +147,9 @@ static int stmmac_xgmac2_mdio_read_c22(struct mii_bus *bus, int phyaddr, > static int stmmac_xgmac2_mdio_read_c45(struct mii_bus *bus, int phyaddr, > int devad, int phyreg) > { > - struct net_device *ndev = bus->priv; > - struct stmmac_priv *priv; > + struct stmmac_priv *priv = netdev_priv(bus->priv); > u32 addr; > > - priv = netdev_priv(ndev); > - > stmmac_xgmac2_c45_format(priv, phyaddr, devad, phyreg, &addr); > > return stmmac_xgmac2_mdio_read(priv, addr, MII_XGMAC_BUSY); > @@ -209,12 +203,9 @@ static int stmmac_xgmac2_mdio_write(struct stmmac_priv *priv, u32 addr, > static int stmmac_xgmac2_mdio_write_c22(struct mii_bus *bus, int phyaddr, > int phyreg, u16 phydata) > { > - struct net_device *ndev = bus->priv; > - struct stmmac_priv *priv; > + struct stmmac_priv *priv = netdev_priv(bus->priv); > u32 addr; > > - priv = netdev_priv(ndev); > - > /* Until ver 2.20 XGMAC does not support C22 addr >= 4 */ > if (priv->synopsys_id < DWXGMAC_CORE_2_20 && > phyaddr > MII_XGMAC_MAX_C22ADDR) > @@ -229,12 +220,9 @@ static int stmmac_xgmac2_mdio_write_c22(struct mii_bus *bus, int phyaddr, > static int stmmac_xgmac2_mdio_write_c45(struct mii_bus *bus, int phyaddr, > int devad, int phyreg, u16 phydata) > { > - struct net_device *ndev = bus->priv; > - struct stmmac_priv *priv; > + struct stmmac_priv *priv = netdev_priv(bus->priv); > u32 addr; > > - priv = netdev_priv(ndev); > - > stmmac_xgmac2_c45_format(priv, phyaddr, devad, phyreg, &addr); > > return stmmac_xgmac2_mdio_write(priv, addr, MII_XGMAC_BUSY, > @@ -274,8 +262,7 @@ static int stmmac_mdio_read(struct stmmac_priv *priv, int data, u32 value) > */ > static int stmmac_mdio_read_c22(struct mii_bus *bus, int phyaddr, int phyreg) > { > - struct net_device *ndev = bus->priv; > - struct stmmac_priv *priv = netdev_priv(ndev); > + struct stmmac_priv *priv = netdev_priv(bus->priv); > u32 value = MII_BUSY; > int data = 0; > > @@ -312,8 +299,7 @@ static int stmmac_mdio_read_c22(struct mii_bus *bus, int phyaddr, int phyreg) > static int stmmac_mdio_read_c45(struct mii_bus *bus, int phyaddr, int devad, > int phyreg) > { > - struct net_device *ndev = bus->priv; > - struct stmmac_priv *priv = netdev_priv(ndev); > + struct stmmac_priv *priv = netdev_priv(bus->priv); > u32 value = MII_BUSY; > int data = 0; > > @@ -373,8 +359,7 @@ static int stmmac_mdio_write(struct stmmac_priv *priv, int data, u32 value) > static int stmmac_mdio_write_c22(struct mii_bus *bus, int phyaddr, int phyreg, > u16 phydata) > { > - struct net_device *ndev = bus->priv; > - struct stmmac_priv *priv = netdev_priv(ndev); > + struct stmmac_priv *priv = netdev_priv(bus->priv); > int ret, data = phydata; > u32 value = MII_BUSY; > > @@ -412,8 +397,7 @@ static int stmmac_mdio_write_c22(struct mii_bus *bus, int phyaddr, int phyreg, > static int stmmac_mdio_write_c45(struct mii_bus *bus, int phyaddr, > int devad, int phyreg, u16 phydata) > { > - struct net_device *ndev = bus->priv; > - struct stmmac_priv *priv = netdev_priv(ndev); > + struct stmmac_priv *priv = netdev_priv(bus->priv); > int ret, data = phydata; > u32 value = MII_BUSY; > > @@ -452,8 +436,7 @@ static int stmmac_mdio_write_c45(struct mii_bus *bus, int phyaddr, > int stmmac_mdio_reset(struct mii_bus *bus) > { > #if IS_ENABLED(CONFIG_STMMAC_PLATFORM) > - struct net_device *ndev = bus->priv; > - struct stmmac_priv *priv = netdev_priv(ndev); > + struct stmmac_priv *priv = netdev_priv(bus->priv); > unsigned int mii_address = priv->hw->mii.addr; > > #ifdef CONFIG_OF > @@ -497,12 +480,11 @@ int stmmac_mdio_reset(struct mii_bus *bus) > > int stmmac_pcs_setup(struct net_device *ndev) > { > + struct stmmac_priv *priv = netdev_priv(ndev); > struct fwnode_handle *devnode, *pcsnode; > struct dw_xpcs *xpcs = NULL; > - struct stmmac_priv *priv; > int addr, ret; > > - priv = netdev_priv(ndev); > devnode = priv->plat->port_node; > > if (priv->plat->pcs_init) { > -- > 2.47.2 >