From: Frank Li <Frank.li@nxp.com>
To: Guoniu Zhou <guoniu.zhou@nxp.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] media: nxp: imx8-isi: Reorder the platform data
Date: Wed, 27 Aug 2025 10:30:44 -0400 [thread overview]
Message-ID: <aK8WlNKmMZo+F+vW@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20250827-isi_imx93-v1-4-83e6b4b50c4d@nxp.com>
On Wed, Aug 27, 2025 at 05:53:51PM +0800, Guoniu Zhou wrote:
> Sort platform data in the order of compatible strings in of_match table
> to make it more convenient to read.
>
> No functions changed.
>
> Signed-off-by: Guoniu Zhou <guoniu.zhou@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
> .../media/platform/nxp/imx8-isi/imx8-isi-core.c | 44 +++++++++++-----------
> 1 file changed, 22 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> index 981648a0311374597a033a7ecbf39f7b0b252cb0..cae918792ddbe3e6f458606fbbb7d0ad5738504c 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> @@ -314,6 +314,28 @@ static const struct mxc_isi_plat_data mxc_imx8mp_data = {
> .has_36bit_dma = true,
> };
>
> +static const struct mxc_isi_plat_data mxc_imx8qm_data = {
> + .model = MXC_ISI_IMX8QM,
> + .num_ports = 5,
> + .num_channels = 8,
> + .reg_offset = 0x10000,
> + .ier_reg = &mxc_imx8_isi_ier_qm,
> + .set_thd = &mxc_imx8_isi_thd_v1,
> + .buf_active_reverse = true,
> + .has_36bit_dma = false,
> +};
> +
> +static const struct mxc_isi_plat_data mxc_imx8qxp_data = {
> + .model = MXC_ISI_IMX8QXP,
> + .num_ports = 5,
> + .num_channels = 6,
> + .reg_offset = 0x10000,
> + .ier_reg = &mxc_imx8_isi_ier_v2,
> + .set_thd = &mxc_imx8_isi_thd_v1,
> + .buf_active_reverse = true,
> + .has_36bit_dma = false,
> +};
> +
> static const struct mxc_isi_plat_data mxc_imx8ulp_data = {
> .model = MXC_ISI_IMX8ULP,
> .num_ports = 1,
> @@ -337,28 +359,6 @@ static const struct mxc_isi_plat_data mxc_imx93_data = {
> .has_36bit_dma = false,
> };
>
> -static const struct mxc_isi_plat_data mxc_imx8qm_data = {
> - .model = MXC_ISI_IMX8QM,
> - .num_ports = 5,
> - .num_channels = 8,
> - .reg_offset = 0x10000,
> - .ier_reg = &mxc_imx8_isi_ier_qm,
> - .set_thd = &mxc_imx8_isi_thd_v1,
> - .buf_active_reverse = true,
> - .has_36bit_dma = false,
> -};
> -
> -static const struct mxc_isi_plat_data mxc_imx8qxp_data = {
> - .model = MXC_ISI_IMX8QXP,
> - .num_ports = 5,
> - .num_channels = 6,
> - .reg_offset = 0x10000,
> - .ier_reg = &mxc_imx8_isi_ier_v2,
> - .set_thd = &mxc_imx8_isi_thd_v1,
> - .buf_active_reverse = true,
> - .has_36bit_dma = false,
> -};
> -
> /* -----------------------------------------------------------------------------
> * Power management
> */
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2025-08-27 17:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 9:53 [PATCH 0/5] media: imx91: Add ISI support Guoniu Zhou
2025-08-27 9:53 ` [PATCH 1/5] media: dt-bindings: nxp,imx8-isi: Add i.MX91 ISI compatible string Guoniu Zhou
2025-08-27 12:58 ` Krzysztof Kozlowski
2025-08-27 14:40 ` Frank Li
2025-08-27 9:53 ` [PATCH 2/5] media: nxp: imx8-isi: Simplify code by using helper macro Guoniu Zhou
2025-08-27 14:28 ` Frank Li
2025-08-27 16:29 ` kernel test robot
2025-08-27 9:53 ` [PATCH 3/5] media: nxp: imx8-isi: Add parallel camera input support Guoniu Zhou
2025-08-27 14:29 ` Frank Li
2025-08-27 9:53 ` [PATCH 4/5] media: nxp: imx8-isi: Reorder the platform data Guoniu Zhou
2025-08-27 14:30 ` Frank Li [this message]
2025-08-27 9:53 ` [PATCH 5/5] media: nxp: imx8-isi: Add ISI support for i.MX91 Guoniu Zhou
2025-08-27 14:39 ` Frank Li
2025-08-27 13:00 ` [PATCH 0/5] media: imx91: Add ISI support Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aK8WlNKmMZo+F+vW@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=guoniu.zhou@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox