From: Frank Li <Frank.li@nxp.com>
To: Haibo Chen <haibo.chen@nxp.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Peng Fan <peng.fan@nxp.com>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: imx95-19x19-evk: correct the phy setting for flexcan1/2
Date: Tue, 19 Aug 2025 11:50:17 -0400 [thread overview]
Message-ID: <aKSdOeeS04waVwTg@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20250819-can-dts-fix-v1-1-e43e7d98a544@nxp.com>
On Tue, Aug 19, 2025 at 10:43:37AM +0800, Haibo Chen wrote:
> 1, the phy support up to 8Mbit/s databitrate for CAN FD.
> refer to product data sheet:
> https://www.nxp.com/docs/en/data-sheet/TJA1463.pdf
> 2, the standby pin of the phy is ACTIVE_LOW.
> 3, the phy of flexcan2 connect the standby/en pin to PCAL6408 on i2c4 bus.
>
> Fixes: 02b7adb791e1 ("arm64: dts: imx95-19x19-evk: add adc0 flexcan[1,2] i2c[2,3] uart5 spi3 and tpm3")
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> index 2f949a0d48d2d8066388884703c3b3cd678f16e1..9d034275c847606919af8ee4a80a00599abf4d8b 100644
> --- a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> @@ -80,17 +80,17 @@ linux_cma: linux,cma {
> flexcan1_phy: can-phy0 {
> compatible = "nxp,tjr1443";
> #phy-cells = <0>;
> - max-bitrate = <1000000>;
> + max-bitrate = <8000000>;
> enable-gpios = <&i2c6_pcal6416 6 GPIO_ACTIVE_HIGH>;
> - standby-gpios = <&i2c6_pcal6416 5 GPIO_ACTIVE_HIGH>;
> + standby-gpios = <&i2c6_pcal6416 5 GPIO_ACTIVE_LOW>;
It use go though CAN phy.
Frank
> };
>
> flexcan2_phy: can-phy1 {
> compatible = "nxp,tjr1443";
> #phy-cells = <0>;
> - max-bitrate = <1000000>;
> - enable-gpios = <&i2c6_pcal6416 4 GPIO_ACTIVE_HIGH>;
> - standby-gpios = <&i2c6_pcal6416 3 GPIO_ACTIVE_HIGH>;
> + max-bitrate = <8000000>;
> + enable-gpios = <&i2c4_gpio_expander_21 4 GPIO_ACTIVE_HIGH>;
> + standby-gpios = <&i2c4_gpio_expander_21 3 GPIO_ACTIVE_LOW>;
> };
>
> reg_vref_1v8: regulator-1p8v {
>
> ---
> base-commit: 3ac864c2d9bb8608ee236e89bf561811613abfce
> change-id: 20250819-can-dts-fix-62ac1d02c007
>
> Best regards,
> --
> Haibo Chen <haibo.chen@nxp.com>
>
next prev parent reply other threads:[~2025-08-19 18:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 2:43 [PATCH] arm64: dts: imx95-19x19-evk: correct the phy setting for flexcan1/2 Haibo Chen
2025-08-19 15:50 ` Frank Li [this message]
2025-08-21 15:03 ` Frank Li
2025-08-22 9:19 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKSdOeeS04waVwTg@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox