Re: [PATCH v3 00/14] spi: airoha: driver fixes & improvements

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2451 bytes --]

> This patch series greatly improve airoha snfi driver and fix a
> number of serious bug.
> 
> Fixed bugs:
>  * Fix reading/writing of flashes with more than one plane per lun
>  * Fix inability to read/write oob area
>  * Fill the buffer with 0xff before writing
>  * Fix reading of flashes supporting continuous reading mode
>  * Fix error paths
> 
> Improvements:
>  * Add support of dual/quad wires spi modes in exec_op().
>  * Support of dualio/quadio flash reading commands
>  * Remove dirty hack that reads flash page settings from SNFI registers
>    during driver startup
> 
> Unfortunately I am unable to test the driver with linux at the moment,
> so only the following testing was done:

It seems to me this is quite an important rework of the driver. I would prefer
to have some test results for this series. Are you able to run mtd_test kernel
module for testing?

Regards,
Lorenzo

>  * Driver compiles without error.
>  * All changes were tested with corresponding u-boot driver. U-Boot
>    SpiNAND driver was modified as well to match linux-6.17-rc2 with
>    additional fixes for continuous mode.
> 
> Changes v2:
>  * minor fix
>  * add comments to code
> 
> Changes v3:
>  * add patch to prevent continuous reading
> 
> Mikhail Kshevetskiy (14):
>   spi: airoha: return an error for continuous mode dirmap creation cases
>   spi: airoha: remove unnecessary restriction length
>   spi: airoha: add support of dual/quad wires spi modes
>   spi: airoha: remove unnecessary switch to non-dma mode
>   spi: airoha: unify dirmap read/write code
>   spi: airoha: switch back to non-dma mode in the case of error
>   spi: airoha: fix reading/writing of flashes with more than one plane
>     per lun
>   spi: airoha: support of dualio/quadio flash reading commands
>   spi: airoha: allow reading/writing of oob area
>   spi: airoha: buffer must be 0xff-ed before writing
>   spi: airoha: avoid setting of page/oob sizes in REG_SPI_NFI_PAGEFMT
>   spi: airoha: reduce the number of modification of REG_SPI_NFI_CNFG and
>     REG_SPI_NFI_SECCUS_SIZE registers
>   spi: airoha: set custom sector size equal to flash page size
>   spi: airoha: avoid reading flash page settings from SNFI registers
>     during driver startup
> 
>  drivers/spi/spi-airoha-snfi.c | 508 +++++++++++++++++-----------------
>  1 file changed, 260 insertions(+), 248 deletions(-)
> 
> -- 
> 2.50.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]