From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD389CA0FE7 for ; Thu, 21 Aug 2025 22:35:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FvcCIkiBDmnfigo0DVGCbwtzVOGqHA9D492eYkILjdA=; b=hkkrLtTb6RXr3ZlnTxSc1Rr/+Z pZ/8IJSN6v3QnECToJfgM70Gz6sneqZoSj85fp40qDrrkGh1Zo2JUxKT0/lJM4v5nbhdLGsvG6Y4Y OHkiGeqWxSPUj1Zdqb7xNWSSiVKtIyTzcs/SNseylPTcC6dfVbX1lwvYKIPyAme364SUGAHQhbGKe 7mROVr/i/Cq6AINBXx7NE28r38EflT1AZFmMDaYdqsku+5E7iEs4GFKM+Z/UbeHaszWcLQQnF5R8G VHaakcJYd12PTMhHQdKrK2mASf+FwEYtSFHCdNi73xjKGXTFguBXHTG0km+fBvw84zuKhWx6JUd65 /vAQyDtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1upDsr-00000000kcc-10CQ; Thu, 21 Aug 2025 22:35:49 +0000 Received: from mail-francesouthazlp170110003.outbound.protection.outlook.com ([2a01:111:f403:c207::3] helo=MRWPR03CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1up6wF-0000000HJgs-1VUz for linux-arm-kernel@lists.infradead.org; Thu, 21 Aug 2025 15:10:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=prO4qcOrPWCJrDPbMSGeanWAlPGN2W7CtQoaQ6vTodjwRXs1llgBwWz6QkR9eI+6PmCm47cfYIji5abyb201vGRzKEy4KUI/h+XApbYFDXtNo1UKBnW/BhAAOxDd74ZAfZ6jv9wkeUaU9lkYdBI/097d5W/1aGFJQtiDZq9xoemmGJS0s3jFFQImNhQ2pnzSytzfKcw3dKEHQr+Y4AaF01mm0EBOI66iWOfefsm6lS175e8a074qF8z6eXgByl3lNN2udiNpPbB8MM+BYHtKFUwLyrclJVrkxqHBBGuAoAuTMscJ/RoLifnVD8aESZrS901C1xIBseGY1/7ruSqS8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FvcCIkiBDmnfigo0DVGCbwtzVOGqHA9D492eYkILjdA=; b=mKTuSKzwhmfwkZycdU88INarf1VnCKS6JEUOQ7GpSh5XmFw9Plnb7ZJoMDrLBw29JFFCwEnI2H1Fp1GOl1FeMLZVzRqHrcxyeiWFIQpJPtF5n1cdiWAyBxglOzRksiltXh2MDmog+ARwQFIeSpTG3Er9u5XAj4WV7KMZFN6o9kTf4vHMUq5VXaE2fkOrdACxXlsLyeiNqWf9Dlq7JtjdxYVoQUoDYAx8SYk6qvwZQrTAKiFjCIQ55Mj9E6rcXQjV6qf48bJYcF8mrx7yG1Ka7ZhHoH8L0KOLBEIlIYFB3rrreyhBwl+4YKyDJTIQtEP+aHK1fCtl6wBG19ADRjoAvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FvcCIkiBDmnfigo0DVGCbwtzVOGqHA9D492eYkILjdA=; b=leFJ0YzMHl3ox4x9VmPRJm6yLMwkh79qPQ4oUizrG2yjRKuuWCzcGMIRqn50nIBn5bXMyDFAG+QVQbbVgjhB/YfA/QfL2hI2UXr6nLu2OR0VH4sFhtUmaqflWxRqOCTITz3R250lFobbFEPdNNpPdTkeUesqW+yYJLIOfe60mN5QmXhFx4cUiZBpOroZtwpCMbNtloD6b7HsCkUwkMzYUAwrvy4f8EVWAeDkPYas0P3xlKfz0yQwXQfexuRhGkkPxkwFZGLn6/Bqq8nXmN4eU/vGdp852t/EfdX7vi546mwBVW6dwvzTSPdPeV+WdqesYI4B5NjjkjfUSWgSriirqQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB9626.eurprd04.prod.outlook.com (2603:10a6:10:309::18) by PA2PR04MB10373.eurprd04.prod.outlook.com (2603:10a6:102:416::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.14; Thu, 21 Aug 2025 15:10:45 +0000 Received: from DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d]) by DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d%5]) with mapi id 15.20.9052.012; Thu, 21 Aug 2025 15:10:45 +0000 Date: Thu, 21 Aug 2025 11:10:38 -0400 From: Frank Li To: Laurent Pinchart Cc: linux-media@vger.kernel.org, Isaac Scott , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 02/12] media: imx-mipi-csis: Simplify access to source pad Message-ID: References: <20250821000944.27849-1-laurent.pinchart@ideasonboard.com> <20250821000944.27849-3-laurent.pinchart@ideasonboard.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250821000944.27849-3-laurent.pinchart@ideasonboard.com> X-ClientProxiedBy: PH7P220CA0059.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:32b::23) To DB9PR04MB9626.eurprd04.prod.outlook.com (2603:10a6:10:309::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB9626:EE_|PA2PR04MB10373:EE_ X-MS-Office365-Filtering-Correlation-Id: aab8895d-002b-4426-c02e-08dde0c4e732 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|19092799006|52116014|376014|7416014|38350700014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?6ztGpywAlgr/ksV8Xk1Wo2xRT0gEOGh0bNuHwfAl7XERsi802LpHBSDaqpND?= =?us-ascii?Q?1vq19MLG12lY23BLEkMJGGVwvKIBDo3h31ndKZcfw33yq4sjjZuQ8jQqjV44?= =?us-ascii?Q?9c9eMLbdLJmkrSdE/8lNl6dYZeaxBFMwO/wv4LwH2nb6Cgrl6in/zT1TaZSy?= =?us-ascii?Q?z684iuYPNVtfeI03Z3knCe4z+1FL8k0SbOFbpOb2u20GPK0Wyqp+UaoZtcNZ?= =?us-ascii?Q?J3P98uXRNTCxgulAvzyLp7WmnxQqWZejwnHHcXjezTy+hHt4e93/zkJK0xH/?= =?us-ascii?Q?zuyvaMG7DtsOK3DVNTlRdwQWXl1ei9LWn5IvMg5TPxFQqawEInftzUoqBR8W?= =?us-ascii?Q?mMLSLP+L4aQwjfNwzakstiM7MkaS41z/u3TP0sySOruca3Bd3n4OhCweJHTs?= =?us-ascii?Q?om+vlNmjgW7ZzmJE/OnIjtDp6sImKQCru8SLaR4nFYeD4YQ+4D6DFJJBr8RH?= =?us-ascii?Q?jrk6AygKhGakm/BCCxYR90obT+C6GvcraPMCW2+kUJ5CcaJsob/Z7EZZUMi9?= =?us-ascii?Q?XmrmLBN+tfHrlZ7gEwnqHE+Sst2QGO5eP8i/co6iJ+DyZTWq/liIsLLDvdFQ?= =?us-ascii?Q?RbxM826GoggUqaKAO9HWw4v6YPYUxMzKMGA3LTvtNOxb+ax1jnrWM1dUF1M+?= =?us-ascii?Q?4hPOG+nPqxvTJJ+sUqQivs3bFA+yCuNqJR1cxgVPipG6Ops7lfjAFaK7GRcG?= =?us-ascii?Q?zDDL1tZ+6308w29uDYZ+rdlpWImMMCUfMisD/CI9R/2lqKI2hQtFJQrE+da5?= =?us-ascii?Q?YcQbIr+uEopDPjaJbqNL4qS8jZv8IJ/zPSx0tZTiiuWQIaeBaYD+lR+xmCMV?= =?us-ascii?Q?GOVWyFGJ9Mff6ncmV672J0/Zt7Hl1Q30fL+4HPbetfTWBfLmn0kK/R22YfxS?= =?us-ascii?Q?3NB6fKE8LRPUfn1LnSIxxhRF/buQg+o2o6KyBQ56rn+q2GaOWntkEugpdy56?= =?us-ascii?Q?6BddPriWViWwPfgyHLUB8iRiydGjE63huFZ1d/ib80apbXqzLXcBn/wpw/9L?= =?us-ascii?Q?nDEEywbCEjbW9tWLHLH+qeFrTZSC3X5e+bqcXlW2L7dwD2wt7XZBGqgMht7Q?= =?us-ascii?Q?pKsNfZ7GmPi5uiAYBe1t40PiJMzxImsSWoU5uIbQ5aljYPCLDwdYVxnORdN/?= =?us-ascii?Q?t/jSXVfwe4WZ0KWabGrhHLzQ2zb2pksqkhZRhgU7NbYikeqc/svGtBrZnoUH?= =?us-ascii?Q?L+7ZXXPQI7i6tG1B7zwPT+2JjGXFxMzeTitHAtaICuG6ylmZBOWUkRe5eq7Z?= =?us-ascii?Q?oRxREhC6e1mXlj/EqprgSD6LUNFESkPq+O9+ajyuIm7wkNoVdQ2Q5Js0quEW?= =?us-ascii?Q?/Hz5ZssT9VLPrvx7HkyWuSHC5BUSGzkq138zsTI5I5Wjne+uFpYzRctnbdPv?= =?us-ascii?Q?l2ur/lglCOx6zKa5rm/3KN+QuI2aPGNuC2oITBuxtx2KAMESH2EfUBrcBajc?= =?us-ascii?Q?kxvqPNhz42frX/EMy4QWo2cBmh/I0JtEkPFtKRR8awUjzXlvhPSRRw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB9626.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(19092799006)(52116014)(376014)(7416014)(38350700014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FvaBfEk9QFtDZBPLdmjb9wdfibHXzHonz1FMok5K+XSP4hAKH8EfE7D70Tqu?= =?us-ascii?Q?ZfILPe4Gw3K7tmA2z77c030VeGeF/c1+i8YujjLAES2gQZw5BZjDlxZ9v3SZ?= =?us-ascii?Q?oRvcNNwMTpXZUjlUdFZY2EL+1kHRlXJb+XtWsXwnmWyCwZZRe7oYF/XlTGd1?= =?us-ascii?Q?JROqUNX0GT7xB1+KGRDU/V23q9+klh2z7TeJUaWaXhQcfpT+BFjto/KS3LCp?= =?us-ascii?Q?nTAi5zzTDKi/ukFrhrsh7yCbJuh3DQbrv/Zi/P8moc894Zfx3i2E27S6ZFHI?= =?us-ascii?Q?Udba4QLzYDKitNi9csZtler5OM+FhmXhXFpA6Gpid/XuzATHDQBLW5QQlACB?= =?us-ascii?Q?nzh4d0YGmMYyM8PmU5+zlHI1FpMTk2ZhYJpWYagxfszypddLf7B8uIud0BUU?= =?us-ascii?Q?EAYbSVoWVyfyUgglz9VpCVUIorjzzY/8HsFTtam1iGwNPdbFJ2aC9kXCnL5h?= =?us-ascii?Q?hRezhNGMKhC4uUrKeL+RKiFKWKniIgqNYgF4HG6RGof5y58Em21Ea+VdFHkY?= =?us-ascii?Q?5pu/hWvQLVNwuMAlPDm2/uESnnxWnqdzxUNQoRXEDOemUH+whxZXVpIN6El1?= =?us-ascii?Q?+UZdXnVFtCRwogGOsOI7bAe8CT+M39QXpmUDw5XAnMU7PJy+rwkXlRDYOhFx?= =?us-ascii?Q?PJED7GWvdsQBI1o147bkUCsvqX6Lvp3L8NAU89C6be0pikIaAAgO0pXimB8G?= =?us-ascii?Q?4tWF5CJhOeLW3QPjkrcAZEf9EtP7pnXufLZDw1wyFoSlseGp/qYUCKA1OVOu?= =?us-ascii?Q?0ZbuhBXxSfA12euYxbThydFr7UavgzE/4a/N8dnAzsyhy2FDW2S6IullC7J4?= =?us-ascii?Q?AkMlKRuyvhg78vDRIqUvjPFHATdhepMEL+i/Tflnvv8rIJuXMKtc5h9h9Ky2?= =?us-ascii?Q?aVciFC/bWV+d4aTKFCDXqvlGLalnasbYJ/4lefrZYRzNmlJru+UGRxkpdWKR?= =?us-ascii?Q?UqznTjuJTj2M8o2j6Xj/JGQ0GkHMHkShwUSojGX0XheB/aQXBTgWz/QNgj54?= =?us-ascii?Q?hHZlX56kwcBhww01AAn13knokVOsp8Cm/zwrd7SdD5QfcFG/eTJusVVWKx1r?= =?us-ascii?Q?FOFhyTT6cB/C5Ui55p0ubuSHFAp1MxNh02xA9rqLGjYw0akr+ZIrYMZvOhbV?= =?us-ascii?Q?tEt85sLoNCqDb/Sh2V40KCBUnZ3uJVtFz38uTJLfvGhIPwYgNGyQzK2tGKUj?= =?us-ascii?Q?fTd82NplBDh1fPgyeYNiOx1As/NH0oAGePzsEQ2bW3uCec9D0b3WN2Q9SsR6?= =?us-ascii?Q?PtL0Lfh+ZPCAdyRRSkz7TXBEjMwgJV4wqcKXMUUDVCJ4quuedwsfHhz3ZzCl?= =?us-ascii?Q?mct0UE9eT9eZpNkUv0fby9y/QucNaeaowBHor7++UsZTRl5imntG0wncSf6Y?= =?us-ascii?Q?JwgiuUy2crA973rsB8S96D+5u9suMQLD8haX7yhFLSkYzO0AJ/rkzj/uwF2Y?= =?us-ascii?Q?VCioB0d7dcYLkmPs8zaUWC7b5rCFAqRr+9t6cGtAJi6IhmBU/41S0MULF5CP?= =?us-ascii?Q?tesU3sEmguLgUlxWn+sXIPfqrdjXRW8drHWS0jwDAOsJDoKBb/UR/Rus5uYE?= =?us-ascii?Q?xyL1CMg/dSLDd65ap8X7Tytfz3JUsN5165lTxZbZ?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: aab8895d-002b-4426-c02e-08dde0c4e732 X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9626.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2025 15:10:45.7975 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Grv8DbbPTMCoXh/VUlEV6RG4NSEn0M89vNsAajN4942XiS3/GeVHaW8wMk3wNUPM6k4Hl5u1ovyOxuYZ1Ignww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA2PR04MB10373 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250821_081052_173912_11570631 X-CRM114-Status: GOOD ( 20.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 21, 2025 at 03:09:34AM +0300, Laurent Pinchart wrote: > The mipi_csis_calculate_params() function needs to access the pad of the > connected source. The pad is already available in csis->source.pad, but > the function takes a convoluted path by getting the pad index and > indexing the source subdev's pads array. Simplify it. Generally, I like add "No functionality change" in commit message to help reviewer or developer direct skip this commit when bisect commit to indentify problem. Reviewed-by: Frank Li Frank Li > > Signed-off-by: Laurent Pinchart > --- > drivers/media/platform/nxp/imx-mipi-csis.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/platform/nxp/imx-mipi-csis.c b/drivers/media/platform/nxp/imx-mipi-csis.c > index 2beb5f43c2c0..46f93cd677e3 100644 > --- a/drivers/media/platform/nxp/imx-mipi-csis.c > +++ b/drivers/media/platform/nxp/imx-mipi-csis.c > @@ -579,13 +579,11 @@ static void __mipi_csis_set_format(struct mipi_csis_device *csis, > static int mipi_csis_calculate_params(struct mipi_csis_device *csis, > const struct csis_pix_format *csis_fmt) > { > - struct media_pad *src_pad = > - &csis->source.sd->entity.pads[csis->source.pad->index]; > s64 link_freq; > u32 lane_rate; > > /* Calculate the line rate from the pixel rate. */ > - link_freq = v4l2_get_link_freq(src_pad, csis_fmt->width, > + link_freq = v4l2_get_link_freq(csis->source.pad, csis_fmt->width, > csis->bus.num_data_lanes * 2); > if (link_freq < 0) { > dev_err(csis->dev, "Unable to obtain link frequency: %d\n", > -- > Regards, > > Laurent Pinchart >