From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: Andrew Lunn <andrew@lunn.ch>, Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org,
Gregory Clement <gregory.clement@bootlin.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Rob Herring <robh@kernel.org>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v2] ARM64: dts: mcbin: fix SATA ports on Macchiatobin
Date: Thu, 21 Aug 2025 19:06:20 +0100 [thread overview]
Message-ID: <aKdgHGElBEyHeP67@shell.armlinux.org.uk> (raw)
In-Reply-To: <E1up9Jw-00BbOE-VC@rmk-PC.armlinux.org.uk>
On Thu, Aug 21, 2025 at 06:43:28PM +0100, Russell King (Oracle) wrote:
> Booting 6.16 on the Macchiatobin, I discover that I can no longer
> access my disks, and thus the userspace boot fails. The cause appears
> to be that one of the SATA controllers doesn't have any ports:
>
> [ 1.190312] ahci f4540000.sata: supply ahci not found, using dummy regulator
> [ 1.196255] ahci f4540000.sata: supply phy not found, using dummy regulator
> [ 1.202026] ahci f4540000.sata: No port enabled
>
> This is as a result of the blamed commit below which added a default
> disabled status to the .dtsi, but didn't properly update the mcbin
> dtsi file. Fix this regression.
>
> Fixes: 30023876aef4 ("arm64: dts: marvell: only enable complete sata nodes")
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Frank,
I think this is also similarly broken by your patch:
arch/arm64/boot/dts/marvell/armada-8040-db.dts
as you've updated the ports on one SATA controller but not the other
in the same way as you omitted the second controller on mcbin.
I'd also question this:
arch/arm64/boot/dts/marvell/cn9132-clearfog.dts
as you updated the other cn9132, but not this one which was introduced
in 6.11, and your change was in 6.13. Please can you look at both of
these and send appropriate fixes?
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-08-21 23:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 17:43 [PATCH v2] ARM64: dts: mcbin: fix SATA ports on Macchiatobin Russell King (Oracle)
2025-08-21 18:06 ` Russell King (Oracle) [this message]
2025-08-21 18:20 ` Frank Wunderlich
2025-08-21 18:25 ` Andrew Lunn
2025-08-21 20:11 ` Russell King (Oracle)
2025-08-21 20:00 ` Russell King (Oracle)
2025-08-22 13:11 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKdgHGElBEyHeP67@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=gregory.clement@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).