From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BCECCA0EFA for ; Thu, 21 Aug 2025 23:21:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vuQY2HuepKB5t5U67BTcopXXonRlXHtdLgfJBFihPDE=; b=4DFLZwHq3vZr/ADmDANYb4jDz9 1SiHtIx9/1/RtIt+DHpkB/luj8m78s8NUz1o7RxrKKGRyU187+L/m2hJuOcPbFtvuk8ausT4qpnPt smvEUQ+NzSIs2fPuJNZ5y32h/7meL9u0ZsvWMZp/lBRI+V6JHntIassAE+tQ73JBIUEGHXyM/irfu EXiX7X6xClCJ+BdhbZuY3PmlS2id5ql2udICRXyRqS/ZgKY+NqZDlJDBWMh8aDmgOmCd1r8iPvzbc G/CUNisQBKOwSXtAC4Zfqy2s+bBvqfIcGADhqfxipYUKGa/grLkc3GG9P7+L7/wEdoFrlOGr4jLUN o7AFA/EQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1upEbN-00000000vbM-3lYZ; Thu, 21 Aug 2025 23:21:49 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1up9gG-000000008jY-18LG for linux-arm-kernel@lists.infradead.org; Thu, 21 Aug 2025 18:06:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=vuQY2HuepKB5t5U67BTcopXXonRlXHtdLgfJBFihPDE=; b=NbUsgwLrQXI4L+IQKROV3GcfNQ FRXJpQOKFHvHUFbaIbQ5mFL3W1xFqWpuwAMC8aNcbfCieNjYu3ELpr6yZvCZPebQ2WXWklJLc2QMX W66uybxtg1x8qyNxxKMj95XPOBSNOIpdL/QXqc11JDuHI+p1NbqRez9VzrSk8IaYOC1fyNSTMczVu mHBuk5k9g7/xVFB8zljWpmXPhlo7KQD6iODCCGYNd2JOOa0XMcVajeFm083zTeb0uX3wIcxED2pEP D1qt+90d8L5VzPbwFFG+6KrgIIjzJ31wNj47bbTfwf6hylnvrb0aVrw8+ocKMMf9syXyjdZ6bEXsd GzkUit/w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:38870) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1up9g7-000000001Tf-0XXn; Thu, 21 Aug 2025 19:06:23 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1up9g4-000000001Gr-27Qf; Thu, 21 Aug 2025 19:06:20 +0100 Date: Thu, 21 Aug 2025 19:06:20 +0100 From: "Russell King (Oracle)" To: Frank Wunderlich Cc: Andrew Lunn , Conor Dooley , devicetree@vger.kernel.org, Gregory Clement , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, Rob Herring , Sebastian Hesselbarth Subject: Re: [PATCH v2] ARM64: dts: mcbin: fix SATA ports on Macchiatobin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250821_110632_313145_823C91B3 X-CRM114-Status: GOOD ( 14.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 21, 2025 at 06:43:28PM +0100, Russell King (Oracle) wrote: > Booting 6.16 on the Macchiatobin, I discover that I can no longer > access my disks, and thus the userspace boot fails. The cause appears > to be that one of the SATA controllers doesn't have any ports: > > [ 1.190312] ahci f4540000.sata: supply ahci not found, using dummy regulator > [ 1.196255] ahci f4540000.sata: supply phy not found, using dummy regulator > [ 1.202026] ahci f4540000.sata: No port enabled > > This is as a result of the blamed commit below which added a default > disabled status to the .dtsi, but didn't properly update the mcbin > dtsi file. Fix this regression. > > Fixes: 30023876aef4 ("arm64: dts: marvell: only enable complete sata nodes") > Signed-off-by: Russell King (Oracle) Frank, I think this is also similarly broken by your patch: arch/arm64/boot/dts/marvell/armada-8040-db.dts as you've updated the ports on one SATA controller but not the other in the same way as you omitted the second controller on mcbin. I'd also question this: arch/arm64/boot/dts/marvell/cn9132-clearfog.dts as you updated the other cn9132, but not this one which was introduced in 6.11, and your change was in 6.13. Please can you look at both of these and send appropriate fixes? Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!