* Re: [PATCH] arm64: dts: imx95: Fix JPEG encoder node assigned clock
2025-08-20 16:27 [PATCH] arm64: dts: imx95: Fix JPEG encoder node assigned clock Marek Vasut
@ 2025-08-20 18:29 ` Laurent Pinchart
2025-08-20 18:35 ` Frank Li
2025-08-22 9:45 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2025-08-20 18:29 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-arm-kernel, Conor Dooley, Fabio Estevam,
Krzysztof Kozlowski, Nicolas Dufresne, Pengutronix Kernel Team,
Rob Herring, Sascha Hauer, Shawn Guo, devicetree, imx
Hi Marek,
Thank you for the patch.
On Wed, Aug 20, 2025 at 06:27:26PM +0200, Marek Vasut wrote:
> The assigned clock for JPEG encoder IP has to be IMX95_CLK_VPUBLK_JPEG_ENC
> and not IMX95_CLK_VPUBLK_JPEG_DEC (_ENC at the end, not _DEC). This is a
> simple copy-paste error, fix it.
>
> Fixes: 153c039a7357 ("arm64: dts: imx95: add jpeg encode and decode nodes")
> Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>
Looks like a straightforward fix.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: imx@lists.linux.dev
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> arch/arm64/boot/dts/freescale/imx95.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi b/arch/arm64/boot/dts/freescale/imx95.dtsi
> index 4ca6a7ea586ea..8296888bce594 100644
> --- a/arch/arm64/boot/dts/freescale/imx95.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx95.dtsi
> @@ -1843,7 +1843,7 @@ jpegenc: jpegenc@4c550000 {
> <GIC_SPI 294 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&scmi_clk IMX95_CLK_VPU>,
> <&vpu_blk_ctrl IMX95_CLK_VPUBLK_JPEG_ENC>;
> - assigned-clocks = <&vpu_blk_ctrl IMX95_CLK_VPUBLK_JPEG_DEC>;
> + assigned-clocks = <&vpu_blk_ctrl IMX95_CLK_VPUBLK_JPEG_ENC>;
> assigned-clock-parents = <&scmi_clk IMX95_CLK_VPUJPEG>;
> power-domains = <&scmi_devpd IMX95_PD_VPU>;
> };
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: imx95: Fix JPEG encoder node assigned clock
2025-08-20 16:27 [PATCH] arm64: dts: imx95: Fix JPEG encoder node assigned clock Marek Vasut
2025-08-20 18:29 ` Laurent Pinchart
@ 2025-08-20 18:35 ` Frank Li
2025-08-22 9:45 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Frank Li @ 2025-08-20 18:35 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-arm-kernel, Conor Dooley, Fabio Estevam,
Krzysztof Kozlowski, Laurent Pinchart, Nicolas Dufresne,
Pengutronix Kernel Team, Rob Herring, Sascha Hauer, Shawn Guo,
devicetree, imx
On Wed, Aug 20, 2025 at 06:27:26PM +0200, Marek Vasut wrote:
> The assigned clock for JPEG encoder IP has to be IMX95_CLK_VPUBLK_JPEG_ENC
> and not IMX95_CLK_VPUBLK_JPEG_DEC (_ENC at the end, not _DEC). This is a
> simple copy-paste error, fix it.
>
> Fixes: 153c039a7357 ("arm64: dts: imx95: add jpeg encode and decode nodes")
> Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: imx@lists.linux.dev
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> arch/arm64/boot/dts/freescale/imx95.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi b/arch/arm64/boot/dts/freescale/imx95.dtsi
> index 4ca6a7ea586ea..8296888bce594 100644
> --- a/arch/arm64/boot/dts/freescale/imx95.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx95.dtsi
> @@ -1843,7 +1843,7 @@ jpegenc: jpegenc@4c550000 {
> <GIC_SPI 294 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&scmi_clk IMX95_CLK_VPU>,
> <&vpu_blk_ctrl IMX95_CLK_VPUBLK_JPEG_ENC>;
> - assigned-clocks = <&vpu_blk_ctrl IMX95_CLK_VPUBLK_JPEG_DEC>;
> + assigned-clocks = <&vpu_blk_ctrl IMX95_CLK_VPUBLK_JPEG_ENC>;
> assigned-clock-parents = <&scmi_clk IMX95_CLK_VPUJPEG>;
> power-domains = <&scmi_devpd IMX95_PD_VPU>;
> };
> --
> 2.50.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: imx95: Fix JPEG encoder node assigned clock
2025-08-20 16:27 [PATCH] arm64: dts: imx95: Fix JPEG encoder node assigned clock Marek Vasut
2025-08-20 18:29 ` Laurent Pinchart
2025-08-20 18:35 ` Frank Li
@ 2025-08-22 9:45 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2025-08-22 9:45 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-arm-kernel, Conor Dooley, Fabio Estevam,
Krzysztof Kozlowski, Laurent Pinchart, Nicolas Dufresne,
Pengutronix Kernel Team, Rob Herring, Sascha Hauer, Shawn Guo,
devicetree, imx
On Wed, Aug 20, 2025 at 06:27:26PM +0200, Marek Vasut wrote:
> The assigned clock for JPEG encoder IP has to be IMX95_CLK_VPUBLK_JPEG_ENC
> and not IMX95_CLK_VPUBLK_JPEG_DEC (_ENC at the end, not _DEC). This is a
> simple copy-paste error, fix it.
>
> Fixes: 153c039a7357 ("arm64: dts: imx95: add jpeg encode and decode nodes")
> Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread