From: Brian Masney <bmasney@redhat.com>
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] clk: Sort include statements
Date: Fri, 22 Aug 2025 09:26:31 -0400 [thread overview]
Message-ID: <aKhwBxLdOH7R73BJ@x1> (raw)
In-Reply-To: <20250814035317.4112336-1-wenst@chromium.org>
On Thu, Aug 14, 2025 at 11:53:15AM +0800, Chen-Yu Tsai wrote:
> The clk core has its include statements in some random order.
>
> Clean it up before we add more.
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
> drivers/clk/clk.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index b821b2cdb155..2eb63d610cbb 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -6,21 +6,21 @@
> * Standard functionality for the common clock API. See Documentation/driver-api/clk.rst
> */
>
> +#include <linux/clk/clk-conf.h>
> +#include <linux/clkdev.h>
> #include <linux/clk.h>
> #include <linux/clk-provider.h>
> -#include <linux/clk/clk-conf.h>
> -#include <linux/module.h>
> -#include <linux/mutex.h>
> -#include <linux/spinlock.h>
> +#include <linux/device.h>
> #include <linux/err.h>
> +#include <linux/init.h>
> #include <linux/list.h>
> -#include <linux/slab.h>
> +#include <linux/module.h>
> +#include <linux/mutex.h>
> #include <linux/of.h>
> -#include <linux/device.h>
> -#include <linux/init.h>
> #include <linux/pm_runtime.h>
> #include <linux/sched.h>
> -#include <linux/clkdev.h>
> +#include <linux/slab.h>
> +#include <linux/spinlock.h>
Reviewed-by: Brian Masney <bmasney@redhat.com>
Just a note that vim will sort the four linux/clk* includes at the top
slightly differently, however I like what you have better.
next prev parent reply other threads:[~2025-08-23 6:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 3:53 [PATCH v2 1/2] clk: Sort include statements Chen-Yu Tsai
2025-08-14 3:53 ` [PATCH v2 2/2] clk: Use hashtable for global clk lookups Chen-Yu Tsai
2025-08-22 13:20 ` Brian Masney
2025-09-21 17:20 ` Stephen Boyd
2025-08-22 13:26 ` Brian Masney [this message]
2025-09-21 17:16 ` [PATCH v2 1/2] clk: Sort include statements Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKhwBxLdOH7R73BJ@x1 \
--to=bmasney@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox