From: Niklas Cassel <cassel@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Cc: Kishon Vijay Abraham I <kishon@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Anup Patel <apatel@ventanamicro.com>,
Marc Zyngier <maz@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Danilo Krummrich <dakr@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Arnd Bergmann <arnd@arndb.de>, Shuah Khan <shuah@kernel.org>,
Richard Zhu <hongxing.zhu@nxp.com>,
Lucas Stach <l.stach@pengutronix.de>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Rob Herring <robh@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Wilczy??ski <kwilczynski@kernel.org>,
Frank Li <Frank.Li@nxp.com>,
dlemoal@kernel.org, jdmason@kudzu.us,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
linux-kselftest@vger.kernel.org, imx@lists.linux.dev,
devicetree@vger.kernel.org
Subject: Re: (subset) [PATCH v21 0/9] PCI: EP: Add RC-to-EP doorbell with platform MSI controller
Date: Mon, 8 Sep 2025 17:08:35 +0200 [thread overview]
Message-ID: <aL7xc0aVi-olMAE-@flawful.org> (raw)
In-Reply-To: <175311109182.25848.8880954995049551501.b4-ty@kernel.org>
On Mon, Jul 21, 2025 at 08:48:11PM +0530, Manivannan Sadhasivam wrote:
> On Thu, 10 Jul 2025 15:13:46 -0400, Frank Li wrote:
> > [...]
>
> Applied, thanks!
>
> [3/9] PCI: endpoint: Add RC-to-EP doorbell support using platform MSI controller
> commit: b537ffe0eb2ab458f20ec135cc2b565c63a2ea00
> [4/9] PCI: endpoint: pci-ep-msi: Add MSI address/data pair mutable check
> commit: 1f2ed78e43abb9ac0856a82867f64d472368a832
> [5/9] PCI: endpoint: Add pci_epf_align_inbound_addr() helper for address alignment
> commit: 1c2c5f9855a5cf4617bcda721c22dbd3345f06a1
> [6/9] PCI: endpoint: pci-epf-test: Add doorbell test support
> commit: 5d4da5f8092e5a77ae371ae1112283b59790ac22
> [7/9] misc: pci_endpoint_test: Add doorbell test case
> commit: a1a293e709a4ec0fa2e4253993a4b75f581c6cf2
> [8/9] selftests: pci_endpoint: Add doorbell test case
> commit: b964b4894fcfc72e7496cf52a33cbba39d094c5b
Hello all,
I wanted to test this on rk3588, so I added msi-map to the pcie_ep node.
It works the first time:
# ./pcitest -r pcie_ep_doorbell.DOORBELL_TEST
TAP version 13
1..1
# Starting 1 tests from 1 test cases.
# RUN pcie_ep_doorbell.DOORBELL_TEST ...
[ 17.996519] offset: 70040
[ 17.997904] left: 250 status: 0x240
# OK pcie_ep_doorbell.DOORBELL_TEST
ok 1 pcie_ep_doorbell.DOORBELL_TEST
# PASSED: 1 / 1 tests passed.
# Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0
Prints on EP side:
[ 17.924761] pci_epf_test_enable_doorbell
[ 17.926035] doorbell offset: 70040
[ 17.927898] pci_epf_test_doorbell_handler
[ 17.932816] pci_epf_test_disable_doorbell
However, if I run the exact same test case again:
# ./pcitest -r pcie_ep_doorbell.DOORBELL_TEST
TAP version 13
1..1
# Starting 1 tests from 1 test cases.
RUN pcie_ep_doorbell.DOORBELL_TEST ...
[ 34.672546] offset: 70040
[ 35.688190] left: 0 status: 0x0
[ 35.688480] pci-endpoint-test 0000:01:00.0: Failed to trigger doorbell in endpoint
# pci_endpoint_test.c:258:DOORBELL_TEST:Expected 0 (0) == ret (-22)
# pci_endpoint_test.c:258:DOORBELL_TEST:Test failed for Doorbell
# DOORBELL_TEST: Test failed
# FAIL pcie_ep_doorbell.DOORBELL_TEST
not ok 1 pcie_ep_doorbell.DOORBELL_TEST
# FAILED: 0 / 1 tests passed.
Prints on EP side:
[ 34.600717] pci_epf_test_enable_doorbell
[ 34.602086] doorbell offset: 70040
[ 35.624718] pci_epf_test_disable_doorbell
As you can see the print that I added in pci_epf_test_doorbell_handler()
never comes the second time executing this test case.
Frank, do you see the same problem?
Kind regards,
Niklas
next prev parent reply other threads:[~2025-09-08 18:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 19:13 [PATCH v21 0/9] PCI: EP: Add RC-to-EP doorbell with platform MSI controller Frank Li via B4 Relay
2025-07-10 19:13 ` [PATCH v21 1/9] PCI: imx6: Add helper function imx_pcie_add_lut_by_rid() Frank Li via B4 Relay
2025-07-10 19:13 ` [PATCH v21 2/9] PCI: imx6: Add LUT configuration for MSI/IOMMU in Endpoint mode Frank Li via B4 Relay
2025-07-10 19:13 ` [PATCH v21 3/9] PCI: endpoint: Add RC-to-EP doorbell support using platform MSI controller Frank Li via B4 Relay
2025-07-10 19:13 ` [PATCH v21 4/9] PCI: endpoint: pci-ep-msi: Add MSI address/data pair mutable check Frank Li via B4 Relay
2025-07-10 19:13 ` [PATCH v21 5/9] PCI: endpoint: Add pci_epf_align_inbound_addr() helper for address alignment Frank Li via B4 Relay
2025-07-10 19:13 ` [PATCH v21 6/9] PCI: endpoint: pci-epf-test: Add doorbell test support Frank Li via B4 Relay
2025-07-10 19:13 ` [PATCH v21 7/9] misc: pci_endpoint_test: Add doorbell test case Frank Li via B4 Relay
2025-07-10 19:13 ` [PATCH v21 8/9] selftests: pci_endpoint: " Frank Li via B4 Relay
2025-07-10 19:13 ` [PATCH v21 9/9] arm64: dts: imx95: Add msi-map for pci-ep device Frank Li via B4 Relay
2025-08-22 14:24 ` Frank Li
2025-09-10 8:32 ` Shawn Guo
2025-07-11 7:45 ` [PATCH v21 0/9] PCI: EP: Add RC-to-EP doorbell with platform MSI controller Niklas Cassel
2025-07-21 13:25 ` (subset) " Manivannan Sadhasivam
2025-07-21 15:18 ` Manivannan Sadhasivam
2025-09-08 15:08 ` Niklas Cassel [this message]
2025-09-08 15:35 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aL7xc0aVi-olMAE-@flawful.org \
--to=cassel@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=apatel@ventanamicro.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=dakr@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hongxing.zhu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=jdmason@kudzu.us \
--cc=kernel@pengutronix.de \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
--cc=maz@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).