linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Andrea della Porta <andrea.porta@suse.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Andrea della Porta <andrea.porta@suse.com>,
	linux-arm-kernel@lists.infradead.org,
	florian.fainelli@broadcom.com,
	Ulf Hansson <ulf.hansson@linaro.org>,
	linux-gpio@vger.kernel.org,
	Jonathan Bell <jonathan@raspberrypi.com>,
	svarbanov@suse.de, linus.walleij@linaro.org,
	devicetree@vger.kernel.org, linux-serial@vger.kernel.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	conor+dt@kernel.org,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Jiri Slaby <jirislaby@kernel.org>,
	krzk+dt@kernel.org, Al Cooper <alcooperx@gmail.com>,
	linux-mmc@vger.kernel.org, wahrenst@gmx.net, iivanov@suse.de,
	mbrugger@suse.com, Will Deacon <will@kernel.org>,
	Phil Elwell <phil@raspberrypi.com>
Subject: Re: [PATCH v2 0/5] Add peripheral nodes to RaspberryPi 5 DT
Date: Fri, 29 Aug 2025 11:17:58 +0200	[thread overview]
Message-ID: <aLFwRrfjmq1wU8-b@apocalypse> (raw)
In-Reply-To: <175641306018.2175061.15558471823903740794.robh@kernel.org>

Hi Rob,

On 15:31 Thu 28 Aug     , Rob Herring (Arm) wrote:
> 
> On Thu, 28 Aug 2025 15:17:09 +0200, Andrea della Porta wrote:
> > Hi,
> > 
> > The following patches add a few peripheral DT nodes and related pin/gpio
> > nodes for Raspberry Pi 5.
> > 
> > - Patch 1: Amend the bindings to avoid DT compiler warnings.
> > 
> > - Patch 2: Adds core pinctrl nodes and defines SD pins as a first appliance
> >   for the pinctrl.
> > 
> > - Patch 3: Wires the gpio-key for power button and related gpio controller.
> > 
> > - Patch 4: Adds DT node for WiFi.
> > 
> > - Patch 5: Adds Bluetooth DT node.
> > 
> > All comments and suggestions are welcome!
> > 
> > Happy hacking!
> > Ivan and Andrea
> > 
> > 
> > CHANGES in V2:
> > 
> > --- DTS ---
> > 
> > - bcm2712.dtsi: added a proper clocks node to the uarta serial
> >   in order to replace the legacy clock-frequency property. As
> >   a result, the following patch from the previous patchset
> >   has been dropped since it's now useless:
> > 
> >   "dt-bindings: serial: Add clock-frequency property as an alternative to clocks"
> > 
> > 
> > Andrea della Porta (1):
> >   dt-bindings: mmc: Add support for capabilities to Broadcom SDHCI
> >     controller
> > 
> > Ivan T. Ivanov (4):
> >   arm64: dts: broadcom: bcm2712: Add pin controller nodes
> >   arm64: dts: broadcom: bcm2712: Add one more GPIO node
> >   arm64: dts: broadcom: bcm2712: Add second SDHCI controller node
> >   arm64: dts: broadcom: bcm2712: Add UARTA controller node
> > 
> >  .../bindings/mmc/brcm,sdhci-brcmstb.yaml      |   2 +-
> >  .../dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts  | 133 ++++++++++++++++++
> >  arch/arm64/boot/dts/broadcom/bcm2712.dtsi     |  55 ++++++++
> >  3 files changed, 189 insertions(+), 1 deletion(-)
> > 
> > --
> > 2.35.3
> > 
> > 
> > 
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> This patch series was applied (using b4) to base:
>  Base: attempting to guess base-commit...
>  Base: tags/next-20250828 (exact match)
> 
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
> 
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/broadcom/' for cover.1756386531.git.andrea.porta@suse.com:
> 
> arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dtb: /soc@107c000000/pinctrl@7d504100: failed to match any schema with compatible: ['brcm,bcm2712c0-pinctrl']
> arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dtb: /soc@107c000000/pinctrl@7d504100: failed to match any schema with compatible: ['brcm,bcm2712c0-pinctrl']
> arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dtb: /soc@107c000000/pinctrl@7d510700: failed to match any schema with compatible: ['brcm,bcm2712c0-aon-pinctrl']
> arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dtb: /soc@107c000000/pinctrl@7d510700: failed to match any schema with compatible: ['brcm,bcm2712c0-aon-pinctrl']
> arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dtb: hvs@107c580000 (brcm,bcm2712-hvs): clocks: [[28, 4], [28, 16]] is too long
> 	from schema $id: http://devicetree.org/schemas/display/brcm,bcm2835-hvs.yaml#
> arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dtb: hvs@107c580000 (brcm,bcm2712-hvs): clocks: [[28, 4], [28, 16]] is too long
> 	from schema $id: http://devicetree.org/schemas/display/brcm,bcm2835-hvs.yaml#
> arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: /soc@107c000000/pinctrl@7d504100: failed to match any schema with compatible: ['brcm,bcm2712c0-pinctrl']
> arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: /soc@107c000000/pinctrl@7d510700: failed to match any schema with compatible: ['brcm,bcm2712c0-aon-pinctrl']
> arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: hvs@107c580000 (brcm,bcm2712-hvs): clocks: [[28, 4], [28, 16]] is too long
> 	from schema $id: http://devicetree.org/schemas/display/brcm,bcm2835-hvs.yaml#
> 
>

For some reason I've dropped, from the previous cover letter, the
phrase mentioning that this patchset depends on this patchset:

https://lore.kernel.org/all/7ed0f2779829f4e63b69d8cf5cedda9f849996bc.1756372805.git.andrea.porta@suse.com/

which contains the schema. If you apply it as prerequisite, warnings
should disappear.

Many thanks,
Andrea


      reply	other threads:[~2025-08-29 14:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-28 13:17 [PATCH v2 0/5] Add peripheral nodes to RaspberryPi 5 DT Andrea della Porta
2025-08-28 13:17 ` [PATCH v2 1/5] dt-bindings: mmc: Add support for capabilities to Broadcom SDHCI controller Andrea della Porta
2025-08-29 18:01   ` Rob Herring (Arm)
2025-08-28 13:17 ` [PATCH v2 2/5] arm64: dts: broadcom: bcm2712: Add pin controller nodes Andrea della Porta
2025-08-28 13:17 ` [PATCH v2 3/5] arm64: dts: broadcom: bcm2712: Add one more GPIO node Andrea della Porta
2025-08-28 13:17 ` [PATCH v2 4/5] arm64: dts: broadcom: bcm2712: Add second SDHCI controller node Andrea della Porta
2025-08-28 13:17 ` [PATCH v2 5/5] arm64: dts: broadcom: bcm2712: Add UARTA " Andrea della Porta
2025-08-28 20:31 ` [PATCH v2 0/5] Add peripheral nodes to RaspberryPi 5 DT Rob Herring (Arm)
2025-08-29  9:17   ` Andrea della Porta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aLFwRrfjmq1wU8-b@apocalypse \
    --to=andrea.porta@suse.com \
    --cc=alcooperx@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=iivanov@suse.de \
    --cc=jirislaby@kernel.org \
    --cc=jonathan@raspberrypi.com \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mbrugger@suse.com \
    --cc=phil@raspberrypi.com \
    --cc=robh@kernel.org \
    --cc=svarbanov@suse.de \
    --cc=ulf.hansson@linaro.org \
    --cc=wahrenst@gmx.net \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).