From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09935CA1009 for ; Wed, 3 Sep 2025 19:54:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gfmvWaIixDi2q3/49/4wiYa+G8FpzcIwihG21GSRf5M=; b=X4Yo8uXgd5g0dH96M82iL3Jjcn Sx60KhywTSyVKi4NkCPpCZCyvwlg80rhSyA+EdocNZvZmhT6kjlMK6wODNeGh95L8baStBsh5pwBh 175Oz+JCEDpK6yJlBwki43VTO284IH/hpsrhOb4pRwxUP/1WvgaiEzlfbM9f50ibAdwyNvQTP9Uwm FqAiHyqj2HCNWRC03YzBuNcomO1+dsn4Q2APVRm7EVMyEWx6xs9eK+TLxOb3zDBPI3frbx8GpmOmi 2TPb3KYG3FLDq/D+43CL554GH+7h2jj1I8iOrBnr3kZuUQZdcD28yS3S+cXn8dcer5tHovRK2waZR vJGVW4GQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uttZ4-00000007UcI-3GKk; Wed, 03 Sep 2025 19:54:42 +0000 Received: from mail-francecentralazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c20a::7] helo=PA4PR04CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1utoof-00000006nXh-3hxl for linux-arm-kernel@lists.infradead.org; Wed, 03 Sep 2025 14:50:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PWmJfV74HPx7h2F7IWPD3GgodY9O07WotcCUKvba28NmSunnZrwiD03ubDvc8ieI7E9fkBUJqQczaU8m/tZ9++qEHl8oaXphgF8AM7sPjV4Ls7jL/plGWk/1XlZxWnZL21Wp06AJmO0P0p1pFGpmBBVodJkETV5owF2ZOl2FmRhqrLcMCFFiHG/SUFCiz73gX0zKZQ9nVGFHqGO3ynhOiLTev6MSRxvm+4x+MqxeEMzvo/8AWchG/YRiT0+vsrHrr09qsR9tYVSoi5OKJHKWmTuyQDbuCsXqeVEWVDtib9GMly3LQnXu+BMMx3OxYeGMAsn2/h+cWy3JM2bFrsXDcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gfmvWaIixDi2q3/49/4wiYa+G8FpzcIwihG21GSRf5M=; b=lngBswZRgYtXZxUfuHpmWMuQaZX7ajiqYLyf4IQTyLTK55l6E18g2qReak+43Aci0RiYlw1xAYtXy3hMrjZ8zsMsFhWQenACnmp1BUvyvw3XVRdGzEIY32Aq86vTEvqDjnM/qu3DrPAmWNnOgqxk7P5AplSSdoilToDYETWdzf0lw7dPzolDjwP9oXXVEGZd/Jqfeltp19VyO0opkqoO/Ssek0KzfpNZsQUC+e91uC5t641yRsZfN1b64nEuIABdAs3nDo1yrlz+2sp8Mm4UD6qIAGCu9xJDBhZUVqnzd2tb9FHex8PqVM3eswczZRFttU+Q/noSbq9bmJSEzUL1hQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gfmvWaIixDi2q3/49/4wiYa+G8FpzcIwihG21GSRf5M=; b=Dr/b3eBBD9fabuVh30otNHUarj/QGFcXKvaG1QzxzY03nzmwEEqXQVpCTMn1tZkHl4h6vlmjSl3aYa7Em+Fmg4Qe2RXckG7YuXGjFBqXgtg3tSGeJShz7nFkWNZ+qUe0ADCmisgy4SLfH8dxurC1+cTUew/5bf6Lqt+ye3dfYXvWEkNq7/tieyxhCUXYHgW9FwCz6v/UtE6j7ran4U1u217JbK6SGdI+3HJywmst3E7fPk2Jq2l2dE9S+UarpAfVWt0krUE60vslRJJvx2W2FEBVzt4+0V44LBLIwOspV6xfL5g60qPdZHuM5gWLpCaIQAiWcRxaVXxin5le9e+OhQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXSPRMB0053.eurprd04.prod.outlook.com (2603:10a6:102:23f::21) by AM9PR04MB8422.eurprd04.prod.outlook.com (2603:10a6:20b:3ea::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.16; Wed, 3 Sep 2025 14:50:25 +0000 Received: from PAXSPRMB0053.eurprd04.prod.outlook.com ([fe80::504f:2a06:4579:5f15]) by PAXSPRMB0053.eurprd04.prod.outlook.com ([fe80::504f:2a06:4579:5f15%7]) with mapi id 15.20.9094.015; Wed, 3 Sep 2025 14:50:25 +0000 Date: Wed, 3 Sep 2025 10:50:17 -0400 From: Frank Li To: Marco Felsch Cc: Vinod Koul , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jiada Wang , dmaengine@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/11] dmaengine: imx-sdma: sdma_remove minor cleanups Message-ID: References: <20250903-v6-16-topic-sdma-v1-0-ac7bab629e8b@pengutronix.de> <20250903-v6-16-topic-sdma-v1-2-ac7bab629e8b@pengutronix.de> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250903-v6-16-topic-sdma-v1-2-ac7bab629e8b@pengutronix.de> X-ClientProxiedBy: BYAPR03CA0028.namprd03.prod.outlook.com (2603:10b6:a02:a8::41) To PAXSPRMB0053.eurprd04.prod.outlook.com (2603:10a6:102:23f::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXSPRMB0053:EE_|AM9PR04MB8422:EE_ X-MS-Office365-Filtering-Correlation-Id: f7a6efbd-8995-459f-ce32-08ddeaf93756 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|19092799006|7416014|1800799024|7053199007|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?lKtlkuU4T/aSrujQb/09eSUSoPAhtp5dpsVgff14K3QPs2dVveT04X75rxre?= =?us-ascii?Q?AhU3dJKpYlr60jdqVifzohnPrcdtyQ1HZpNY4VlxjA276RwE9l0GbMIAmFOM?= =?us-ascii?Q?AOh+dNLsLrBcj9Huj5KerQ7zowseOpGG7Wkjh/USspLhVeOCQ1UzvzrF9Rjx?= =?us-ascii?Q?FXkcZHnxyFjlDVrAFjjwlN9K4+wi60XQtzeXZTHlInfPUS5lxen149PuM/Q8?= =?us-ascii?Q?MdKc8cN0RIVFwubpnGqYsxGx7JdN/gFCa4ZXErZzj0DCPWI7RlYpsRFpGnIo?= =?us-ascii?Q?7KDnPJ0tILx2PsehH8IKrrsjN9MkDKWt9me90DqG7qBoZynuKNxQOI+6hrMp?= =?us-ascii?Q?0nHm0hnUkpqawbsRITAOvE6Y4r2hnMiIPdEvkf528EblxYR1QCQRjTedk5KN?= =?us-ascii?Q?vZq0xkKprAcawr2dunWYZOpi6sg5FeNDNSqYpsIwZx8DadzO7DVAzxGEieHZ?= =?us-ascii?Q?EJa3AZIF96A2ZBCM7PK6lMocSU03iGFuUFu6L01LrQUqT3CQUlP1Y3T8iq4+?= =?us-ascii?Q?sfo20rCokAXYq2+ZuVHBHceWYA5ehKJJvnmTn1yGF1Caole5EOIMWylqUHdL?= =?us-ascii?Q?eedve6w7JRyji1twBRvx1CzvXhKvAAcLFSnSu6Q85oigJ1+ttu7lbuxpmwnH?= =?us-ascii?Q?bH2HZMZ0Mos1LCKOLZuryetUPWCRo9eJX1eVaIu87BeyC2qdud1wZfIMfsvi?= =?us-ascii?Q?OwoRJ5dPnz6YF2vPjHexx7QGEtXMf5mFCC/zu1VMPGGdLYC9KqKoS9dHGhzu?= =?us-ascii?Q?2Sg+bgXCbhciHHbV922wpa5ckfmTZHOEKryqHftFOo+Z10rgChxa6Ozd3lZB?= =?us-ascii?Q?RrIkBW8kbATZsu6Yjq1SiICYY2j6vpZD8xjXLbBleIjxeB0/Afr0fAxEzmx/?= =?us-ascii?Q?SZuksDCAUWsgHqro0LCnhIP3O/15hH50IKoc/YipauK1zsam1d5d7m9WiRRT?= =?us-ascii?Q?pO6lkafUiZVVqSKa4F93qKRqFkIq90vNryiV9N+DcMj7Q5bCLQHXcQVuFKOh?= =?us-ascii?Q?xA1so34m5SmwVJseflBRm3fPo8ud9ywM/xF4awc84AY8aHl4AM1B1w9XFaNd?= =?us-ascii?Q?hfuiZoEoD9a/jerQP5tEZ0lD3lnANiShpGdU7YXDxcxBEypO1/8R74FBw4ia?= =?us-ascii?Q?0uSQ1OiPoS4hC637GULnM4K/bExcdOjyqiw7VbXuEjUDUXsv6Gfy2lB2Sdaf?= =?us-ascii?Q?iqI7FQiMnUS+qZ1NWhFESB4C3RPV55uLbg73twMJ7KT5OSTju1KPALd2yEmQ?= =?us-ascii?Q?wAf5V0eC7gbkDyGhu6BfHEMawdvtESyilcBT8D5yrXyic3suN4CZVWo38erE?= =?us-ascii?Q?1N78waIfblzfCCrdWRvm1xjR79YfEe/dBhW41HGF3bbeJcPNi/Tjl4ymdhVL?= =?us-ascii?Q?5qjI8uacpSAdT0LppIL+ijQMJov2zNipn9POLOjjHzZvZDfl7ZJOfyYKjFgc?= =?us-ascii?Q?GXv9yAuvDzVy3bsUjklrvaZOtGP4BGb6GQP25n92Y8y3KlSXpYqZjg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXSPRMB0053.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(19092799006)(7416014)(1800799024)(7053199007)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ftz89owUsGlNXsnY1mq04EggMNjqkwOt3hzVthExm5SDYpe+ZXMhaxPFegQb?= =?us-ascii?Q?knHGeQ3p3p/4e4fs/Ulxs67gd10BrSk0lRje5NoD4QBEfTK6BDM5edlwF8cn?= =?us-ascii?Q?NuvxzY5uYixiNWUt/kKZ3d3r5HauF0vqDirHfP/kP5ACpe7yAsRdSmQkrZd6?= =?us-ascii?Q?bCQv4LEKU1ItVG1DH1FMAueMIGKaT0Y+BkIXt3PrD5ysUalyvwG+W0gC3XvD?= =?us-ascii?Q?iT3uEKNs8BS2WXG8+J4EM288mkukxUMrX0Ut4PRdoA1Dt/Gdfqllsbf70gIF?= =?us-ascii?Q?Ix+DzjjA/8W3T+iOxPF3jedtkWzHtGPhMV13+9THBv3cdogLu86cJseDS5kH?= =?us-ascii?Q?vE42T5/pTcKZ+t0eM/XhsJLMnEWqYFTPsE/w4R8VlG0OresGdLytSUHlxq5n?= =?us-ascii?Q?po90xZsXDaZwyhYJs639S+E77v4yOZsGKDQ0I2CHh9w300dydmujVbLdW8/J?= =?us-ascii?Q?O6lxxsSPw7IqVhKZ/+VWlE7bSz+r1SaxIjUDmiwnX447ORDVKKypwo9cxASQ?= =?us-ascii?Q?//Bnpx6mE+glhnuumqEYpI9wTJMudqMv5Ltf1jeDg9ivmmmFgDilTeuP/XgS?= =?us-ascii?Q?3wYKJ42y+BzbaCdl6eHNZuoSG7EXphQtagJ2s/uRoveaaj9dD6x/Go9k4r6B?= =?us-ascii?Q?LqFn3qMeMppKSFvfSqUpTnaJfmEBicN25rAxZxPMbN0zP983P04qvfruRIUp?= =?us-ascii?Q?LUlyxoBtAjF/4mGaynqKw87tWzUMEDQQWSMPs0vH3JYreKU8ZzTFIHSACRtJ?= =?us-ascii?Q?THKPKJm9xp9yKxgrwGoi64KhSPSWFw307/f/gW/QH3ZeqL4gQHpcYIHClBGv?= =?us-ascii?Q?f+7UJTCMnv7sNgdkr/15a1ho8ftquWtMzQ3e8VnNb2+aB9bwgWnmgWUx3kBP?= =?us-ascii?Q?FGnQGMOa/RNugOe8QVgP5TDnXdFLzxvvnrXbih1rH4h1OZ/jh2NatgrCGnwr?= =?us-ascii?Q?wi3nN4mju79e69qsHkHX469q0zN5z98o0FhnPucGENrxq45h/RA2wQOfJMzX?= =?us-ascii?Q?foVxCUB1UqsO2favFsject2yRMojYP3iAkXCnNSPA0RSR7qdrrzAOt+bcpSr?= =?us-ascii?Q?fbNiX179CmyTnXmwWkrrDXZprF/sg/pny2Mo5EPp43ccUWD6OMxHrytIPweN?= =?us-ascii?Q?laTRJVXv6S3eeC8+2pEvOV47kpJdQPgj4YRFN4ghIwqonp/jb9GXvXmxc867?= =?us-ascii?Q?uCn95Rsp0++PSjqsEGmP5MbLZEgaCBdGZb3GshOCiF1pPhmj6J+AhCx8hFcg?= =?us-ascii?Q?Y4o3i7WTKsVW2XA4zhcVFYGrPY+0Tm3RG+VRzL8dGOHVjyH5Y7SZoEuUXRQB?= =?us-ascii?Q?qc/FoN2mnLUpTFx1aVUnw++IP9F83+OLk9B4K8TRm1cPOJKKlhTU7Fg/sfPI?= =?us-ascii?Q?w/VfFmPRg01e0zuOulniAyRh5cTxmUOKY6vVDpXBRO7QJgFRZ/lwX4BmyBlI?= =?us-ascii?Q?I0Bf8ulK6F5qJOrcE4cIZbKK7ZVFVQ9kdo+A9H8hqnhL+0v+ei8GcEL48ijr?= =?us-ascii?Q?lsAJFV6oCDBi5xEKBhnjeiXSkOnbmjOsYIw1k0Ia6BFywDh4cL940JXqeR4z?= =?us-ascii?Q?W0Zpij56j92KGDRxlX8=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7a6efbd-8995-459f-ce32-08ddeaf93756 X-MS-Exchange-CrossTenant-AuthSource: PAXSPRMB0053.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2025 14:50:25.4762 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PmE/Wc4bF9dvXG2163SHVMotuqG4p15i3UWeRw+heAs0xF9w9dZW1DZJoClgzMAgaMWTDlyinmAxfDEHhr4Hsw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8422 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250903_075029_923776_84E31367 X-CRM114-Status: GOOD ( 21.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 03, 2025 at 03:06:10PM +0200, Marco Felsch wrote: > We don't need to set the pdev driver data to NULL since the device will > be freed anyways. > > Also drop the tasklet_kill() since this is done by the virt-dma driver > during the vchan_synchronize(). > > Signed-off-by: Marco Felsch Reviewed-by: Frank Li > --- > drivers/dma/imx-sdma.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c > index 89b4b1266726a9c8a552dc48670825ae00717e1c..422086632d3445b2ce3f2e5df9b2130174a311e8 100644 > --- a/drivers/dma/imx-sdma.c > +++ b/drivers/dma/imx-sdma.c > @@ -2423,11 +2423,8 @@ static void sdma_remove(struct platform_device *pdev) > for (i = 0; i < MAX_DMA_CHANNELS; i++) { > struct sdma_channel *sdmac = &sdma->channel[i]; > > - tasklet_kill(&sdmac->vc.task); > sdma_free_chan_resources(&sdmac->vc.chan); > } > - > - platform_set_drvdata(pdev, NULL); > } > > static struct platform_driver sdma_driver = { > > -- > 2.47.2 >