From: Will Deacon <will@kernel.org>
To: Stephan Gerhold <stephan.gerhold@linaro.org>
Cc: Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>,
Rob Clark <robin.clark@oss.qualcomm.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Johan Hovold <johan@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/arm-smmu-qcom: Enable use of all SMR groups when running bare-metal
Date: Fri, 19 Sep 2025 08:51:01 +0100 [thread overview]
Message-ID: <aM0LZVudBKjWuVrT@willie-the-truck> (raw)
In-Reply-To: <aMsJHheI6Y1V5q74@linaro.org>
On Wed, Sep 17, 2025 at 09:16:46PM +0200, Stephan Gerhold wrote:
> I realize it is weird to allow non-architectural features like this, but
> I haven't found any indication that the additional SMRs work any
> different from the standard ones. The SMMU spec seems to reserve space
> for up to 256 SMRs in the address space and the register bits, as if it
> was intended to be extended like this later. That's also why it works
> correctly without any changes in arm-smmu.c: the bit masks used there
> already allow up to 256 SMRs.
>
> What do you think?
Although it's all pretty ugly, I think we really only have two choices:
- Teach the core driver code about all this and use an rmr-like scheme
to leave the upper SMRs in bypass
- Hack it in the impl code as per your patch
The latter option is probably the most pragmatic (especially considering
the need to handle the virtualised case differently) but I'd like to see
what Robin thinks.
Will
next prev parent reply other threads:[~2025-09-19 7:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 8:33 [PATCH] iommu/arm-smmu-qcom: Enable use of all SMR groups when running bare-metal Stephan Gerhold
2025-09-09 12:57 ` Will Deacon
2025-09-09 15:35 ` Stephan Gerhold
2025-09-17 18:02 ` Robin Murphy
2025-09-17 19:16 ` Stephan Gerhold
2025-09-19 7:51 ` Will Deacon [this message]
2025-10-28 10:53 ` Stephan Gerhold
2025-11-25 18:05 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aM0LZVudBKjWuVrT@willie-the-truck \
--to=will@kernel.org \
--cc=andersson@kernel.org \
--cc=iommu@lists.linux.dev \
--cc=johan@kernel.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=robin.murphy@arm.com \
--cc=stephan.gerhold@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox