From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B3F5CAC59A for ; Fri, 19 Sep 2025 15:26:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+5qVhNxx6LIHyVPEm4y1NXgWrQ46w9RVMHlq+w4fVDQ=; b=zTNDDL7498B54IB9q4/Te9oxGA ekv1nfg6Iqu+970eszWtrxgXWDurlNWpVHadeCjh0AuQQelij7m2SfAO5NowjAFZKqfSYK/lt3LWz EttumGY6MdiF46NICsrn0OTFeo046OXE1TiNQL9QXJMnsmG8ptrUGyhVMkiISLuVoYmK761ZRUhas /blqzRsq8XvM4D5/YbNHI7Zqz3PVwoC4SWxKNFDQndv2QNGmVZyXtqrN2DrGqCuz/wwc0EwDbV2Um zGzebJC4XuwgVUsKYANcgFQ2mwEA6hBMhKxwhiUVZn63d8e+b9T+vnVwRqD7Wbnzi4nyLSm6vH7N0 D8Ligj5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uzd0d-00000003KVE-1kXg; Fri, 19 Sep 2025 15:26:51 +0000 Received: from mail-norwayeastazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c20f::7] helo=OSPPR02CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uzd0b-00000003KU2-1nqz for linux-arm-kernel@lists.infradead.org; Fri, 19 Sep 2025 15:26:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nL0LpmTutKa7+bEZj/QP+Ji9fAoZh7V0Vz/iXdXUTzfcn061z+b3pxKMGkpFd1sqssQzpsDv/2qmxABDm3fiImdwCha3elu79DLcSk65M5YhL9atNzHJYeTbmdgVmgl8VrpChcoNNR0XJQ2TxdG5Fd78yeP/5X+k9TbbUk9D4a/d45ZYegaU4gGopUsGfa2dAQj2JoovJH4CZ3+oFo5DtjxOhJYCWI6xAeCuH9mtOuP53oQJUy+a8Ipb+iOt5c5N4Aua+Ko3X4kQsD98LVtQxiHYkRChWPpyKsthUd3+U56rzPOjfN7kOGdsUzITMRD+uG+AUx/LPX7VnyXSYt+f9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+5qVhNxx6LIHyVPEm4y1NXgWrQ46w9RVMHlq+w4fVDQ=; b=Fl5xmN4OKSosBIdxqvuLrHowwx+2zsqzyKGTiSL+gXSIcmSqYLv7YZFqCRPRw4S18JC+4VzPr4XdRyhOdVDDxj9z5HRPHnwVJ+/yCKrjoPwJR5IfgpM4mxNNmZopmJ5YbLJvfkZwhq5FY7q674JDnk6fNXTOAXR6HP71mzw0ObDXFZojgKpf4oxxeCivY3/KLik4fT0Bc1AK2saRwx0c9SepzdnemcjKiOHUF+cH2uB7u8JcakpxKT8T7f8D8+eBumzYywgTpq/emHsEKNeOMSzGROLGSW60yY12a4/vUsmHgnYCkG9QPSEJioOWPbJFeeZWDhrVLLmKBvwVgNq4BA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+5qVhNxx6LIHyVPEm4y1NXgWrQ46w9RVMHlq+w4fVDQ=; b=M9SLDLMup3b0kFZwfBpJyyOWlHAWGh7T8Dx8E9G3aCrZLJIw9oXOtB4RuVuR5YjZbtk1h4q5mtGNa2Jur+8aAWqihflRlMMk8ga/JXhlWy9j9a0kRQ9mVFWDfekhDn4fL7sIz/tI67gZ7b8w1ajXR8Ktd46ETt8FSmGReC2+KxFF6aAALRTRHpZdGCPWy9WjxSAm/HRf7N47aYuQA97PTHpjcJ7a+QyTpWqXOGCUMTpF2f/cxEwfl28X9MrJU3o+QQEzOKGi62rW6sr16qA63Vy+PtKWauqtKI/rY0OhGPJrmBHTRtgYqeeOqk5mPPlFaUJKWRAFEiYsksJVO8aclA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXSPRMB0053.eurprd04.prod.outlook.com (2603:10a6:102:23f::21) by PA1PR04MB10098.eurprd04.prod.outlook.com (2603:10a6:102:45b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9137.16; Fri, 19 Sep 2025 15:26:39 +0000 Received: from PAXSPRMB0053.eurprd04.prod.outlook.com ([fe80::504f:2a06:4579:5f15]) by PAXSPRMB0053.eurprd04.prod.outlook.com ([fe80::504f:2a06:4579:5f15%6]) with mapi id 15.20.9137.015; Fri, 19 Sep 2025 15:26:39 +0000 Date: Fri, 19 Sep 2025 11:26:30 -0400 From: Frank Li To: Liu Ying Cc: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/14] drm/imx: dc-lb: Support getting secondary input selectio Message-ID: References: <20250704-imx8-dc-prefetch-v1-0-784c03fd645f@nxp.com> <20250704-imx8-dc-prefetch-v1-10-784c03fd645f@nxp.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250704-imx8-dc-prefetch-v1-10-784c03fd645f@nxp.com> X-ClientProxiedBy: PH0PR07CA0046.namprd07.prod.outlook.com (2603:10b6:510:e::21) To PAXSPRMB0053.eurprd04.prod.outlook.com (2603:10a6:102:23f::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXSPRMB0053:EE_|PA1PR04MB10098:EE_ X-MS-Office365-Filtering-Correlation-Id: b1a0f516-6fba-4105-d0fe-08ddf790edb3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|52116014|7416014|376014|19092799006|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?sgqCRPRTyQo53fmXsMeAqB9s5X9UTnnrBC848xGFqPhTg4MqlQn2EwYWY6GG?= =?us-ascii?Q?Y5vb55vQ15we0jH+xmK03x9Ivzejyi0Qk3MDkRQBmudBZhWmlQJXjvXBkeDW?= =?us-ascii?Q?wGBR5hv0nceb0xyE/8hIaR1YqLSqzegNdn6w/Skrd1ha9TRuR76sWispyZSV?= =?us-ascii?Q?55VjLfvJRLxj3t+Ok1eO1WEUzdOQe8wX9LpKJZzF3mA4EtBWsrVb7PrM8scO?= =?us-ascii?Q?5kZLcRRWy09zApsWOa00dzOuIBmazjuUfmrryc2dSoMEGyxMxaIUVpzqFjm7?= =?us-ascii?Q?haR9B54+Lyla0qRhiRM2yiqeGqtGc2tNNTPIbC4zCXpchGDqUi4oKlA26TmV?= =?us-ascii?Q?BZrFYu8bYAFflyqphqrX1JcuM9fcgEB68rZLCjDpP3NVekfjdqRMBYRTFT9c?= =?us-ascii?Q?t9BfqXQMpel9ZocPkvwA66YVs0c/ZU1o7CG3erfI7UNcl++wemY4+RwQsoIm?= =?us-ascii?Q?kBcRP/OdtdeOA1thH/yovP31YIup+Dhg4aNPxkTCYKb76uOUxuyvF1XcO87u?= =?us-ascii?Q?ZpbQl4snUWtCFJ3lCtxfEXIIJe14/SaDrd7JTgtQUsYFkoeWhT1YhvZyJLo5?= =?us-ascii?Q?EdMthBPhxk2HvsVnBJ4U6jFMZeJCGoXBkv5V/8uVKcZpJwzhI+CgQN/O7nTi?= =?us-ascii?Q?pAJvj9CkIV6kzuqzdU5sHELTGwyJKF4oUvQ2AGk/AsWTT+wqyyDQW1eP0O2n?= =?us-ascii?Q?c+tBL8WYVguGFDH19kW6JLnXs/xi/YKG5nctAfJ8HpsGI+AMdGUIC1NvwlEx?= =?us-ascii?Q?6EUAM9bYCWEUgyuQsBhoLbE4AO3PvHMNSeWI1vwTNiwaAAcjPp3xq/WoRJwJ?= =?us-ascii?Q?yGCEkoY9EgSHQY3oA6vU0B9nnc0QiIZ+Cz/pY1qAojp1M9TUUEyrMUEQkc+s?= =?us-ascii?Q?0c9Hm1tLpQSqk+3dLvgzvWdt8c52l4Ow1hnSjxaZ+j+6zzhlIxf06fvrcMGA?= =?us-ascii?Q?Rg5x9zSyIjJOZZeZ9k1L1ILcP7e6ir0s1/3CU7lGRxGpv6g4AbAJM0iC3IGm?= =?us-ascii?Q?3CjgTjlUfBYp3UOeTxJ/MBMgN0vzk5JkbbvZKRdhPieEZkjKv7N98icwNMkF?= =?us-ascii?Q?6G4793Z0muUBAcKhvZQcgSMZcPro8GZgIsFvuvygz9JpspyTIAvxxi+0tE3B?= =?us-ascii?Q?wyYHXg0EzUP8kCVQm3oeW6/H3x78gzlPO9yLa7hfyIID14Q3ccnboZA/8dfv?= =?us-ascii?Q?YWM7dwdZAC0yrZnxKtaJd8e95KeC7KBimeAvcjHtEJ1v3F234nkqXSo0gXC2?= =?us-ascii?Q?dPEQIUC8wz9IPMbUcII5T3HzQ0ZY50ucdrGv1BN4aS80kv/Wu1zizyjGcMCF?= =?us-ascii?Q?nAXd9at2BDLggm7bvsukjPxNdkPRcgAVNtSTT3QNu0BH4l9Vn5kfEF3VwtHG?= =?us-ascii?Q?7FaJApqZv21rVE7huhIzbkXZNH3h+O4LIG3Wcxb4tS0pk2Q0wOsPNCTLm+uX?= =?us-ascii?Q?TET5rYtDxA5zE2L78ZMewPEW+0+Nux1ZWV4m5zfjo7suAUJQ5D/MDQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXSPRMB0053.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(52116014)(7416014)(376014)(19092799006)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oxgEuway4Ii3RGkMNcmyLklqOpPKJ1VKzC59g376Oo/katN7FvfNIWSoQ4n2?= =?us-ascii?Q?sx0Z7A1P4REuFIvraaHwP3S6ADoSZPpBPpy9k3krT3TMe7/vKJhJCzDJ0REx?= =?us-ascii?Q?C1N/qBOwNg7mfSfoJdcPrgFruwHYKIY0LJDYNdqM5VvmcauYklYExs6LVw8h?= =?us-ascii?Q?r38GiovVBlC2SX6/RLj7/HrODyOS2i2N446ba9OKzmplxYgt2r5YTTMghUtt?= =?us-ascii?Q?J4C52M9l7pWmsfRoTt1MzPhkBAN7geGVlhRaI27foG5RV1Y0y+1QmjW9sEAP?= =?us-ascii?Q?bBLdXFYslETmfwXlgzVYFdg08YTV9nL8RrgCexyuBcnckUfwmCj1EykMU2Q3?= =?us-ascii?Q?ggiZ0Gezsrb0kenE+DU5VGSQFsKOfmUGGKoTdGKGk0iGRE24Mk8wXWpIlvqI?= =?us-ascii?Q?/cIZE3veUmTN2VfD3HxLoPBj0GBXDdVSifdYpuQXOoakvp364+vtv6OLT6fe?= =?us-ascii?Q?5ZPCMnMSUiefX0zTLvgtFSydrJJ6v1N5AeQk5j+LGnENPtE+RgGn43vD502V?= =?us-ascii?Q?qllpIkkeZ1rgt1zfdB1aM8tVxOmU+NwGAi9ZtMAmQeAwg0ymlEHtAhmKdbQX?= =?us-ascii?Q?Lkt7+5fk5EbPSF37s7h2D+9il2gudyZ2h92/8YBIQaMVVkASI2Ma3C6JrC6S?= =?us-ascii?Q?e+W4+xrZYIYq+1TvjwMEEs//ullgWJ4M9ZhlQbTdA/WFYuD/kOxE4nVZr8ts?= =?us-ascii?Q?/sUIfegvB/7wPofPNOht9YFP4XPRLjDRPf0XKRJqmebDUy6wLsSVhBEeBFNh?= =?us-ascii?Q?t3CKJ3rF4Wh8xGWROxpyR/Ry3orBjeGuW/N/VpYjHR+fu7LtL+jNZOFPNB1H?= =?us-ascii?Q?MhPSTafSLHijw5py6QeFIqaNRkcE5MchxDXq5gmhMQhrbtun10Gre8FKvAfB?= =?us-ascii?Q?Q2lGsmZGBNsl5XX9NsJ8jp0sMNcOQ8wc6XVWWfWu8i1IjxXSB5j1k9rf+ksi?= =?us-ascii?Q?c/rVa2/JuwtPAbjBJhAGkvT2gyLQNKutNWkiaDbMS2ucYIwPrkBUHlrCqJmH?= =?us-ascii?Q?WZYtStoWCXW/YW9OSz8vrl1X7zBe2soGkbEklK3ZgCPO1h0GFfhraczmslhS?= =?us-ascii?Q?hbufsn/TU+5KqRIuPgeLHLA1ECqEoOtLYCatzAYGSotsymK0QWzW5ZKar0D+?= =?us-ascii?Q?PEk2qX24kCtA5qCJ0eeu1itA/zKvJpOjJo5FMzf5mYw5GtiHLHw5a8wNrhON?= =?us-ascii?Q?77AeSWxlU2VAJYQ+XUApijkihvYj6NcGdZoxwFeiUL55FUB0WwfOxnJd3KdO?= =?us-ascii?Q?8hjYCxXNUspiotZjhRVy/J5Xtq9nBnPztdQU+ZiyiOtvG9ya8QkR98SYVd8h?= =?us-ascii?Q?fQ94O91+5IY7Hwde/Df/7xp+DnIIRI+NUUU/2Lsyc9N5AnmhQ/S0G6+HIV/P?= =?us-ascii?Q?4YOK77e9EsuDD/Qc/28eALH+x+nqACru56WQvT6lUc/CiBcPIggmaxHvloKH?= =?us-ascii?Q?i41Q2OeVv6KTZ5Cy+h1UDn8bR8HFcp1lexOfSOUfQjj9Og+z/YA0s4pHmeDy?= =?us-ascii?Q?hm4oTtpiu8Vl16XOC7S1w3Tu1IUwZI4L6+CEdg1jPkY5sQ2qhEdEYZtsgfaB?= =?us-ascii?Q?ddZilXpBAN7+WiSBrJYLiXh+XdXSI+bZey6vTVL3?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1a0f516-6fba-4105-d0fe-08ddf790edb3 X-MS-Exchange-CrossTenant-AuthSource: PAXSPRMB0053.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2025 15:26:39.2945 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rvJMQUd0z4cRLVzYKhB087A+i7mTkDjG8m2FXu21bOEDwGtF8khahm6TpfODrcdwMKtp/oG06Yhp4TYjjEGLmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10098 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250919_082649_466862_D85EAE55 X-CRM114-Status: GOOD ( 19.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 04, 2025 at 05:03:57PM +0800, Liu Ying wrote: > Add a helper to get LayerBlend secondary input selection. This is > needed by disabling CRTC at boot in an upcoming commit which tries > to get the selection. > > Signed-off-by: Liu Ying Reviewed-by: Frank Li > --- > drivers/gpu/drm/imx/dc/dc-lb.c | 21 +++++++++++++++++++++ > drivers/gpu/drm/imx/dc/dc-pe.h | 1 + > 2 files changed, 22 insertions(+) > > diff --git a/drivers/gpu/drm/imx/dc/dc-lb.c b/drivers/gpu/drm/imx/dc/dc-lb.c > index 38f966625d382487e45c2e0c202e15c1417f6e65..b0f3fb818799b58597e8ae41d868338c3fd40800 100644 > --- a/drivers/gpu/drm/imx/dc/dc-lb.c > +++ b/drivers/gpu/drm/imx/dc/dc-lb.c > @@ -23,6 +23,8 @@ > #define PIXENGCFG_DYNAMIC_SEC_SEL_MASK GENMASK(13, 8) > #define PIXENGCFG_DYNAMIC_SEC_SEL(x) \ > FIELD_PREP(PIXENGCFG_DYNAMIC_SEC_SEL_MASK, (x)) > +#define PIXENGCFG_DYNAMIC_SEC_SEL_GET(x) \ > + FIELD_GET(PIXENGCFG_DYNAMIC_SEC_SEL_MASK, (x)) > > #define STATICCONTROL 0x8 > #define SHDTOKSEL_MASK GENMASK(4, 3) > @@ -182,6 +184,25 @@ void dc_lb_pec_dynamic_sec_sel(struct dc_lb *lb, enum dc_link_id sec) > dev_warn(lb->dev, "invalid secondary input selection:%d\n", sec); > } > > +int dc_lb_pec_dynamic_sec_sel_get(struct dc_lb *lb, enum dc_link_id *sec) > +{ > + u32 val; > + > + regmap_read(lb->reg_pec, PIXENGCFG_DYNAMIC, &val); > + val = PIXENGCFG_DYNAMIC_SEC_SEL_GET(val); > + > + switch (val) { > + case LINK_ID_NONE: > + case LINK_ID_FETCHWARP2: > + case LINK_ID_FETCHLAYER0: > + *sec = val; > + dev_dbg(lb->dev, "get secondary input selection: 0x%02x\n", val); > + return 0; > + default: > + return -EINVAL; > + } > +} > + > void dc_lb_pec_clken(struct dc_lb *lb, enum dc_pec_clken clken) > { > regmap_write_bits(lb->reg_pec, PIXENGCFG_DYNAMIC, CLKEN_MASK, > diff --git a/drivers/gpu/drm/imx/dc/dc-pe.h b/drivers/gpu/drm/imx/dc/dc-pe.h > index 0b81dc6b251c452e7ca72f1cd12af065bafaa198..4e38aead69bce6e9ad4cf2a7cd1fedbaeda60650 100644 > --- a/drivers/gpu/drm/imx/dc/dc-pe.h > +++ b/drivers/gpu/drm/imx/dc/dc-pe.h > @@ -93,6 +93,7 @@ void dc_ed_init(struct dc_ed *ed); > enum dc_link_id dc_lb_get_link_id(struct dc_lb *lb); > void dc_lb_pec_dynamic_prim_sel(struct dc_lb *lb, enum dc_link_id prim); > void dc_lb_pec_dynamic_sec_sel(struct dc_lb *lb, enum dc_link_id sec); > +int dc_lb_pec_dynamic_sec_sel_get(struct dc_lb *lb, enum dc_link_id *sec); > void dc_lb_pec_clken(struct dc_lb *lb, enum dc_pec_clken clken); > void dc_lb_mode(struct dc_lb *lb, enum dc_lb_mode mode); > void dc_lb_position(struct dc_lb *lb, int x, int y); > > -- > 2.34.1 >