Re: [PATCH 12/14] drm/imx: dc-lb: Drop initial primary and secondary input selections

Frank Li
2025-09-19T15:31:05Z

On Fri, Jul 04, 2025 at 05:03:59PM +0800, Liu Ying wrote:
> It's unnecessary to set initial primary and secondary input selections
> because KMS driver would do that when doing atomic commits. Drop the
> selections. This is needed as a preparation for reading LayerBlend
> secondary input selection when trying to disable CRTC at boot in an
> upcoming commit.
>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/gpu/drm/imx/dc/dc-lb.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/imx/dc/dc-lb.c b/drivers/gpu/drm/imx/dc/dc-lb.c
> index b0f3fb818799b58597e8ae41d868338c3fd40800..d0a805469ae79d467c7e71ebf75e1befb80e15f3 100644
> --- a/drivers/gpu/drm/imx/dc/dc-lb.c
> +++ b/drivers/gpu/drm/imx/dc/dc-lb.c
> @@ -254,8 +254,6 @@ int dc_lb_get_id(struct dc_lb *lb)
>
> void dc_lb_init(struct dc_lb *lb)
> {
> - dc_lb_pec_dynamic_prim_sel(lb, LINK_ID_NONE);
> - dc_lb_pec_dynamic_sec_sel(lb, LINK_ID_NONE);
> dc_lb_pec_clken(lb, CLKEN_DISABLE);
> dc_lb_shdldsel(lb, BOTH);
> dc_lb_shdtoksel(lb, BOTH);
>
> --
> 2.34.1
>