Re: [PATCH 11/14] drm/imx: dc-ed: Drop initial source selection

Frank Li
2025-09-19T15:27:38Z

On Fri, Jul 04, 2025 at 05:03:58PM +0800, Liu Ying wrote:
> It's unnecessary to set initial ExtDst source selection because KMS
> driver would do that when doing atomic commits. Drop the selection.
> This is needed as a preparation for reading ExtDst source selection
> when trying to disable CRTC at boot in an upcoming commit.
>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> drivers/gpu/drm/imx/dc/dc-ed.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/imx/dc/dc-ed.c b/drivers/gpu/drm/imx/dc/dc-ed.c
> index b514790bb765329295553f89d16ee1167ef411dd..1b141ced57b895c24b6358332cbe5e308dad7c01 100644
> --- a/drivers/gpu/drm/imx/dc/dc-ed.c
> +++ b/drivers/gpu/drm/imx/dc/dc-ed.c
> @@ -203,7 +203,6 @@ static inline void dc_ed_disable_gamma_apply(struct dc_ed *ed)
>
> void dc_ed_init(struct dc_ed *ed)
> {
> - dc_ed_pec_src_sel(ed, LINK_ID_NONE);
> dc_ed_pec_enable_shden(ed);
> dc_ed_pec_poweron(ed);
> dc_ed_pec_sync_mode_single(ed);
>
> --
> 2.34.1
>