From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Keguang Zhang <keguang.zhang@gmail.com>,
Alban Bedel <albeu@free.fr>, Doug Berger <opendmb@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Samuel Holland <samuel.holland@sifive.com>,
Yixun Lan <dlan@gentoo.org>, Andy Shevchenko <andy@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 13/15] gpio: sodaville: use new generic GPIO chip API
Date: Tue, 9 Sep 2025 14:31:02 +0300 [thread overview]
Message-ID: <aMAP9hAWars0T83r@smile.fi.intel.com> (raw)
In-Reply-To: <20250909-gpio-mmio-gpio-conv-part4-v1-13-9f723dc3524a@linaro.org>
On Tue, Sep 09, 2025 at 11:15:40AM +0200, Bartosz Golaszewski wrote:
>
> Convert the driver to using the new generic GPIO chip interfaces from
> linux/gpio/generic.h.
...
> + config = (typeof(config)){
This looks unusual. Why can't properly formed compound literal be used as in
many other places in the kernel?
> + .dev = &pdev->dev,
> + .sz = 4,
> + .dat = sd->gpio_pub_base + GPINR,
> + .set = sd->gpio_pub_base + GPOUTR,
> + .dirout = sd->gpio_pub_base + GPOER,
> + };
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-09-09 17:16 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 9:15 [PATCH 00/15] gpio: replace legacy bgpio_init() with its modernized alternative - part 4 Bartosz Golaszewski
2025-09-09 9:15 ` [PATCH 01/15] gpio: loongson1: allow building the module with COMPILE_TEST enabled Bartosz Golaszewski
2025-09-09 9:15 ` [PATCH 02/15] gpio: loongson1: use new generic GPIO chip API Bartosz Golaszewski
2025-09-09 9:15 ` [PATCH 03/15] gpio: hlwd: " Bartosz Golaszewski
2025-09-09 9:15 ` [PATCH 04/15] gpio: ath79: " Bartosz Golaszewski
2025-09-09 9:15 ` [PATCH 05/15] gpio: ath79: use the generic GPIO chip lock for IRQ handling Bartosz Golaszewski
2025-09-09 9:15 ` [PATCH 06/15] gpio: xgene-sb: use generic GPIO chip register read and write APIs Bartosz Golaszewski
2025-09-09 9:15 ` [PATCH 07/15] gpio: brcmstb: use new generic GPIO chip API Bartosz Golaszewski
2025-09-09 9:15 ` [PATCH 08/15] gpio: mt7621: " Bartosz Golaszewski
2025-09-12 9:49 ` Sergio Paracuellos
2025-09-09 9:15 ` [PATCH 09/15] gpio: mt7621: use the generic GPIO chip lock for IRQ handling Bartosz Golaszewski
2025-09-09 9:15 ` [PATCH 10/15] gpio: menz127: use new generic GPIO chip API Bartosz Golaszewski
2025-09-09 9:15 ` [PATCH 11/15] gpio: sifive: " Bartosz Golaszewski
2025-09-09 9:15 ` [PATCH 12/15] gpio: spacemit-k1: " Bartosz Golaszewski
2025-09-09 9:39 ` Yixun Lan
2025-09-09 9:15 ` [PATCH 13/15] gpio: sodaville: " Bartosz Golaszewski
2025-09-09 11:31 ` Andy Shevchenko [this message]
2025-09-09 11:35 ` Bartosz Golaszewski
2025-09-09 13:13 ` Andy Shevchenko
2025-09-09 13:24 ` Bartosz Golaszewski
2025-09-09 13:45 ` Andy Shevchenko
2025-09-09 13:47 ` Andy Shevchenko
2025-09-09 13:56 ` Andy Shevchenko
2025-09-09 13:56 ` Bartosz Golaszewski
2025-09-09 14:02 ` Andy Shevchenko
2025-09-09 14:05 ` Bartosz Golaszewski
2025-09-09 15:15 ` Andy Shevchenko
2025-09-09 15:25 ` Andy Shevchenko
2025-09-09 16:20 ` Bartosz Golaszewski
2025-09-09 9:15 ` [PATCH 14/15] gpio: mmio: " Bartosz Golaszewski
2025-09-09 9:15 ` [PATCH 15/15] gpio: move gpio-mmio-specific fields out of struct gpio_chip Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMAP9hAWars0T83r@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=albeu@free.fr \
--cc=andy@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=dlan@gentoo.org \
--cc=florian.fainelli@broadcom.com \
--cc=keguang.zhang@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=opendmb@gmail.com \
--cc=paul.walmsley@sifive.com \
--cc=samuel.holland@sifive.com \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox