From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C301CAC582 for ; Tue, 9 Sep 2025 17:20:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=a57dqRojQ5ZwDkbLdxwi9CCCBvYs9uVbR8wSnb6tTHE=; b=hZlAGgMxwUA0iJalgBs9FWXifA mzmxMzB7W9Zx1rY4er1IuqZL6jU4PznpV0NNROOeBmv+2HU5reSr5WEyg/bz2O9r5K+IrlakC0txw HA1yB3OLxDExCAiiYlNrtbCBJ48ZZNsG9Sb73DXR0R/gWxF+oUuJ37YLamIPTgMMtx0aCBqxurK9R j/74PDZySvvSrWUprpGd2qF1P+qtUrrK7SrfGWWuf47ucUk19nmKyv+mmio5lLZsaiWzWHgdNddr3 Ite+H1mZ4lJ+fj9SKQipLX8S+Dof8GIjH/Mthb47MruOA+3E+3QX29+FnoRwm8s2TV35NB0FDhp6V VN5eB0Nw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uw21B-00000008wLB-0TuZ; Tue, 09 Sep 2025 17:20:33 +0000 Received: from mgamail.intel.com ([198.175.65.21]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uvyvw-00000007ai9-3Jmn; Tue, 09 Sep 2025 14:02:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1757426577; x=1788962577; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=PyP1a8xmh42gYWEndpBNTjWqCkcaPl/QUUp6gJ3BY2g=; b=TA5GwGk0KkWwqpxCnmqfwNwI1uRICTO7Xlvy6EJrD4qS8j06PcEpLfk2 KjfIBtW9lt3Dpz+NqHicyv/BATMFIsar/nNz6CZp9G+2Oo/UD7lE3lVJV uj2D94JQ7jmq9sXy6NtZ3qydDOgjO1vZquAS/al5h+1yXygtWbRoWifGT tkrVB4FyZcXzjOIzXJWXpDqJd/vYpvEaMvOhvUfLNc7pcE2lA5vp0q4P0 SAQUS9iyD+YhJJCqEYQJDPhFB294N9Su3goLdMWlBfpXudPLe/vS7ruQh foZK16GpgpwNTunGa40N27kqPQHVNWQkVw7jE/rPOjKdxEQ9C4ljhxsoH w==; X-CSE-ConnectionGUID: tv0np2gQRRO+X5KSlIEotQ== X-CSE-MsgGUID: wimbDSy0RH2KnyxBJ9s0Qg== X-IronPort-AV: E=McAfee;i="6800,10657,11531"; a="59637911" X-IronPort-AV: E=Sophos;i="6.17,312,1747724400"; d="scan'208";a="59637911" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2025 07:02:56 -0700 X-CSE-ConnectionGUID: EuRcTEMrQAmZQt5EaJp+DA== X-CSE-MsgGUID: WWEJI342Q1WIfol7oak04A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,251,1751266800"; d="scan'208";a="172685288" Received: from smile.fi.intel.com ([10.237.72.51]) by fmviesa007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2025 07:02:51 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1uvyvF-00000001V3U-0RwC; Tue, 09 Sep 2025 17:02:13 +0300 Date: Tue, 9 Sep 2025 17:02:12 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Keguang Zhang , Alban Bedel , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Matthias Brugger , AngeloGioacchino Del Regno , Paul Walmsley , Samuel Holland , Yixun Lan , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, Bartosz Golaszewski Subject: Re: [PATCH 13/15] gpio: sodaville: use new generic GPIO chip API Message-ID: References: <20250909-gpio-mmio-gpio-conv-part4-v1-0-9f723dc3524a@linaro.org> <20250909-gpio-mmio-gpio-conv-part4-v1-13-9f723dc3524a@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250909_070256_903009_465163A2 X-CRM114-Status: GOOD ( 11.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 09, 2025 at 03:56:41PM +0200, Bartosz Golaszewski wrote: > On Tue, Sep 9, 2025 at 3:47 PM Andy Shevchenko > wrote: > > > > TBH, I think those 6 all made the same mistake, i.e. thinking of the compound > > literal as a cast. Which is not! > > What do you suggest? Write it in less odd way :-) foo = (struct bar) { ... }; > And are we not allowed to use C99 features now anyway? It's fine, it's not about the C standard number. -- With Best Regards, Andy Shevchenko