Re: [PATCH v6 06/24] tracing: Add events to trace remotes

Steven Rostedt
2025-09-09T22:23:54Z

On Tue, 9 Sep 2025 17:47:50 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> > iter->evt_cpu = cpu;
> > + iter->evt = (struct remote_event_hdr *)&rb_evt->array[1];
>
> Hmm, shouldn't this use ring_buffer_event_data(rb_evt) instead?
>
> If the events get big, then it would be array[2]. But the
> ring_buffer_event_data() hides that detail.

Ahh, looking at the patch 10, it is always array[1].

Still should use a helper function instead of exposing the internals like
this.

-- Steve