* [PATCH v2 01/72] dt-bindings: media: Deprecate clock-frequency property for camera sensors [not found] <20250812214620.30425-1-laurent.pinchart@ideasonboard.com> @ 2025-08-12 21:45 ` Laurent Pinchart 2025-08-13 4:44 ` Rob Herring (Arm) 2025-08-13 9:49 ` [PATCH v2.1 " Laurent Pinchart 2025-08-12 21:46 ` [PATCH v2 63/72] ARM: dts: samsung: exynos4210-i9100: Replace clock-frequency in camera sensor node Laurent Pinchart ` (3 subsequent siblings) 4 siblings, 2 replies; 10+ messages in thread From: Laurent Pinchart @ 2025-08-12 21:45 UTC (permalink / raw) To: linux-media Cc: Loic Poulain, Robert Foss, Andi Shyti, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sakari Ailus, Manivannan Sadhasivam, Sylwester Nawrocki, Alim Akhtar, Dongchun Zhu, Lad Prabhakar, Todor Tomov, linux-arm-msm, linux-i2c, devicetree, linux-arm-kernel, linux-samsung-soc Usage of the clock-frequency property for camera sensors is discouraged in favour of using assigned-clock-rates (and assigned-clock-parents where needed). Mark the property as deprecated. Update the examples accordingly. In DT examples where the sensor input clock appears to come from a programmable clock generator, replace clock-frequency by the assigned-clocks and assigned-clock-rates properties. Otherwise, just drop clock-frequency. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Rob Herring (Arm) <robh@kernel.org> --- Changes since v1: - Adapt examples in bindings that reference sensors --- Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 6 ++++-- Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 7 +++++-- .../devicetree/bindings/media/i2c/ovti,ov02a10.yaml | 3 +-- .../devicetree/bindings/media/i2c/ovti,ov5645.yaml | 6 +++++- .../devicetree/bindings/media/i2c/ovti,ov7251.yaml | 6 +++++- .../devicetree/bindings/media/i2c/ovti,ov8856.yaml | 3 +-- .../devicetree/bindings/media/i2c/samsung,s5k5baf.yaml | 6 +++++- .../devicetree/bindings/media/i2c/samsung,s5k6a3.yaml | 6 +++++- .../devicetree/bindings/media/i2c/sony,imx290.yaml | 5 +++-- .../bindings/media/samsung,exynos4212-fimc-is.yaml | 4 ++-- Documentation/devicetree/bindings/media/samsung,fimc.yaml | 3 ++- 11 files changed, 38 insertions(+), 17 deletions(-) diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml index 73144473b9b2..1687b069e032 100644 --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml @@ -292,7 +292,8 @@ examples: clocks = <&clock_camcc CAM_CC_MCLK0_CLK>; clock-names = "xvclk"; - clock-frequency = <19200000>; + assigned-clocks = <&clock_camcc CAM_CC_MCLK0_CLK>; + assigned-clock-rates = <19200000>; dovdd-supply = <&vreg_lvs1a_1p8>; avdd-supply = <&cam0_avdd_2v8>; @@ -324,7 +325,8 @@ examples: clocks = <&clock_camcc CAM_CC_MCLK3_CLK>; clock-names = "xclk"; - clock-frequency = <24000000>; + assigned-clocks = <&clock_camcc CAM_CC_MCLK3_CLK>; + assigned-clock-rates = <24000000>; vdddo-supply = <&vreg_lvs1a_1p8>; vdda-supply = <&cam3_avdd_2v8>; diff --git a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml index bc664a016396..217b08c8cbbd 100644 --- a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml +++ b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml @@ -55,6 +55,7 @@ properties: clock-frequency: description: Frequency of the external clock to the sensor in Hz. + deprecated: true reset-gpios: description: Reset GPIO. Also commonly called XSHUTDOWN in hardware @@ -93,7 +94,6 @@ properties: required: - compatible - reg - - clock-frequency - clocks additionalProperties: false @@ -114,8 +114,11 @@ examples: reg = <0x10>; reset-gpios = <&gpio3 20 GPIO_ACTIVE_LOW>; vana-supply = <&vaux3>; + clocks = <&omap3_isp 0>; - clock-frequency = <9600000>; + assigned-clocks = <&omap3_isp 0>; + assigned-clock-rates = <9600000>; + port { ccs_ep: endpoint { data-lanes = <1 2>; diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml index 67c1c291327b..0e1d9c390180 100644 --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml @@ -39,6 +39,7 @@ properties: clock-frequency: description: Frequency of the eclk clock in Hz. + deprecated: true dovdd-supply: description: @@ -100,7 +101,6 @@ required: - reg - clocks - clock-names - - clock-frequency - dovdd-supply - avdd-supply - dvdd-supply @@ -127,7 +127,6 @@ examples: clocks = <&ov02a10_clk>; clock-names = "eclk"; - clock-frequency = <24000000>; rotation = <180>; diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5645.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5645.yaml index bc9b27afe3ea..a583714b1ac7 100644 --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5645.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5645.yaml @@ -21,6 +21,7 @@ properties: clock-frequency: description: Frequency of the xclk clock in Hz. + deprecated: true vdda-supply: description: Analog voltage supply, 2.8 volts @@ -83,8 +84,11 @@ examples: camera@3c { compatible = "ovti,ov5645"; reg = <0x3c>; + clocks = <&clks 1>; - clock-frequency = <24000000>; + assigned-clocks = <&clks 1>; + assigned-clock-rates = <24000000>; + vdddo-supply = <&ov5645_vdddo_1v8>; vdda-supply = <&ov5645_vdda_2v8>; vddd-supply = <&ov5645_vddd_1v5>; diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml index 2e5187acbbb8..922996da59b2 100644 --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml @@ -29,6 +29,7 @@ properties: clock-frequency: description: Frequency of the xclk clock in Hz. + deprecated: true vdda-supply: description: Analog voltage supply, 2.8 volts @@ -89,8 +90,11 @@ examples: camera@3c { compatible = "ovti,ov7251"; reg = <0x3c>; + clocks = <&clks 1>; - clock-frequency = <24000000>; + assigned-clocks = <&clks 1>; + assigned-clock-rates = <24000000>; + vdddo-supply = <&ov7251_vdddo_1v8>; vdda-supply = <&ov7251_vdda_2v8>; vddd-supply = <&ov7251_vddd_1v5>; diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov8856.yaml index 3f6f72c35485..fa71f24823f2 100644 --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov8856.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov8856.yaml @@ -37,6 +37,7 @@ properties: clock-frequency: description: Frequency of the xvclk clock in Hertz. + deprecated: true dovdd-supply: description: @@ -87,7 +88,6 @@ required: - reg - clocks - clock-names - - clock-frequency - dovdd-supply - avdd-supply - dvdd-supply @@ -114,7 +114,6 @@ examples: clocks = <&cam_osc>; clock-names = "xvclk"; - clock-frequency = <19200000>; avdd-supply = <&mt6358_vcama2_reg>; dvdd-supply = <&mt6358_vcamd_reg>; diff --git a/Documentation/devicetree/bindings/media/i2c/samsung,s5k5baf.yaml b/Documentation/devicetree/bindings/media/i2c/samsung,s5k5baf.yaml index c8f2955e0825..ebd95a8d9b2f 100644 --- a/Documentation/devicetree/bindings/media/i2c/samsung,s5k5baf.yaml +++ b/Documentation/devicetree/bindings/media/i2c/samsung,s5k5baf.yaml @@ -26,6 +26,7 @@ properties: clock-frequency: default: 24000000 description: mclk clock frequency + deprecated: true rstn-gpios: maxItems: 1 @@ -82,9 +83,12 @@ examples: sensor@2d { compatible = "samsung,s5k5baf"; reg = <0x2d>; + clocks = <&camera 0>; + assigned-clocks = <&camera 0>; + assigned-clock-rates = <24000000>; + clock-names = "mclk"; - clock-frequency = <24000000>; rstn-gpios = <&gpl2 1 GPIO_ACTIVE_LOW>; stbyn-gpios = <&gpl2 0 GPIO_ACTIVE_LOW>; vdda-supply = <&cam_io_en_reg>; diff --git a/Documentation/devicetree/bindings/media/i2c/samsung,s5k6a3.yaml b/Documentation/devicetree/bindings/media/i2c/samsung,s5k6a3.yaml index 7e83a94124b5..e563e35920c4 100644 --- a/Documentation/devicetree/bindings/media/i2c/samsung,s5k6a3.yaml +++ b/Documentation/devicetree/bindings/media/i2c/samsung,s5k6a3.yaml @@ -30,6 +30,7 @@ properties: clock-frequency: default: 24000000 description: extclk clock frequency + deprecated: true gpios: maxItems: 1 @@ -80,8 +81,11 @@ examples: sensor@10 { compatible = "samsung,s5k6a3"; reg = <0x10>; - clock-frequency = <24000000>; + clocks = <&camera 1>; + assigned-clocks = <&camera 1>; + assigned-clock-rates = <24000000>; + clock-names = "extclk"; gpios = <&gpm1 6 GPIO_ACTIVE_LOW>; afvdd-supply = <&ldo19_reg>; diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml index 990acf89af8f..484039671cd1 100644 --- a/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml @@ -51,6 +51,7 @@ properties: clock-frequency: description: Frequency of the xclk clock in Hz + deprecated: true vdda-supply: description: Analog power supply (2.9V) @@ -100,7 +101,6 @@ required: - reg - clocks - clock-names - - clock-frequency - vdda-supply - vddd-supply - vdddo-supply @@ -125,7 +125,8 @@ examples: clocks = <&gcc 90>; clock-names = "xclk"; - clock-frequency = <37125000>; + assigned-clocks = <&clks 1>; + assigned-clock-rates = <37125000>; vdddo-supply = <&camera_vdddo_1v8>; vdda-supply = <&camera_vdda_2v8>; diff --git a/Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.yaml b/Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.yaml index 3a5ff3f47060..151290de6e87 100644 --- a/Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.yaml +++ b/Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.yaml @@ -209,9 +209,9 @@ examples: svdda-supply = <&cam_io_reg>; svddio-supply = <&ldo19_reg>; afvdd-supply = <&ldo19_reg>; - clock-frequency = <24000000>; - clocks = <&camera 1>; clock-names = "extclk"; + assigned-clocks = <&camera 1>; + assigned-clock-rates = <24000000>; gpios = <&gpm1 6 GPIO_ACTIVE_LOW>; port { diff --git a/Documentation/devicetree/bindings/media/samsung,fimc.yaml b/Documentation/devicetree/bindings/media/samsung,fimc.yaml index 7808d61f1fa3..2a54379d9509 100644 --- a/Documentation/devicetree/bindings/media/samsung,fimc.yaml +++ b/Documentation/devicetree/bindings/media/samsung,fimc.yaml @@ -259,10 +259,11 @@ examples: svdda-supply = <&cam_io_reg>; svddio-supply = <&ldo19_reg>; afvdd-supply = <&ldo19_reg>; - clock-frequency = <24000000>; /* CAM_B_CLKOUT */ clocks = <&camera 1>; clock-names = "extclk"; + assigned-clocks = <&camera 1>; + assigned-clock-rates = <24000000>; gpios = <&gpm1 6 GPIO_ACTIVE_LOW>; port { -- Regards, Laurent Pinchart ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2 01/72] dt-bindings: media: Deprecate clock-frequency property for camera sensors 2025-08-12 21:45 ` [PATCH v2 01/72] dt-bindings: media: Deprecate clock-frequency property for camera sensors Laurent Pinchart @ 2025-08-13 4:44 ` Rob Herring (Arm) 2025-08-13 8:41 ` Laurent Pinchart 2025-08-13 9:49 ` [PATCH v2.1 " Laurent Pinchart 1 sibling, 1 reply; 10+ messages in thread From: Rob Herring (Arm) @ 2025-08-13 4:44 UTC (permalink / raw) To: Laurent Pinchart Cc: Andi Shyti, Robert Foss, Lad Prabhakar, linux-arm-msm, linux-i2c, Manivannan Sadhasivam, Conor Dooley, Sylwester Nawrocki, Krzysztof Kozlowski, Sakari Ailus, Todor Tomov, Loic Poulain, Alim Akhtar, linux-samsung-soc, linux-media, linux-arm-kernel, devicetree, Dongchun Zhu On Wed, 13 Aug 2025 00:45:09 +0300, Laurent Pinchart wrote: > Usage of the clock-frequency property for camera sensors is discouraged > in favour of using assigned-clock-rates (and assigned-clock-parents > where needed). Mark the property as deprecated. > > Update the examples accordingly. In DT examples where the sensor input > clock appears to come from a programmable clock generator, replace > clock-frequency by the assigned-clocks and assigned-clock-rates > properties. Otherwise, just drop clock-frequency. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > --- > Changes since v1: > > - Adapt examples in bindings that reference sensors > --- > Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 6 ++++-- > Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 7 +++++-- > .../devicetree/bindings/media/i2c/ovti,ov02a10.yaml | 3 +-- > .../devicetree/bindings/media/i2c/ovti,ov5645.yaml | 6 +++++- > .../devicetree/bindings/media/i2c/ovti,ov7251.yaml | 6 +++++- > .../devicetree/bindings/media/i2c/ovti,ov8856.yaml | 3 +-- > .../devicetree/bindings/media/i2c/samsung,s5k5baf.yaml | 6 +++++- > .../devicetree/bindings/media/i2c/samsung,s5k6a3.yaml | 6 +++++- > .../devicetree/bindings/media/i2c/sony,imx290.yaml | 5 +++-- > .../bindings/media/samsung,exynos4212-fimc-is.yaml | 4 ++-- > Documentation/devicetree/bindings/media/samsung,fimc.yaml | 3 ++- > 11 files changed, 38 insertions(+), 17 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.example.dtb: image-sensor@10 (samsung,s5k6a3): 'clocks' is a required property from schema $id: http://devicetree.org/schemas/media/i2c/samsung,s5k6a3.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.example.dtb: image-sensor@10 (samsung,s5k6a3): 'clocks' is a dependency of 'clock-names' from schema $id: http://devicetree.org/schemas/clock/clock.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.example.dtb: image-sensor@10 (samsung,s5k6a3): 'anyOf' conditional failed, one must be fixed: 'clocks' is a required property '#clock-cells' is a required property from schema $id: http://devicetree.org/schemas/clock/clock.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250812214620.30425-2-laurent.pinchart@ideasonboard.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 01/72] dt-bindings: media: Deprecate clock-frequency property for camera sensors 2025-08-13 4:44 ` Rob Herring (Arm) @ 2025-08-13 8:41 ` Laurent Pinchart 0 siblings, 0 replies; 10+ messages in thread From: Laurent Pinchart @ 2025-08-13 8:41 UTC (permalink / raw) To: Rob Herring (Arm) Cc: Andi Shyti, Robert Foss, Lad Prabhakar, linux-arm-msm, linux-i2c, Manivannan Sadhasivam, Conor Dooley, Sylwester Nawrocki, Krzysztof Kozlowski, Sakari Ailus, Todor Tomov, Loic Poulain, Alim Akhtar, linux-samsung-soc, linux-media, linux-arm-kernel, devicetree, Dongchun Zhu On Tue, Aug 12, 2025 at 11:44:42PM -0500, Rob Herring (Arm) wrote: > > On Wed, 13 Aug 2025 00:45:09 +0300, Laurent Pinchart wrote: > > Usage of the clock-frequency property for camera sensors is discouraged > > in favour of using assigned-clock-rates (and assigned-clock-parents > > where needed). Mark the property as deprecated. > > > > Update the examples accordingly. In DT examples where the sensor input > > clock appears to come from a programmable clock generator, replace > > clock-frequency by the assigned-clocks and assigned-clock-rates > > properties. Otherwise, just drop clock-frequency. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > > --- > > Changes since v1: > > > > - Adapt examples in bindings that reference sensors > > --- > > Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 6 ++++-- > > Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 7 +++++-- > > .../devicetree/bindings/media/i2c/ovti,ov02a10.yaml | 3 +-- > > .../devicetree/bindings/media/i2c/ovti,ov5645.yaml | 6 +++++- > > .../devicetree/bindings/media/i2c/ovti,ov7251.yaml | 6 +++++- > > .../devicetree/bindings/media/i2c/ovti,ov8856.yaml | 3 +-- > > .../devicetree/bindings/media/i2c/samsung,s5k5baf.yaml | 6 +++++- > > .../devicetree/bindings/media/i2c/samsung,s5k6a3.yaml | 6 +++++- > > .../devicetree/bindings/media/i2c/sony,imx290.yaml | 5 +++-- > > .../bindings/media/samsung,exynos4212-fimc-is.yaml | 4 ++-- > > Documentation/devicetree/bindings/media/samsung,fimc.yaml | 3 ++- > > 11 files changed, 38 insertions(+), 17 deletions(-) > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.example.dtb: image-sensor@10 (samsung,s5k6a3): 'clocks' is a required property > from schema $id: http://devicetree.org/schemas/media/i2c/samsung,s5k6a3.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.example.dtb: image-sensor@10 (samsung,s5k6a3): 'clocks' is a dependency of 'clock-names' > from schema $id: http://devicetree.org/schemas/clock/clock.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.example.dtb: image-sensor@10 (samsung,s5k6a3): 'anyOf' conditional failed, one must be fixed: > 'clocks' is a required property > '#clock-cells' is a required property > from schema $id: http://devicetree.org/schemas/clock/clock.yaml# This is what I get for relying blindly on CI :-/ Sorry about that, I'll fix it (and try to fix CI too). > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250812214620.30425-2-laurent.pinchart@ideasonboard.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2.1 01/72] dt-bindings: media: Deprecate clock-frequency property for camera sensors 2025-08-12 21:45 ` [PATCH v2 01/72] dt-bindings: media: Deprecate clock-frequency property for camera sensors Laurent Pinchart 2025-08-13 4:44 ` Rob Herring (Arm) @ 2025-08-13 9:49 ` Laurent Pinchart 2025-09-12 22:41 ` Wolfram Sang 1 sibling, 1 reply; 10+ messages in thread From: Laurent Pinchart @ 2025-08-13 9:49 UTC (permalink / raw) To: linux-media Cc: Loic Poulain, Robert Foss, Andi Shyti, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sakari Ailus, Manivannan Sadhasivam, Sylwester Nawrocki, Alim Akhtar, Dongchun Zhu, Lad Prabhakar, Todor Tomov, linux-arm-msm, linux-i2c, devicetree, linux-arm-kernel, linux-samsung-soc Usage of the clock-frequency property for camera sensors is discouraged in favour of using assigned-clock-rates (and assigned-clock-parents where needed). Mark the property as deprecated. Update the examples accordingly. In DT examples where the sensor input clock appears to come from a programmable clock generator, replace clock-frequency by the assigned-clocks and assigned-clock-rates properties. Otherwise, just drop clock-frequency. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Rob Herring (Arm) <robh@kernel.org> --- Changes since v2: - Don't remove clocks property in samsung,exynos4212-fimc-is.yaml Changes since v1: - Adapt examples in bindings that reference sensors --- Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 6 ++++-- Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 7 +++++-- .../devicetree/bindings/media/i2c/ovti,ov02a10.yaml | 3 +-- .../devicetree/bindings/media/i2c/ovti,ov5645.yaml | 6 +++++- .../devicetree/bindings/media/i2c/ovti,ov7251.yaml | 6 +++++- .../devicetree/bindings/media/i2c/ovti,ov8856.yaml | 3 +-- .../devicetree/bindings/media/i2c/samsung,s5k5baf.yaml | 6 +++++- .../devicetree/bindings/media/i2c/samsung,s5k6a3.yaml | 6 +++++- .../devicetree/bindings/media/i2c/sony,imx290.yaml | 5 +++-- .../bindings/media/samsung,exynos4212-fimc-is.yaml | 3 ++- Documentation/devicetree/bindings/media/samsung,fimc.yaml | 3 ++- 11 files changed, 38 insertions(+), 16 deletions(-) diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml index 73144473b9b2..1687b069e032 100644 --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml @@ -292,7 +292,8 @@ examples: clocks = <&clock_camcc CAM_CC_MCLK0_CLK>; clock-names = "xvclk"; - clock-frequency = <19200000>; + assigned-clocks = <&clock_camcc CAM_CC_MCLK0_CLK>; + assigned-clock-rates = <19200000>; dovdd-supply = <&vreg_lvs1a_1p8>; avdd-supply = <&cam0_avdd_2v8>; @@ -324,7 +325,8 @@ examples: clocks = <&clock_camcc CAM_CC_MCLK3_CLK>; clock-names = "xclk"; - clock-frequency = <24000000>; + assigned-clocks = <&clock_camcc CAM_CC_MCLK3_CLK>; + assigned-clock-rates = <24000000>; vdddo-supply = <&vreg_lvs1a_1p8>; vdda-supply = <&cam3_avdd_2v8>; diff --git a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml index bc664a016396..217b08c8cbbd 100644 --- a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml +++ b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml @@ -55,6 +55,7 @@ properties: clock-frequency: description: Frequency of the external clock to the sensor in Hz. + deprecated: true reset-gpios: description: Reset GPIO. Also commonly called XSHUTDOWN in hardware @@ -93,7 +94,6 @@ properties: required: - compatible - reg - - clock-frequency - clocks additionalProperties: false @@ -114,8 +114,11 @@ examples: reg = <0x10>; reset-gpios = <&gpio3 20 GPIO_ACTIVE_LOW>; vana-supply = <&vaux3>; + clocks = <&omap3_isp 0>; - clock-frequency = <9600000>; + assigned-clocks = <&omap3_isp 0>; + assigned-clock-rates = <9600000>; + port { ccs_ep: endpoint { data-lanes = <1 2>; diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml index 67c1c291327b..0e1d9c390180 100644 --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml @@ -39,6 +39,7 @@ properties: clock-frequency: description: Frequency of the eclk clock in Hz. + deprecated: true dovdd-supply: description: @@ -100,7 +101,6 @@ required: - reg - clocks - clock-names - - clock-frequency - dovdd-supply - avdd-supply - dvdd-supply @@ -127,7 +127,6 @@ examples: clocks = <&ov02a10_clk>; clock-names = "eclk"; - clock-frequency = <24000000>; rotation = <180>; diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5645.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5645.yaml index bc9b27afe3ea..a583714b1ac7 100644 --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5645.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5645.yaml @@ -21,6 +21,7 @@ properties: clock-frequency: description: Frequency of the xclk clock in Hz. + deprecated: true vdda-supply: description: Analog voltage supply, 2.8 volts @@ -83,8 +84,11 @@ examples: camera@3c { compatible = "ovti,ov5645"; reg = <0x3c>; + clocks = <&clks 1>; - clock-frequency = <24000000>; + assigned-clocks = <&clks 1>; + assigned-clock-rates = <24000000>; + vdddo-supply = <&ov5645_vdddo_1v8>; vdda-supply = <&ov5645_vdda_2v8>; vddd-supply = <&ov5645_vddd_1v5>; diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml index 2e5187acbbb8..922996da59b2 100644 --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml @@ -29,6 +29,7 @@ properties: clock-frequency: description: Frequency of the xclk clock in Hz. + deprecated: true vdda-supply: description: Analog voltage supply, 2.8 volts @@ -89,8 +90,11 @@ examples: camera@3c { compatible = "ovti,ov7251"; reg = <0x3c>; + clocks = <&clks 1>; - clock-frequency = <24000000>; + assigned-clocks = <&clks 1>; + assigned-clock-rates = <24000000>; + vdddo-supply = <&ov7251_vdddo_1v8>; vdda-supply = <&ov7251_vdda_2v8>; vddd-supply = <&ov7251_vddd_1v5>; diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov8856.yaml index 3f6f72c35485..fa71f24823f2 100644 --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov8856.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov8856.yaml @@ -37,6 +37,7 @@ properties: clock-frequency: description: Frequency of the xvclk clock in Hertz. + deprecated: true dovdd-supply: description: @@ -87,7 +88,6 @@ required: - reg - clocks - clock-names - - clock-frequency - dovdd-supply - avdd-supply - dvdd-supply @@ -114,7 +114,6 @@ examples: clocks = <&cam_osc>; clock-names = "xvclk"; - clock-frequency = <19200000>; avdd-supply = <&mt6358_vcama2_reg>; dvdd-supply = <&mt6358_vcamd_reg>; diff --git a/Documentation/devicetree/bindings/media/i2c/samsung,s5k5baf.yaml b/Documentation/devicetree/bindings/media/i2c/samsung,s5k5baf.yaml index c8f2955e0825..ebd95a8d9b2f 100644 --- a/Documentation/devicetree/bindings/media/i2c/samsung,s5k5baf.yaml +++ b/Documentation/devicetree/bindings/media/i2c/samsung,s5k5baf.yaml @@ -26,6 +26,7 @@ properties: clock-frequency: default: 24000000 description: mclk clock frequency + deprecated: true rstn-gpios: maxItems: 1 @@ -82,9 +83,12 @@ examples: sensor@2d { compatible = "samsung,s5k5baf"; reg = <0x2d>; + clocks = <&camera 0>; + assigned-clocks = <&camera 0>; + assigned-clock-rates = <24000000>; + clock-names = "mclk"; - clock-frequency = <24000000>; rstn-gpios = <&gpl2 1 GPIO_ACTIVE_LOW>; stbyn-gpios = <&gpl2 0 GPIO_ACTIVE_LOW>; vdda-supply = <&cam_io_en_reg>; diff --git a/Documentation/devicetree/bindings/media/i2c/samsung,s5k6a3.yaml b/Documentation/devicetree/bindings/media/i2c/samsung,s5k6a3.yaml index 7e83a94124b5..e563e35920c4 100644 --- a/Documentation/devicetree/bindings/media/i2c/samsung,s5k6a3.yaml +++ b/Documentation/devicetree/bindings/media/i2c/samsung,s5k6a3.yaml @@ -30,6 +30,7 @@ properties: clock-frequency: default: 24000000 description: extclk clock frequency + deprecated: true gpios: maxItems: 1 @@ -80,8 +81,11 @@ examples: sensor@10 { compatible = "samsung,s5k6a3"; reg = <0x10>; - clock-frequency = <24000000>; + clocks = <&camera 1>; + assigned-clocks = <&camera 1>; + assigned-clock-rates = <24000000>; + clock-names = "extclk"; gpios = <&gpm1 6 GPIO_ACTIVE_LOW>; afvdd-supply = <&ldo19_reg>; diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml index 990acf89af8f..484039671cd1 100644 --- a/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml @@ -51,6 +51,7 @@ properties: clock-frequency: description: Frequency of the xclk clock in Hz + deprecated: true vdda-supply: description: Analog power supply (2.9V) @@ -100,7 +101,6 @@ required: - reg - clocks - clock-names - - clock-frequency - vdda-supply - vddd-supply - vdddo-supply @@ -125,7 +125,8 @@ examples: clocks = <&gcc 90>; clock-names = "xclk"; - clock-frequency = <37125000>; + assigned-clocks = <&clks 1>; + assigned-clock-rates = <37125000>; vdddo-supply = <&camera_vdddo_1v8>; vdda-supply = <&camera_vdda_2v8>; diff --git a/Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.yaml b/Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.yaml index 3a5ff3f47060..71d63bb9abb5 100644 --- a/Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.yaml +++ b/Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.yaml @@ -209,9 +209,10 @@ examples: svdda-supply = <&cam_io_reg>; svddio-supply = <&ldo19_reg>; afvdd-supply = <&ldo19_reg>; - clock-frequency = <24000000>; clocks = <&camera 1>; clock-names = "extclk"; + assigned-clocks = <&camera 1>; + assigned-clock-rates = <24000000>; gpios = <&gpm1 6 GPIO_ACTIVE_LOW>; port { diff --git a/Documentation/devicetree/bindings/media/samsung,fimc.yaml b/Documentation/devicetree/bindings/media/samsung,fimc.yaml index 7808d61f1fa3..2a54379d9509 100644 --- a/Documentation/devicetree/bindings/media/samsung,fimc.yaml +++ b/Documentation/devicetree/bindings/media/samsung,fimc.yaml @@ -259,10 +259,11 @@ examples: svdda-supply = <&cam_io_reg>; svddio-supply = <&ldo19_reg>; afvdd-supply = <&ldo19_reg>; - clock-frequency = <24000000>; /* CAM_B_CLKOUT */ clocks = <&camera 1>; clock-names = "extclk"; + assigned-clocks = <&camera 1>; + assigned-clock-rates = <24000000>; gpios = <&gpm1 6 GPIO_ACTIVE_LOW>; port { -- Regards, Laurent Pinchart ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2.1 01/72] dt-bindings: media: Deprecate clock-frequency property for camera sensors 2025-08-13 9:49 ` [PATCH v2.1 " Laurent Pinchart @ 2025-09-12 22:41 ` Wolfram Sang 2025-09-13 9:31 ` Laurent Pinchart 0 siblings, 1 reply; 10+ messages in thread From: Wolfram Sang @ 2025-09-12 22:41 UTC (permalink / raw) To: Laurent Pinchart Cc: linux-media, Loic Poulain, Robert Foss, Andi Shyti, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sakari Ailus, Manivannan Sadhasivam, Sylwester Nawrocki, Alim Akhtar, Dongchun Zhu, Lad Prabhakar, Todor Tomov, linux-arm-msm, linux-i2c, devicetree, linux-arm-kernel, linux-samsung-soc Hi Laurent, On Wed, Aug 13, 2025 at 12:49:23PM +0300, Laurent Pinchart wrote: > Usage of the clock-frequency property for camera sensors is discouraged > in favour of using assigned-clock-rates (and assigned-clock-parents > where needed). Mark the property as deprecated. > > Update the examples accordingly. In DT examples where the sensor input > clock appears to come from a programmable clock generator, replace > clock-frequency by the assigned-clocks and assigned-clock-rates > properties. Otherwise, just drop clock-frequency. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > --- > Changes since v2: > > - Don't remove clocks property in samsung,exynos4212-fimc-is.yaml > > Changes since v1: > > - Adapt examples in bindings that reference sensors > --- > Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 6 ++++-- Can I have this i2c change seperately to avoid dependencies? Happy hacking, Wolfram ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2.1 01/72] dt-bindings: media: Deprecate clock-frequency property for camera sensors 2025-09-12 22:41 ` Wolfram Sang @ 2025-09-13 9:31 ` Laurent Pinchart 0 siblings, 0 replies; 10+ messages in thread From: Laurent Pinchart @ 2025-09-13 9:31 UTC (permalink / raw) To: Wolfram Sang Cc: linux-media, Loic Poulain, Robert Foss, Andi Shyti, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sakari Ailus, Manivannan Sadhasivam, Sylwester Nawrocki, Alim Akhtar, Dongchun Zhu, Lad Prabhakar, Todor Tomov, linux-arm-msm, linux-i2c, devicetree, linux-arm-kernel, linux-samsung-soc On Sat, Sep 13, 2025 at 12:41:46AM +0200, Wolfram Sang wrote: > On Wed, Aug 13, 2025 at 12:49:23PM +0300, Laurent Pinchart wrote: > > Usage of the clock-frequency property for camera sensors is discouraged > > in favour of using assigned-clock-rates (and assigned-clock-parents > > where needed). Mark the property as deprecated. > > > > Update the examples accordingly. In DT examples where the sensor input > > clock appears to come from a programmable clock generator, replace > > clock-frequency by the assigned-clocks and assigned-clock-rates > > properties. Otherwise, just drop clock-frequency. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > > --- > > Changes since v2: > > > > - Don't remove clocks property in samsung,exynos4212-fimc-is.yaml > > > > Changes since v1: > > > > - Adapt examples in bindings that reference sensors > > --- > > Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 6 ++++-- > > Can I have this i2c change seperately to avoid dependencies? I'm afraid it has been merged in the media tree already. -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 63/72] ARM: dts: samsung: exynos4210-i9100: Replace clock-frequency in camera sensor node [not found] <20250812214620.30425-1-laurent.pinchart@ideasonboard.com> 2025-08-12 21:45 ` [PATCH v2 01/72] dt-bindings: media: Deprecate clock-frequency property for camera sensors Laurent Pinchart @ 2025-08-12 21:46 ` Laurent Pinchart 2025-08-12 21:46 ` [PATCH v2 64/72] ARM: dts: samsung: exynos4412-midas: " Laurent Pinchart ` (2 subsequent siblings) 4 siblings, 0 replies; 10+ messages in thread From: Laurent Pinchart @ 2025-08-12 21:46 UTC (permalink / raw) To: linux-media Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar, devicetree, linux-arm-kernel, linux-samsung-soc The clock-frequency for camera sensors has been deprecated in favour of the assigned-clocks and assigned-clock-rates properties. Replace it in the device tree. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- This patch can be merged independently from the previous clock handling refactoring in the driver ("media: i2c: s5k5baf: Use V4L2 legacy sensor clock helper"). Without the driver change, when the clock-frequency property is not set, the driver defaults to a fixed 24MHz value. That is the frequency set in DT for this board, so the resulting clock frequency does not change. --- arch/arm/boot/dts/samsung/exynos4210-i9100.dts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/samsung/exynos4210-i9100.dts b/arch/arm/boot/dts/samsung/exynos4210-i9100.dts index df229fb8a16b..43cee5e26a9a 100644 --- a/arch/arm/boot/dts/samsung/exynos4210-i9100.dts +++ b/arch/arm/boot/dts/samsung/exynos4210-i9100.dts @@ -169,11 +169,14 @@ image-sensor@2d { vdda-supply = <&cam_io_en_reg>; vddreg-supply = <&vt_core_15v_reg>; vddio-supply = <&vtcam_reg>; + clocks = <&camera 0>; clock-names = "mclk"; + assigned-clocks = <&camera 0>; + assigned-clock-rates = <24000000>; + stbyn-gpios = <&gpl2 0 GPIO_ACTIVE_LOW>; rstn-gpios = <&gpl2 1 GPIO_ACTIVE_LOW>; - clock-frequency = <24000000>; port { s5k5bafx_ep: endpoint { -- Regards, Laurent Pinchart ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 64/72] ARM: dts: samsung: exynos4412-midas: Replace clock-frequency in camera sensor node [not found] <20250812214620.30425-1-laurent.pinchart@ideasonboard.com> 2025-08-12 21:45 ` [PATCH v2 01/72] dt-bindings: media: Deprecate clock-frequency property for camera sensors Laurent Pinchart 2025-08-12 21:46 ` [PATCH v2 63/72] ARM: dts: samsung: exynos4210-i9100: Replace clock-frequency in camera sensor node Laurent Pinchart @ 2025-08-12 21:46 ` Laurent Pinchart 2025-08-12 21:46 ` [PATCH v2 68/72] ARM: dts: nxp: imx6qdl-pico: " Laurent Pinchart 2025-08-12 21:46 ` [PATCH v2 69/72] ARM: dts: nxp: imx6qdl-wandboard: " Laurent Pinchart 4 siblings, 0 replies; 10+ messages in thread From: Laurent Pinchart @ 2025-08-12 21:46 UTC (permalink / raw) To: linux-media Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar, devicetree, linux-arm-kernel, linux-samsung-soc The clock-frequency for camera sensors has been deprecated in favour of the assigned-clocks and assigned-clock-rates properties. Replace it in the device tree. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- This patch can be merged independently from the previous clock handling refactoring in the driver ("media: i2c: s5k6a3: Use V4L2 legacy sensor clock helper"). Without the driver change, when the clock-frequency property is not set, the driver defaults to a fixed 24MHz value. That is the frequency set in DT for this board, so the resulting clock frequency does not change. --- arch/arm/boot/dts/samsung/exynos4412-midas.dtsi | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi b/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi index 05ddddb565ee..3cd027a99369 100644 --- a/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi +++ b/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi @@ -638,10 +638,13 @@ image-sensor@10 { svdda-supply = <&cam_io_reg>; svddio-supply = <&ldo19_reg>; afvdd-supply = <&ldo19_reg>; - clock-frequency = <24000000>; + /* CAM_B_CLKOUT */ clocks = <&camera 1>; clock-names = "extclk"; + assigned-clocks = <&camera 1>; + assigned-clock-rates = <24000000>; + gpios = <&gpm1 6 GPIO_ACTIVE_LOW>; port { -- Regards, Laurent Pinchart ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 68/72] ARM: dts: nxp: imx6qdl-pico: Replace clock-frequency in camera sensor node [not found] <20250812214620.30425-1-laurent.pinchart@ideasonboard.com> ` (2 preceding siblings ...) 2025-08-12 21:46 ` [PATCH v2 64/72] ARM: dts: samsung: exynos4412-midas: " Laurent Pinchart @ 2025-08-12 21:46 ` Laurent Pinchart 2025-08-12 21:46 ` [PATCH v2 69/72] ARM: dts: nxp: imx6qdl-wandboard: " Laurent Pinchart 4 siblings, 0 replies; 10+ messages in thread From: Laurent Pinchart @ 2025-08-12 21:46 UTC (permalink / raw) To: linux-media Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree, imx, linux-arm-kernel The clock-frequency for camera sensors has been deprecated in favour of the assigned-clocks and assigned-clock-rates properties. Replace it in the device tree. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- This patch depends on "media: i2c: ov5645: Use V4L2 legacy sensor clock helper", which we tentatively plan to merge for v6.18. It should therefore be postponed to v6.19. Changes since v1: - Drop added blank line --- arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi index c39a9ebdaba1..2ad1c030f51b 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico.dtsi @@ -233,7 +233,9 @@ camera@3c { pinctrl-0 = <&pinctrl_ov5645>; reg = <0x3c>; clocks = <&clks IMX6QDL_CLK_CKO2>; - clock-frequency = <24000000>; + assigned-clocks = <&clks IMX6QDL_CLK_CKO2>; + assigned-clock-rates = <24000000>; + vdddo-supply = <®_1p8v>; vdda-supply = <®_2p8v>; vddd-supply = <®_1p5v>; -- Regards, Laurent Pinchart ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 69/72] ARM: dts: nxp: imx6qdl-wandboard: Replace clock-frequency in camera sensor node [not found] <20250812214620.30425-1-laurent.pinchart@ideasonboard.com> ` (3 preceding siblings ...) 2025-08-12 21:46 ` [PATCH v2 68/72] ARM: dts: nxp: imx6qdl-pico: " Laurent Pinchart @ 2025-08-12 21:46 ` Laurent Pinchart 4 siblings, 0 replies; 10+ messages in thread From: Laurent Pinchart @ 2025-08-12 21:46 UTC (permalink / raw) To: linux-media Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree, imx, linux-arm-kernel The clock-frequency for camera sensors has been deprecated in favour of the assigned-clocks and assigned-clock-rates properties. Replace it in the device tree. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- This patch depends on "media: i2c: ov5645: Use V4L2 legacy sensor clock helper", which we tentatively plan to merge for v6.18. It should therefore be postponed to v6.19. Changes since v1: - Drop added blank line --- arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi index 26489eccd5fb..f3aaca039953 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi @@ -137,7 +137,9 @@ camera@3c { pinctrl-0 = <&pinctrl_ov5645>; reg = <0x3c>; clocks = <&clks IMX6QDL_CLK_CKO2>; - clock-frequency = <24000000>; + assigned-clocks = <&clks IMX6QDL_CLK_CKO2>; + assigned-clock-rates = <24000000>; + vdddo-supply = <®_1p8v>; vdda-supply = <®_2p8v>; vddd-supply = <®_1p5v>; -- Regards, Laurent Pinchart ^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2025-09-13 9:31 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250812214620.30425-1-laurent.pinchart@ideasonboard.com>
2025-08-12 21:45 ` [PATCH v2 01/72] dt-bindings: media: Deprecate clock-frequency property for camera sensors Laurent Pinchart
2025-08-13 4:44 ` Rob Herring (Arm)
2025-08-13 8:41 ` Laurent Pinchart
2025-08-13 9:49 ` [PATCH v2.1 " Laurent Pinchart
2025-09-12 22:41 ` Wolfram Sang
2025-09-13 9:31 ` Laurent Pinchart
2025-08-12 21:46 ` [PATCH v2 63/72] ARM: dts: samsung: exynos4210-i9100: Replace clock-frequency in camera sensor node Laurent Pinchart
2025-08-12 21:46 ` [PATCH v2 64/72] ARM: dts: samsung: exynos4412-midas: " Laurent Pinchart
2025-08-12 21:46 ` [PATCH v2 68/72] ARM: dts: nxp: imx6qdl-pico: " Laurent Pinchart
2025-08-12 21:46 ` [PATCH v2 69/72] ARM: dts: nxp: imx6qdl-wandboard: " Laurent Pinchart
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox