From: Yeoreum Yun <yeoreum.yun@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>,
broonie@kernel.org, maz@kernel.org, oliver.upton@linux.dev,
joey.gouly@arm.com, james.morse@arm.com, ardb@kernel.org,
scott@os.amperecomputing.com, suzuki.poulose@arm.com,
yuzenghui@huawei.com, mark.rutland@arm.com,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 RESEND 5/6] arm64: futex: small optimisation for __llsc_futex_atomic_set()
Date: Mon, 15 Sep 2025 11:41:16 +0100 [thread overview]
Message-ID: <aMftTNkHsbwAFdkt@e129823.arm.com> (raw)
In-Reply-To: <aMRMBEdro1YJ5RLW@arm.com>
On Fri, Sep 12, 2025 at 05:36:20PM +0100, Catalin Marinas wrote:
> On Thu, Sep 11, 2025 at 05:19:11PM +0100, Yeoreum Yun wrote:
> > > > +static __always_inline int
> > > > +__llsc_futex_atomic_set(int oparg, u32 __user *uaddr, int *oval)
> [...]
> > > Hmm, I'm really not sure this is worthwhile. I doubt the "optimisation"
> > > actually does anything and adding a whole new block of asm just for the
> > > SET case isn't much of an improvement on the maintainability side, either.
> >
> > TBH, I had the same question, but I thought this code seems to modify
> > freqenetly, I decide even a small optimisation -- reduce one instruction
> > only.
> >
> > But I don't have strong opinion for this patch.
> > If it's not good for maintainability perspective,
> > This patch can be dropped.
>
> I'd drop it for now unless you can show some performance benefits
> (unlikely).
Yes. not much of improvement. So I'll drop this patch.
Thanks.
--
Sincerely,
Yeoreum Yun
next prev parent reply other threads:[~2025-09-15 10:42 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-16 15:19 [PATCH RESEND v7 0/6] support FEAT_LSUI and apply it on futex atomic ops Yeoreum Yun
2025-08-16 15:19 ` [PATCH RESEND v7 1/6] arm64: cpufeature: add FEAT_LSUI Yeoreum Yun
2025-09-12 16:12 ` Catalin Marinas
2025-08-16 15:19 ` [PATCH RESEND v7 2/6] KVM: arm64: expose FEAT_LSUI to guest Yeoreum Yun
2025-09-12 16:25 ` Catalin Marinas
2025-08-16 15:19 ` [PATCH RESEND v7 3/6] arm64: Kconfig: add LSUI Kconfig Yeoreum Yun
2025-09-12 16:24 ` Catalin Marinas
2025-09-15 10:42 ` Yeoreum Yun
2025-09-15 11:32 ` Will Deacon
2025-09-15 11:41 ` Yeoreum Yun
2025-08-16 15:19 ` [PATCH RESEND v7 4/6] arm64: futex: refactor futex atomic operation Yeoreum Yun
2025-09-11 15:38 ` Will Deacon
2025-09-11 16:04 ` Yeoreum Yun
2025-09-12 16:44 ` Catalin Marinas
2025-09-12 17:01 ` Catalin Marinas
2025-09-15 10:39 ` Yeoreum Yun
2025-09-12 16:53 ` Catalin Marinas
2025-09-15 10:32 ` Yeoreum Yun
2025-09-15 19:40 ` Catalin Marinas
2025-09-15 20:35 ` Will Deacon
2025-09-16 7:02 ` Catalin Marinas
2025-09-16 9:15 ` Yeoreum Yun
2025-09-16 9:24 ` Yeoreum Yun
2025-09-16 10:02 ` Yeoreum Yun
2025-09-16 10:16 ` Will Deacon
2025-09-16 12:50 ` Yeoreum Yun
2025-09-17 9:32 ` Yeoreum Yun
2025-09-16 12:47 ` Mark Rutland
2025-09-16 13:27 ` Yeoreum Yun
2025-09-16 13:45 ` Mark Rutland
2025-09-16 13:58 ` Yeoreum Yun
2025-09-16 14:07 ` Mark Rutland
2025-09-16 14:15 ` Yeoreum Yun
2025-09-15 22:34 ` Yeoreum Yun
2025-09-16 12:53 ` Catalin Marinas
2025-08-16 15:19 ` [PATCH v7 RESEND 5/6] arm64: futex: small optimisation for __llsc_futex_atomic_set() Yeoreum Yun
2025-09-11 15:28 ` Will Deacon
2025-09-11 16:19 ` Yeoreum Yun
2025-09-12 16:36 ` Catalin Marinas
2025-09-15 10:41 ` Yeoreum Yun [this message]
2025-08-16 15:19 ` [PATCH RESEND v7 6/6] arm64: futex: support futex with FEAT_LSUI Yeoreum Yun
2025-09-11 15:22 ` Will Deacon
2025-09-11 16:45 ` Yeoreum Yun
2025-09-12 17:16 ` Catalin Marinas
2025-09-15 9:15 ` Yeoreum Yun
2025-09-12 17:09 ` Catalin Marinas
2025-09-15 8:24 ` Yeoreum Yun
2025-09-01 10:06 ` [PATCH RESEND v7 0/6] support FEAT_LSUI and apply it on futex atomic ops Yeoreum Yun
2025-09-11 15:09 ` Will Deacon
2025-09-11 16:22 ` Catalin Marinas
2025-09-15 20:37 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMftTNkHsbwAFdkt@e129823.arm.com \
--to=yeoreum.yun@arm.com \
--cc=ardb@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=scott@os.amperecomputing.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).