From: Frank Li <Frank.li@nxp.com>
To: Isaac Scott <isaac.scott@ideasonboard.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rui Miguel Silva <rmfrfs@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Martin Kepplinger <martink@posteo.de>,
Purism Kernel Team <kernel@puri.sm>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/4] media: imx-mipi-csis: Move redundant debug print in probe
Date: Thu, 25 Sep 2025 17:37:32 -0400 [thread overview]
Message-ID: <aNW2HHF4Z4Jkwc36@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20250925-active-data-lanes-v4-2-8b54e3d5af6c@ideasonboard.com>
On Thu, Sep 25, 2025 at 04:54:27PM +0100, Isaac Scott wrote:
> The number of data lanes is already printed as part of
> mipi_csis_async_register(), making the first part of this print
> redundant. Remove the redundant print, and move the debug print for
> clock frequency to mipi_csis_parse_dt().
>
> Signed-off-by: Isaac Scott <isaac.scott@ideasonboard.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
> drivers/media/platform/nxp/imx-mipi-csis.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/nxp/imx-mipi-csis.c b/drivers/media/platform/nxp/imx-mipi-csis.c
> index d5de7854f579..7c2a679dca2e 100644
> --- a/drivers/media/platform/nxp/imx-mipi-csis.c
> +++ b/drivers/media/platform/nxp/imx-mipi-csis.c
> @@ -1481,6 +1481,7 @@ static int mipi_csis_parse_dt(struct mipi_csis_device *csis)
> struct device_node *node = csis->dev->of_node;
>
> of_property_read_u32(node, "clock-frequency", &csis->clk_frequency);
> + dev_dbg(csis->dev, "clock frequency: %u\n", csis->clk_frequency);
>
> csis->num_channels = 1;
> of_property_read_u32(node, "fsl,num-channels", &csis->num_channels);
> @@ -1566,9 +1567,6 @@ static int mipi_csis_probe(struct platform_device *pdev)
> goto err_unregister_all;
> }
>
> - dev_info(dev, "lanes: %d, freq: %u\n",
> - csis->bus.num_data_lanes, csis->clk_frequency);
> -
> return 0;
>
> err_unregister_all:
>
> --
> 2.43.0
>
next prev parent reply other threads:[~2025-09-25 21:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 15:54 [PATCH v4 0/4] media: imx-mipi-csis: Get the number of active lanes from mbus_config Isaac Scott
2025-09-25 15:54 ` [PATCH v4 1/4] media: v4l: Add helper to get number of active lanes via a pad Isaac Scott
2025-09-25 15:54 ` [PATCH v4 2/4] media: imx-mipi-csis: Move redundant debug print in probe Isaac Scott
2025-09-25 21:37 ` Frank Li [this message]
2025-09-25 15:54 ` [PATCH v4 3/4] media: imx-mipi-csis: Store the number of data_lanes configured in dt Isaac Scott
2025-09-25 21:49 ` Frank Li
2025-09-26 8:46 ` Isaac Scott
2025-09-25 15:54 ` [PATCH v4 4/4] media: imx-mipi-csis: Get number of active lanes via mbus_config Isaac Scott
2025-09-25 21:55 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNW2HHF4Z4Jkwc36@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=isaac.scott@ideasonboard.com \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=martink@posteo.de \
--cc=mchehab@kernel.org \
--cc=rmfrfs@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox