From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E951CCD192 for ; Wed, 15 Oct 2025 14:32:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ecLrV/H7WOdea++PIOhJzOYjYvk7czStLHW65aL6bo4=; b=zIhVK+2tt7taGMM9kporIn76s+ pOayEQRHSi9JVqE5kGRweATPsVr5Nlpn5TQyVY37BUY8SZ8BW1A+qifbgBMsTcugDw+jiNqvaLs/z VlW/dKEiX70CpVgIiKY9Exp7GWOKzaI3KGBHeN/1zv52TVylmepY8tUr2fk6SNLJ8BdfgGnPdyA/m TU9A77uEir4O25jxPAcUU8EUV24goDBGRUw7I66PdrdJbcJitnQTc9j6NsnkI4TbEzppA4I2W6ARv RgtxoJNN8IL9ZSBAMp3/YlAjSnotRP266YYxh92E1WXxweQ5V5cBddTtJoksRN7GMWEEEyXJgn5Zz TLHYGalw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v92Xo-00000001tfP-2u4d; Wed, 15 Oct 2025 14:32:00 +0000 Received: from mail-swedencentralazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c202::7] helo=GVXPR05CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v92Xm-00000001teM-2Vjr for linux-arm-kernel@lists.infradead.org; Wed, 15 Oct 2025 14:31:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vnvc0N/pD8hUL77OOVSLxXodXa/Ko9PYDsIYuHEjbEyKYuqf0xc0XqU6Ihe2XM8boW7HOFdZkBo6qucA1So5mjHS/WXWQvIgq9+4Gt/LCK4MK6ow8gtSYDDi4O0GewlmtVBw47tV9DX61Wvd3joB11cYUFbabpbyXD1Qk/2HIVF2E7N7dNXw3AcFLJ6bcFlRlyQchaJVW9MXh/r25BzWCDHZ+ABMz1Kz/AY7jSb/jWD6HKq62CEy70/7Aj91UvRIhX0JW8pAgO0IptuPiuVxmKFDOpxgmtUGWrbQJyeLIE0JKk7AfQDbRV/d1H6ThHspdhg6ocXL1isrjLWz6qkn+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ecLrV/H7WOdea++PIOhJzOYjYvk7czStLHW65aL6bo4=; b=NdVmAYuReMXO5sfLuRdjrRFgIldxcW/tuXtyUWbkvXO5Ndk+KROGrSP+64PByfv46C/kG9AGJvNRdEsCTxIlyaZBsSMN+4MJENQaIA3aujGdp2pLeAmtHIo179hAfHz8y6AE8PkFF4Vx0A0AeruDz+VLrF3zHnRFzcjwz5uoZPvZt7tQ2HsAB9vXTghiVFWeOZho6A1ugsCfdAmJN8fm/8vynw2+7vY1UyxxpmtE9VouWLYTGjoKjgUAQj9gatbsgHCyEfka4WnfYrVZaTU7y8JNNygUI+sAdNcDNjqAYmx77CvxcrihBUfZ6zuvcmfcuOurRPC8KJFHMtaVx5r51g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ecLrV/H7WOdea++PIOhJzOYjYvk7czStLHW65aL6bo4=; b=cPEyu+maOUGBdwkZT+yI2nj89TziuYv2Iy1WOujB6nrzN9FxcLyL6ZJAkaObSaqRMO0jBHQjsHVothSkLSBBFWRdOrKuGM2GodGQA4vT/zpxTQtxIeMX2NyS9VBMOKegE8+xpWo5PE4ZZaSiNcktOVdFxDo4KKykNIIDJ/lyieJD7kEfsYsWVTwIlc2HQ2TTKdtrS3/UEYCHJCc91KbyG1nKt0FPCQyEkETGT6JaYaKGF1D59M4CV26rExi3Spje+5YFWSFMW2v24QQ07XPtNA7AgsfCUJPNl54Ak+yEE8HPlUyUPkcIAfANEQ5fu5dhovmwGsVOnFBGfLvFHVPcAg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXSPRMB0053.eurprd04.prod.outlook.com (2603:10a6:102:23f::21) by OSKPR04MB11416.eurprd04.prod.outlook.com (2603:10a6:e10:9b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9228.11; Wed, 15 Oct 2025 14:31:50 +0000 Received: from PAXSPRMB0053.eurprd04.prod.outlook.com ([fe80::504f:2a06:4579:5f15]) by PAXSPRMB0053.eurprd04.prod.outlook.com ([fe80::504f:2a06:4579:5f15%6]) with mapi id 15.20.9228.010; Wed, 15 Oct 2025 14:31:50 +0000 Date: Wed, 15 Oct 2025 10:31:41 -0400 From: Frank Li To: Liu Ying Cc: Marek Vasut , dri-devel@lists.freedesktop.org, Abel Vesa , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Laurent Pinchart , Lucas Stach , Peng Fan , Pengutronix Kernel Team , Rob Herring , Shawn Guo , Thomas Zimmermann , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 05/39] drm/imx: dc: Rework dc_subdev_get_id() to drop ARRAY_SIZE() use Message-ID: References: <20251011170213.128907-1-marek.vasut@mailbox.org> <20251011170213.128907-6-marek.vasut@mailbox.org> <43e3e005-5d30-4450-8dbc-8c6b5a0fa951@mailbox.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: PH7P220CA0019.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:326::26) To PAXSPRMB0053.eurprd04.prod.outlook.com (2603:10a6:102:23f::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXSPRMB0053:EE_|OSKPR04MB11416:EE_ X-MS-Office365-Filtering-Correlation-Id: 62db47e2-841e-472f-dc59-08de0bf79432 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|1800799024|7416014|19092799006|376014|38350700014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?AGZ7dQDOe/9kmMlC8JqthqMv3kRuxCEKU0WtPWszXWEIKwI9Mqzt9nFQypB0?= =?us-ascii?Q?2Z6KzY1wNRZjob+woLr+Qay71NICuTGkwicL3/w59c/7cGCTT+JrUGYt/97K?= =?us-ascii?Q?LD7Hob3ioNx1L0gmaYAjLFbrrPHFr793vzMgR7OEjkTq7BAwIjTuT/7zsmyL?= =?us-ascii?Q?bZgHWbJsMs7UiBzLRjAD22vOCoYrZ3Bt9OF2aYSQ9k36xd3vWTLBIlqc8yKs?= =?us-ascii?Q?HTj5y2EfKoy/zHQcQba/hpyNPnoboxeW/Qr1AAbd0yqUVXbCmrwfDqVM9489?= =?us-ascii?Q?GUMLUJSBwPaUI5khLO14wwZZPwYxnJhv40WdUqExsHstCixZ7sCnft/9rLD8?= =?us-ascii?Q?Kf1DCjpYQnOFE3ke+3Q3HuFYW34Lglyi99AG29owkaMxeMXDEbTTtEs3Epn4?= =?us-ascii?Q?9Q+lQuDHJd6p4o3Ul8aClkS7ahAf+WjCSu4omaCxgpVEgeytij04OgN31Avy?= =?us-ascii?Q?fkt4JJPsJxybrq1t90lOwljiCcWlWMA9qScYfvsaMpT6UTwWAaGe9luHVCyn?= =?us-ascii?Q?uoHW94wU4hh+Gx/D5lPA537FUNqrWUq+OGvX1APc9DAng31c/Fud1CHfo4N4?= =?us-ascii?Q?XoHulKJfYIHkpdTR0E4Ut7atTUUxi0hVRZ1mSGLW9sCv7IX8WbVCqoFVBYxU?= =?us-ascii?Q?IpiyC4qJ5JpgBzNBed5X2nNZwD5GBlde2ps0DhRNs8oAdU2gPYXQT+bM4Lwm?= =?us-ascii?Q?BIxJ6i2CDnAmWsf7LT/+QO7vGaZio1tOkIJQAlMFmIyt874fMixh5DZ1sPbA?= =?us-ascii?Q?MZ/GCzdRBipDI+3yZ2BfwPHVJmtxp8PA9e77JtoecCkt75XsgQ9fMUhcsFPr?= =?us-ascii?Q?W/nAZgII5xTVjg2fkWRLuFr7+w9Cn+Qsxqx/j8/ZqxiRp43IHCmhqjf6EEaX?= =?us-ascii?Q?w/0IPabJa90cA2q6dBvje53mVVd4ZtGNdifLJzKyZk2+yfg69EWoSB054uUX?= =?us-ascii?Q?FlMceEtJ5yeGK6uFzO/jjFe0mAWygr2zXPWQcKOZgAz6DLeyku6awqrwTNZK?= =?us-ascii?Q?QUCztREXbVXUspVPedh8lAOXCGH1rxDCCw/EEz+olZemgXO/u0EAE0aoudnQ?= =?us-ascii?Q?6epqtw/WDDkvW1R3tOCaBHYY0czRlBLnT+uirJanXgXJiOG/HnykcUlETBsw?= =?us-ascii?Q?pXRFi+za1uh15cyPD3WN/i+YN/jBAAeVohSzy0gzlEuJ0Gvq/ayHCFwzy04f?= =?us-ascii?Q?0eSdGtWJ8U+OhZclljDuQ1i39wKa3lQorm5yvxOctFdsw5P5XnexYTpCEMsD?= =?us-ascii?Q?pCtWGpzqnLmAz7Azqffd0FztvKA/zFAtw7ZNdhos6zOL5pWJlWNehBbWr0Eh?= =?us-ascii?Q?bkYW+3IU814c1gebXvKE94PWz31kbr3VcyCHP9yCOr1Aek6bzqqoeC+I7Jy4?= =?us-ascii?Q?oB/n4JOPhril4VoRQ4jtlM3UWdbv37fLB8JX2436LQWWEFaEAjiA8JIv+sg6?= =?us-ascii?Q?KTl0oGiX3H0Umva3Sh7JDf/4xXVfuPmQLjYxxrFTAjC5j2tONhJdOCpU4Owp?= =?us-ascii?Q?7CvaUqIfL3fSQ4NGFH+/sv+Su/NUsd8eo+8x?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXSPRMB0053.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(1800799024)(7416014)(19092799006)(376014)(38350700014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?U331wE177++GE1VtYJs73UlELgQ1XQe/8lvnIBHPxJNki3Qfir0MSQ+r9Tfa?= =?us-ascii?Q?K2k9Nn0AvHQ0SeKMGPWYpmUCmThNkkCsEmuD/tGbmBmxfjMsTtZ9s3/LrSHp?= =?us-ascii?Q?kLOdPPbEPSC6uW6a7ffT2qf3UARqrq8zSGb0+ZarAevjEe8zYSRuEofdto07?= =?us-ascii?Q?pk7Vh1Vex7cUg+iUjwFctpldKCqSxtcDZVGCgToZl9Vun8YxM8ep0cw+LFhf?= =?us-ascii?Q?v7GqlTVv7rqtKv0XnPxyDKbI1FvmiccsgeHJ2wr2dbC0oQCZEXfjGRmALTim?= =?us-ascii?Q?SU1ATvWihKrsL3m23zGUWO9xl9jxY1iP8YtqjMy1NW5TjBGGYA+9bOdyO82c?= =?us-ascii?Q?ZZKrmOkF5NTYZtbdBtIxYqQw9h7fqSlfF7TSluu3lUEPkB6zUxEk3b/FeOTO?= =?us-ascii?Q?f77ihU22y9ID6Xiys8vc1WR93SIcNvaetV6l/B6kfCXzDNAyM6qugX1x4L5K?= =?us-ascii?Q?zwgWvySNZpVhTMAfJmd7XlZQ5JXIp4eZPyhwhaGJxi1Q/scAuZ57EJk2p9Ma?= =?us-ascii?Q?7e/b7qEL7kp3c2uI9tiIq/kAe3jMAoLZIWbFbB5aC8JmQ1RwH5N/GMV6IWtv?= =?us-ascii?Q?vDlrSGqG4CY+uARACkqJwAohXZRIFVON6V85i2fU/VRdY3cKwefBhpAkfy7p?= =?us-ascii?Q?ZF+8fQOduV0JoEHROnFlZ5rUnv87dBGO94ByeZKozj+VGddu0R/Oeg0Bbhb5?= =?us-ascii?Q?lQhiSj6ptTo9GmHjL7iiNad7XbiVYE8QzVKF7bAmMQb3R76KU3qkZIbMFQnz?= =?us-ascii?Q?Gf2N7MhFLEgRQ0wRRD/CPxMWnm+CHFtwYyrDFVKczRhauZT7KYBVz/Ln83gH?= =?us-ascii?Q?uia4i7NJbjkMEiXvsk9T8cLZj/XEPiQpStQFHcmOuHU982PDcaW1dB3/X3Jq?= =?us-ascii?Q?+oD3g8rSMok5ZOPqs4Flm7PiazB2pFnKfXDP4VltjC/uIQk30V714K2hpEY0?= =?us-ascii?Q?HLmVDE1rIyMcPN62R7LbXjxah+vc+MXwHcfUAujOjb4+pQU4NDzPoL2ZzBj+?= =?us-ascii?Q?ayxvqGVk4r26ZyYUF93uso9PJvjmMduvUeZLfKdo5tkL/fqG4vc5pXOvu94E?= =?us-ascii?Q?Tr4znc8r5YDayey4FlKE8X2ny43yhrMuAdKguZfEpZoW+HSQiWyXTrM7Zb7j?= =?us-ascii?Q?E/vT+WzOiMFVpulhRis9WgHgbQkVofWM16HBqwMYhGZsyerQ5O7S1yIHgTfI?= =?us-ascii?Q?DB1qjOGDJGA/YZHa4ng+hqySFOC5gyDsZYXUqVJQ/zEUsxJ5S5QZrx1ftvYx?= =?us-ascii?Q?4DxNq9kxDs2Of5FjjQL5ioawDislDu065A9WT0ezp/1p+ZvuXI5HhB/yuQqB?= =?us-ascii?Q?BL2qFMOecrC//8o5COgG3Iu5Oy4DwLrej86ZMTmVDJalb1IirUvoWrorlfUG?= =?us-ascii?Q?tPrgoZf8QDV4jEpSEHfNFwFvnfwHEIRd7lTNUKYibMj0/EvfUF03Zr36B8if?= =?us-ascii?Q?fJIhEL1hXpAK056WKawySQfZwa2Kk/2YW7GUJ8c+44d3RikRUQZ/WrE+9jcQ?= =?us-ascii?Q?gPHTGxbZwMamQ0G0PaQVqwCJyh1MhVUWhQhh+TcbxbOdIDuOQ60fed2NVvbn?= =?us-ascii?Q?9Tqv3J9raJW6P72j3Kxz4QgFkaOoqlMEa6c5/WCD?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62db47e2-841e-472f-dc59-08de0bf79432 X-MS-Exchange-CrossTenant-AuthSource: PAXSPRMB0053.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2025 14:31:50.6547 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8x8uQPQnuShadTDpT3Lo7ExiK/SiTaA9bVbiApFvODzB/BzYud4t1un3CMOUu/X90iI31w2sXD1ZAdBCt+xO3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSKPR04MB11416 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251015_073158_639052_845F8040 X-CRM114-Status: GOOD ( 25.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 15, 2025 at 05:14:02PM +0800, Liu Ying wrote: > On 10/14/2025, Marek Vasut wrote: > > On 10/14/25 5:11 PM, Frank Li wrote: > >> On Tue, Oct 14, 2025 at 04:03:37PM +0200, Marek Vasut wrote: > >>> On 10/13/25 6:56 PM, Frank Li wrote: > >>>> On Sat, Oct 11, 2025 at 06:51:20PM +0200, Marek Vasut wrote: > >>>>> Rework dc_subdev_get_id() to drop ARRAY_SIZE() use and use empty trailing > >>>>> entry in each ID look up array instead. This allows passing of those arrays > >>>>> around as OF match data, which will be useful when using this pipeline on > >>>>> i.MX95, which has different address-to-ID mapping. > >>>>> > >>>>> Signed-off-by: Marek Vasut > >>>> > >>>> This change is okay. but my questions is why need map register to id. > >>> > >>> This seems to be a recurring pattern in the driver, where some components > >>> need to find other components to link with them. The mapping is fixed, and > >>> since the DT does not encode link IDs, the resolution of the mapping has to > >>> happen by mapping the component base addresses to the IDs first. > >> > >> In graphic link, port@, n should be id? why not use it? > > I suspect you could model the relationships between the DC blocks using OF > > graph, yes. I also suspect that description would be very complex in > > DT, considering the amount of blocks and links this device contains. I > > suspect this is why there is no such DT description using OF graph. > > Yes. The design decision was made to avoid using OF graph to describe > links between DC blocks due to the complexity. Any previous discuission? Using registers base address to determiate ID is not solution. Frank > > > > > I think it might also be good to talk to Liu directly about the original design > > decision and why this id mapping was done the way it was done, > > they should know better than me. > > > -- > Regards, > Liu Ying