On Oct 07, Paolo Abeni wrote:
> On 10/5/25 4:52 PM, Lorenzo Bianconi wrote:
> > Add missing configuration for loopback mode in airhoha_set_gdm2_loopback
> > routine.
> > 
> > Fixes: 9cd451d414f6e ("net: airoha: Add loopback support for GDM2")
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> >  drivers/net/ethernet/airoha/airoha_eth.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ethernet/airoha/airoha_eth.c b/drivers/net/ethernet/airoha/airoha_eth.c
> > index 81ea01a652b9c545c348ad6390af8be873a4997f..abe7a23e3ab7a189a3a28007004572719307de90 100644
> > --- a/drivers/net/ethernet/airoha/airoha_eth.c
> > +++ b/drivers/net/ethernet/airoha/airoha_eth.c
> > @@ -1710,7 +1710,9 @@ static void airhoha_set_gdm2_loopback(struct airoha_gdm_port *port)
> >  	airoha_fe_wr(eth, REG_GDM_RXCHN_EN(2), 0xffff);
> >  	airoha_fe_rmw(eth, REG_GDM_LPBK_CFG(2),
> >  		      LPBK_CHAN_MASK | LPBK_MODE_MASK | LPBK_EN_MASK,
> > -		      FIELD_PREP(LPBK_CHAN_MASK, chan) | LPBK_EN_MASK);
> > +		      FIELD_PREP(LPBK_CHAN_MASK, chan) |
> > +		      FIELD_PREP(LPBK_MODE_MASK, 7) |
> 
> I suggest introducing some human readable macro to replace the above
> magic number.

ack, I will do in v2.

Regards,
Lorenzo

> 
> Thanks,
> 
> Paolo
>