linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] arm64: dts: fsl-ls1028a: fix USB node compatible
@ 2025-10-20 13:37 Alexander Stein
  2025-10-20 20:11 ` Frank Li
  0 siblings, 1 reply; 5+ messages in thread
From: Alexander Stein @ 2025-10-20 13:37 UTC (permalink / raw)
  To: Shawn Guo, Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: Alexander Stein, linux-arm-kernel, devicetree, linux-kernel

usb/fsl,ls1028a.yaml says the compatible is just a simple
'fsl,ls1028a-dwc3'

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index 7d172d7e5737c..ddfb007dda920 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -613,7 +613,7 @@ gpio3: gpio@2320000 {
 		};
 
 		usb0: usb@3100000 {
-			compatible = "fsl,ls1028a-dwc3", "snps,dwc3";
+			compatible = "fsl,ls1028a-dwc3";
 			reg = <0x0 0x3100000 0x0 0x10000>;
 			interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
 			snps,dis_rxdet_inp3_quirk;
@@ -623,7 +623,7 @@ usb0: usb@3100000 {
 		};
 
 		usb1: usb@3110000 {
-			compatible = "fsl,ls1028a-dwc3", "snps,dwc3";
+			compatible = "fsl,ls1028a-dwc3";
 			reg = <0x0 0x3110000 0x0 0x10000>;
 			interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
 			snps,dis_rxdet_inp3_quirk;
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] arm64: dts: fsl-ls1028a: fix USB node compatible
  2025-10-20 13:37 [PATCH 1/1] arm64: dts: fsl-ls1028a: fix USB node compatible Alexander Stein
@ 2025-10-20 20:11 ` Frank Li
  2025-10-21  6:40   ` Alexander Stein
  2025-10-27  6:58   ` Shawn Guo
  0 siblings, 2 replies; 5+ messages in thread
From: Frank Li @ 2025-10-20 20:11 UTC (permalink / raw)
  To: Alexander Stein
  Cc: Shawn Guo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-kernel, devicetree, linux-kernel

On Mon, Oct 20, 2025 at 03:37:53PM +0200, Alexander Stein wrote:
> usb/fsl,ls1028a.yaml says the compatible is just a simple
> 'fsl,ls1028a-dwc3'
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Thanks, but it is similar with last patches of

https://lore.kernel.org/imx/20250929-ls_dma_coherence-v5-4-2ebee578eb7e@nxp.com/

Waiting for shanw pick dts part.

Frank

> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 7d172d7e5737c..ddfb007dda920 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -613,7 +613,7 @@ gpio3: gpio@2320000 {
>  		};
>
>  		usb0: usb@3100000 {
> -			compatible = "fsl,ls1028a-dwc3", "snps,dwc3";
> +			compatible = "fsl,ls1028a-dwc3";
>  			reg = <0x0 0x3100000 0x0 0x10000>;
>  			interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
>  			snps,dis_rxdet_inp3_quirk;
> @@ -623,7 +623,7 @@ usb0: usb@3100000 {
>  		};
>
>  		usb1: usb@3110000 {
> -			compatible = "fsl,ls1028a-dwc3", "snps,dwc3";
> +			compatible = "fsl,ls1028a-dwc3";
>  			reg = <0x0 0x3110000 0x0 0x10000>;
>  			interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
>  			snps,dis_rxdet_inp3_quirk;
> --
> 2.43.0
>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] arm64: dts: fsl-ls1028a: fix USB node compatible
  2025-10-20 20:11 ` Frank Li
@ 2025-10-21  6:40   ` Alexander Stein
  2025-10-27  6:58   ` Shawn Guo
  1 sibling, 0 replies; 5+ messages in thread
From: Alexander Stein @ 2025-10-21  6:40 UTC (permalink / raw)
  To: Frank Li
  Cc: Shawn Guo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-kernel, devicetree, linux-kernel

Hi Frank,

Am Montag, 20. Oktober 2025, 22:11:20 CEST schrieb Frank Li:
> On Mon, Oct 20, 2025 at 03:37:53PM +0200, Alexander Stein wrote:
> > usb/fsl,ls1028a.yaml says the compatible is just a simple
> > 'fsl,ls1028a-dwc3'
> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> 
> Thanks, but it is similar with last patches of
> 
> https://lore.kernel.org/imx/20250929-ls_dma_coherence-v5-4-2ebee578eb7e@nxp.com/
> 
> Waiting for shanw pick dts part.

Ah, I missed that. Thanks for the link

Best regards
Alexander

> 
> Frank
> 
> > ---
> >  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > index 7d172d7e5737c..ddfb007dda920 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > @@ -613,7 +613,7 @@ gpio3: gpio@2320000 {
> >  		};
> >
> >  		usb0: usb@3100000 {
> > -			compatible = "fsl,ls1028a-dwc3", "snps,dwc3";
> > +			compatible = "fsl,ls1028a-dwc3";
> >  			reg = <0x0 0x3100000 0x0 0x10000>;
> >  			interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
> >  			snps,dis_rxdet_inp3_quirk;
> > @@ -623,7 +623,7 @@ usb0: usb@3100000 {
> >  		};
> >
> >  		usb1: usb@3110000 {
> > -			compatible = "fsl,ls1028a-dwc3", "snps,dwc3";
> > +			compatible = "fsl,ls1028a-dwc3";
> >  			reg = <0x0 0x3110000 0x0 0x10000>;
> >  			interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
> >  			snps,dis_rxdet_inp3_quirk;
> > --
> > 2.43.0
> >
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] arm64: dts: fsl-ls1028a: fix USB node compatible
  2025-10-20 20:11 ` Frank Li
  2025-10-21  6:40   ` Alexander Stein
@ 2025-10-27  6:58   ` Shawn Guo
  2025-10-27 18:15     ` Frank Li
  1 sibling, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2025-10-27  6:58 UTC (permalink / raw)
  To: Frank Li
  Cc: Alexander Stein, Shawn Guo, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-kernel, devicetree, linux-kernel

On Mon, Oct 20, 2025 at 04:11:20PM -0400, Frank Li wrote:
> On Mon, Oct 20, 2025 at 03:37:53PM +0200, Alexander Stein wrote:
> > usb/fsl,ls1028a.yaml says the compatible is just a simple
> > 'fsl,ls1028a-dwc3'
> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> 
> Thanks, but it is similar with last patches of
> 
> https://lore.kernel.org/imx/20250929-ls_dma_coherence-v5-4-2ebee578eb7e@nxp.com/
> 
> Waiting for shanw pick dts part.

I'm waiting for the usb binding change in the series to be applied first.

Shawn



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] arm64: dts: fsl-ls1028a: fix USB node compatible
  2025-10-27  6:58   ` Shawn Guo
@ 2025-10-27 18:15     ` Frank Li
  0 siblings, 0 replies; 5+ messages in thread
From: Frank Li @ 2025-10-27 18:15 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Alexander Stein, Shawn Guo, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-kernel, devicetree, linux-kernel

On Mon, Oct 27, 2025 at 02:58:40PM +0800, Shawn Guo wrote:
> On Mon, Oct 20, 2025 at 04:11:20PM -0400, Frank Li wrote:
> > On Mon, Oct 20, 2025 at 03:37:53PM +0200, Alexander Stein wrote:
> > > usb/fsl,ls1028a.yaml says the compatible is just a simple
> > > 'fsl,ls1028a-dwc3'
> > >
> > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> >
> > Thanks, but it is similar with last patches of
> >
> > https://lore.kernel.org/imx/20250929-ls_dma_coherence-v5-4-2ebee578eb7e@nxp.com/
> >
> > Waiting for shanw pick dts part.
>
> I'm waiting for the usb binding change in the series to be applied first.

It is already in linux-next

commit b9f1c762a4de17d93017fbd12b9941caff6d3078
Author: Frank Li <Frank.Li@nxp.com>
Date:   Mon Sep 29 10:24:14 2025 -0400

    dt-bindings: usb: add missed compatible string for arm64 layerscape

    Add missed compatible string for arm64 layerscape platform. Allow these
    fallback to fsl,ls1028a-dwc3.

    Remove fallback snps,dwc3 because layerscape dwc3 is not full compatible
    with common snps,dwc3 device, a special value gsburstcfg0 need be set when
    dma coherence enabled.

    Allow iommus property.

    Change ref to snps,dwc3-common.yaml to use dwc3 flatten library.

    Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
    Signed-off-by: Frank Li <Frank.Li@nxp.com>
    Link: https://lore.kernel.org/r/20250929-ls_dma_coherence-v5-1-2ebee578eb7e@nxp.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Frank

>
> Shawn
>


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-10-27 18:16 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-20 13:37 [PATCH 1/1] arm64: dts: fsl-ls1028a: fix USB node compatible Alexander Stein
2025-10-20 20:11 ` Frank Li
2025-10-21  6:40   ` Alexander Stein
2025-10-27  6:58   ` Shawn Guo
2025-10-27 18:15     ` Frank Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).