From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD850CCF9EA for ; Mon, 27 Oct 2025 10:48:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gRjQEbu4fSBRYviBImLXiY5NsyYQtq0ADZkhXiDh0JM=; b=gS/EZbL9T1BR1p1cdGzFroRNpt 0T8yfA5ye4uQBa/KWSckch9uVBCwfxzL1640dId/bjBU3ig3xSi85M+vtb9dG2ayMjoSSWTx/lqOR fF46cUSs4daKr9/VXBLSmR2fjXtIBsP/P8BY9kKE6k8YHCDPvB2xlK89PKxcWJt4jq97I/quit4hx FuGNUHisYWC+hPfLT+ENFbs8XHnvs1sZawH1+Z9CAXaEUtcYq5j8YTH0vi6+0vi61kA5j9BM/mLfh Hj6bBQ7AS4wxEhH4/51pVXtIE2mLRgBJl4Yc4YjF1VPMTLGCGCfsxn0KwZx3Wa0iGR5BfZak2y7L6 vM9do9IQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDKmD-0000000DgfO-25Kr; Mon, 27 Oct 2025 10:48:37 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDKmA-0000000Dgex-3xe8 for linux-arm-kernel@lists.infradead.org; Mon, 27 Oct 2025 10:48:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=gRjQEbu4fSBRYviBImLXiY5NsyYQtq0ADZkhXiDh0JM=; b=Ol4c2eg2VklUqA0jaLZmdsQ+23 HXiu9/ysPF2s5iy4F10cm9+7DJQZq+D7s+rmUlEJiGa5wVAZMCg3BZRK/apKA3OeNKc01ANC59ab7 qNw8xke7mRndr/7Yu/gLONLbUCpUxhgFZMatCV43CcKiMCPSO+BEpe3ezCQrtUQRxSNbj+NAd7lfd +BnwGykGsbUaT8G44puLLBKL52q0kkMNi5Xz9FMDgrl1dytnzVeoFuY2IUtkrLB95zpKf6fPuBmoy v/Wwz76Tort4QE6h5p/pPkpNNynfwEzFDIi0WJMQ6P/GSl/cmCG/1sH87/7+61Ty4k9ve2Wmfw7FB 5+6/TsKQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:60878) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vDKm0-000000001gb-0cyJ; Mon, 27 Oct 2025 10:48:24 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1vDKly-000000005WR-1q0w; Mon, 27 Oct 2025 10:48:22 +0000 Date: Mon, 27 Oct 2025 10:48:22 +0000 From: "Russell King (Oracle)" To: Oleksij Rempel Cc: Laurent Pinchart , devicetree@vger.kernel.org, Conor Dooley , imx@lists.linux.dev, Shawn Guo , Sascha Hauer , Kieran Bingham , Andrew Lunn , Daniel Scally , Pengutronix Kernel Team , Stefan Klug , Krzysztof Kozlowski , Fabio Estevam , Rob Herring , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: dts: imx8mp-debix-model-a: Disable EEE for 1000T Message-ID: References: <20251026122905.29028-1-laurent.pinchart@ideasonboard.com> <20251027100227.GE1544@pendragon.ideasonboard.com> <20251027103107.GF1544@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251027_034834_983194_404EED3C X-CRM114-Status: GOOD ( 23.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 27, 2025 at 11:44:52AM +0100, Oleksij Rempel wrote: > On Mon, Oct 27, 2025 at 10:34:35AM +0000, Russell King (Oracle) wrote: > > On Mon, Oct 27, 2025 at 12:31:07PM +0200, Laurent Pinchart wrote: > > > On Mon, Oct 27, 2025 at 11:23:03AM +0100, Oleksij Rempel wrote: > > > > On Mon, Oct 27, 2025 at 12:02:27PM +0200, Laurent Pinchart wrote: > > > > > Hi Oleksij, > > > > > > Please note, RTL8211E PHY do use undocumented SmartEEE mode by default. > > > > > > It ignores RGMII LPI opcodes and doing own thing. It can be confirmed by > > > > > > monitoring RGMII TX and MDI lines with oscilloscope and changing > > > > > > tx-timer configurations. I also confirmed this information from other > > > > > > source. To disable SmartEEE and use plain MAC based mode, NDA documentation > > > > > > is needed. > > > > > > > > > > That's useful information, thank you. Would you by any chance to know if > > > > > such NDA would allow contributing the feature upstream ? > > > > > > > > Good question, but the NDA process was actually aborted. We didn't move > > > > forward due to a lack of time and ultimately, a lack of commercial > > > > interest from any projects or customers for this PHY. > > > > > > Fair enough. I've tried :-) > > > > > > If we can't disable SmartEEE in the PHY, does it mean we need to somehow > > > disable EEE in the MAC, but still program the PHY to advertise EEE to > > > the link partner ? > > > > Or maybe the PHY needs to have EEE capability disabled? > > Ack. With comment in the code, why we prefer this way, in case some one > wont to spend time on making it work. Probably SmartEEE or some other > word should be used. So we have options. However, we need to get to the bottom of what caused the change of behaviour before we start throwing solutions at this. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!