From: Shawn Guo <shawnguo2@yeah.net>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com,
Michael Trimarchi <michael@amarulasolutions.com>,
Conor Dooley <conor+dt@kernel.org>,
Fabio Estevam <festevam@gmail.com>, Frank Li <Frank.Li@nxp.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Peng Fan <peng.fan@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Rob Herring <robh@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: imx6ull-engicam-microgea-rmm: fix report-rate-hz value
Date: Mon, 20 Oct 2025 20:00:37 +0800 [thread overview]
Message-ID: <aPYkZXCtXyYYprp6@dragon> (raw)
In-Reply-To: <20250913091638.1003563-1-dario.binacchi@amarulasolutions.com>
On Sat, Sep 13, 2025 at 11:16:31AM +0200, Dario Binacchi wrote:
> The 'report-rate-hz' property for the edt-ft5x06 driver was added and
> handled in the Linux kernel by me with patches [1] and [2] for this
> specific board.
>
> The v1 upstream version, which was the one applied to the customer's
> kernel, used the 'report-rate' property, which was written directly to
> the controller register. During review, the 'hz' suffix was added,
> changing its handling so that writing the value directly to the register
> was no longer possible for the M06 controller.
>
> Once the patches were accepted in mainline, I did not reapply them to
> the customer's kernel, and when upstreaming the DTS for this board, I
> forgot to correct the 'report-rate-hz' property value.
>
> The property must be set to 60 because this board uses the M06 controller,
> which expects the report rate in units of 10 Hz, meaning the actual value
> written to the register is 6.
>
> [1] 625f829586ea ("dt-bindings: input: touchscreen: edt-ft5x06: add report-rate-hz")
> [2] 5bcee83a406c ("Input: edt-ft5x06 - set report rate by dts property")
> Fixes: ffea3cac94ba ("ARM: dts: imx6ul: support Engicam MicroGEA RMM board")
> Co-developed-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Applied, thanks!
prev parent reply other threads:[~2025-10-20 12:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-13 9:16 [PATCH] ARM: dts: imx6ull-engicam-microgea-rmm: fix report-rate-hz value Dario Binacchi
2025-10-20 12:00 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPYkZXCtXyYYprp6@dragon \
--to=shawnguo2@yeah.net \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@amarulasolutions.com \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox