From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 2/6] net: phy: add phy_may_wakeup()
Date: Wed, 22 Oct 2025 19:20:42 +0100 [thread overview]
Message-ID: <aPkgeuOAX98aT-T7@shell.armlinux.org.uk> (raw)
In-Reply-To: <ad16837d-6a30-4b3d-ab9a-99e31523867f@bootlin.com>
On Wed, Oct 22, 2025 at 03:43:20PM +0200, Maxime Chevallier wrote:
> Hi Russell,
>
> That's not exactly what's happening, this suggest this is merely a
> wrapper around device_may_wakeup().
>
> I don't think it's worth blocking the series though, but if you need to
> respin maybe this could be reworded.
>
> Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
I've updated the description as I think patch 4 needs a repost:
+/**
+ * phy_may_wakeup() - indicate whether PHY has wakeup enabled
+ * @phydev: The phy_device struct
+ *
+ * Returns: true/false depending on the PHY driver's device_set_wakeup_enabled()
+ * setting if using the driver model, otherwise the legacy determination.
+ */
+bool phy_may_wakeup(struct phy_device *phydev);
+
Do you want me to still add your r-b?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-10-22 18:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 12:03 [PATCH net-next 0/6] net: add phylink managed WoL and convert stmmac Russell King (Oracle)
2025-10-17 12:04 ` [PATCH net-next 1/6] net: phy: add phy_can_wakeup() Russell King (Oracle)
2025-10-22 13:34 ` Maxime Chevallier
2025-10-22 18:13 ` Florian Fainelli
2025-10-17 12:04 ` [PATCH net-next 2/6] net: phy: add phy_may_wakeup() Russell King (Oracle)
2025-10-22 13:43 ` Maxime Chevallier
2025-10-22 18:20 ` Russell King (Oracle) [this message]
2025-10-22 18:31 ` Florian Fainelli
2025-10-23 7:19 ` Maxime Chevallier
2025-10-22 18:14 ` Florian Fainelli
2025-10-22 18:21 ` Russell King (Oracle)
2025-10-17 12:04 ` [PATCH net-next 3/6] net: phylink: add phylink managed MAC Wake-on-Lan support Russell King (Oracle)
2025-10-22 14:06 ` Maxime Chevallier
2025-10-22 18:23 ` Russell King (Oracle)
2025-10-22 18:15 ` Florian Fainelli
2025-10-17 12:04 ` [PATCH net-next 4/6] net: phylink: add phylink managed wake-on-lan PHY speed control Russell King (Oracle)
2025-10-22 14:28 ` Maxime Chevallier
2025-10-22 18:11 ` Russell King (Oracle)
2025-10-17 12:05 ` [PATCH net-next 5/6] net: stmmac: convert to phylink-managed Wake-on-Lan Russell King (Oracle)
2025-10-17 12:05 ` [PATCH net-next 6/6] net: stmmac: convert to phylink managed WoL PHY speed Russell King (Oracle)
2025-10-21 8:02 ` [PATCH net-next 0/6] net: add phylink managed WoL and convert stmmac Gatien CHEVALLIER
2025-10-22 6:18 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPkgeuOAX98aT-T7@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).