From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32706CCD1BE for ; Thu, 23 Oct 2025 11:36:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VfAkBSZjrsHZonehvAcNmXjZ3DdxQ63w8ygnP3usUcg=; b=jbwqG6EqYFdVhmlA6qF9aRmyRp Dl3PgxBNJTnO2T0YNCHPh3Nfav+pjj4rmt+T8zXqnzqCvYhQKtbf3iOWIX4WJKDH6i6Mq1DsbN0ZV Z+Og07bjObkocb5Umql4gKKzv5WlExyI+oRrlHf5zKr/Kf+z23lv65dwkbo7nF6KynLGKJwwzscYf c7SNuojWYwfLDGoAOGwl0C+IvA30le4Bclx1VGB8ijA64/R4ys5DrmRLIGMqWtCLAGr4b/iTGLClO s+y8W5nT3j9ncrXXjuke8ef6BN+oS1sk1CMrBF6HrPm6bxlRwetnEvTPAMvo1Rrv4fpmlJ0eHIm+m yEpj1mow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vBtcd-000000066Rz-0E2Z; Thu, 23 Oct 2025 11:36:47 +0000 Received: from mgamail.intel.com ([192.198.163.12]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vBtcb-000000066RQ-0UK5; Thu, 23 Oct 2025 11:36:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1761219405; x=1792755405; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=f2YqjnkzS7XblEQQzbQJuEEnfM++QTqRRHZndsLcws0=; b=JUWeC6VVYEx9Wq015Gsh0I9Yvw7yFR4f7NVZmmvgA/yBgRLBuhJccd9B +6Er2+iuSpFXk/Xx0elrg3tTKO5nuQpOtfkuX8nVVis3gI6eFViI0HeZk m2EOrJI9rTEWskiiixUrYf2Rb5ZL2JJtgFv5pkiuFEameFNZWM8CtmzHr upZMZARTulkz8TL3ARmqxKffvqLwxk3gOVVl98RIuLMItauZsQdKmLEOp U2tpkYo43WlQnuCHuONX9fcW3XjjpUX3ApZoKoEAyWChJBJj+Gu5oQp7B CPqAbkD8AslI6lB0S5/PVwck8+H7p4Oy4ORD6AXZBIq5+DjH4TnWJuv0n g==; X-CSE-ConnectionGUID: aF2yE9ZyTBW4yGo6G5z+Dg== X-CSE-MsgGUID: rTfLsZeoTRyWkzS1FMPUng== X-IronPort-AV: E=McAfee;i="6800,10657,11586"; a="67252080" X-IronPort-AV: E=Sophos;i="6.19,249,1754982000"; d="scan'208";a="67252080" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2025 04:36:41 -0700 X-CSE-ConnectionGUID: 1TqIq3snTL+ZCxmH6TFP0g== X-CSE-MsgGUID: z60IloovRZGSCzaw8UIrVQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,249,1754982000"; d="scan'208";a="189267971" Received: from bkammerd-mobl.amr.corp.intel.com (HELO kuha.fi.intel.com) ([10.124.221.165]) by orviesa005.jf.intel.com with SMTP; 23 Oct 2025 04:36:31 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Thu, 23 Oct 2025 14:36:30 +0300 Date: Thu, 23 Oct 2025 14:36:30 +0300 From: Heikki Krogerus To: Chaoyi Chen Cc: Greg Kroah-Hartman , Dmitry Baryshkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v7 1/9] usb: typec: Add notifier functions Message-ID: References: <20251023033009.90-1-kernel@airkyi.com> <20251023033009.90-2-kernel@airkyi.com> <9c52db41-14f3-41a8-9423-3efe604361aa@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9c52db41-14f3-41a8-9423-3efe604361aa@rock-chips.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251023_043645_157577_7889147A X-CRM114-Status: GOOD ( 15.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Thank you for your detailed explanation. I noticed that there is a > device_register() action in typec_register_altmode(), so we can just take > advantage of this. > > Another thing is that we need to distinguish between different devices in the > notifier callback, as > typec_register_altmode()/typec_register_partner()/typec_register_plug()/typec_register_cable() > may all register devices. Since the data passed in bus_notify() is struct > device *dev, I think we can distinguish them through `dev->type.name`? We may > already have such names, "typec_alternate_mode", "typec_partner", "typec_plug" > in class.c . And then extract these names as macros and put them in the typec > header file. You don't need to worry about that. Only partner altmodes are bind to the bus. The device you see in the notifier will always be an altmode. But in general, if you need to identify the device type, then you use the device type itself, not the name of the type. It would require that the device types are exported, but as said, you don't need to worry about that in this case. thanks, -- heikki