From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 504C3CCFA13 for ; Sat, 8 Nov 2025 12:34:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nk056+VqDxXZufOchJymjHokNfL2GTVQtNNzkKkmAMs=; b=UL0nQsFd4aTV6W33I8Dkmu7Y41 m7tOUlwfOg0WikOz4hF/8OJzTJex/2yNBkh08J7pVb0bM4ZruuQ6GzWPX4E3rbxPdBpEyz4CcrdLl AHeucDCUYub0ch7hhhOtc7rEylbyx1R6oGD79PvSNfG10WlWu2BJl+EiPvCDaIkOBAFtqZ+/8fnWz NlB5thA6sX7wLqfKLrXXOwPw3l8vrmq/ixf6KTWoW3JPT3uX+RfCz4rUK4rUypO/9qp+5HNCzjGY8 oJhbEWqUF5JTxwN57CoVrIDD7HAWalc49PAmvKgGOU5oSZuVB4TrSitknGd8rPmmkbzpjj1ZDvfx7 lV18HrKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vHi9P-000000037T2-0b6R; Sat, 08 Nov 2025 12:34:39 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vHi9L-000000037Sc-25Jl; Sat, 08 Nov 2025 12:34:37 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 5998F4341D; Sat, 8 Nov 2025 12:34:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A579C116C6; Sat, 8 Nov 2025 12:34:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762605272; bh=45EdQFA6NEw7zfaldijyvwunk1IEh60CWkYy3zjQTj8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZAe1C6aBQOu9ufMPYHKXtgVkRMFWTkasSqsDrHkF2pcnXXL2tKM478Rl/JOtw1fuA bD0mol7BLa/ILSTZ5qVjy6diwgDi24ZKHJyysi3Pl5wz4IzIy0Uraf3VwDMLdaRgpr AWFZCkK0vdShLRvi2D8ey+7byiPq9+7NaXIlNkITumuldt2OcQXRNyedOpLm9lBHrg P7bITn3re31Mn5YZ6PGiwnoBGL/jeNK1YeK2+0lMuOIvQ0Qu8Mxs3ThqN3blG22LJ+ 2wCof2QQuNkXYclObVKA0Mu34jcLNBvldL7On6QA5fE0MaWJAwAseZZHR3Ks29JLiX 8O1QW3z1i8/kQ== Date: Sat, 8 Nov 2025 13:34:26 +0100 From: Niklas Cassel To: Shawn Lin Cc: FUKAUMI Naoki , Damien Le Moal , Anand Moon , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Dragan Simic , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner Subject: Re: [PATCH] PCI: dw-rockchip: Skip waiting for link up Message-ID: References: <20250113-rockchip-no-wait-v1-1-25417f37b92f@kernel.org> <1E8E4DB773970CB5+5a52c9e1-01b8-4872-99b7-021099f04031@radxa.com> <6e87b611-13ea-4d89-8dbf-85510dd86fa6@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6e87b611-13ea-4d89-8dbf-85510dd86fa6@rock-chips.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251108_043435_752208_07B09E62 X-CRM114-Status: GOOD ( 21.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Shawn, On Tue, Oct 21, 2025 at 03:10:13PM +0800, Shawn Lin wrote: > 在 2025/10/21 星期二 12:26, FUKAUMI Naoki 写道: > > Hi Niklas, Bjorn, > > > > I noticed an issue on the Rockchip RK3588S SoC using the ASMedia ASM2806 > > PCIe bridge where devices behind the bridge fail to probe since v6.14. > > Specifically, this started happening after commit > > 647d69605c70368d54fc012fce8a43e8e5955b04. > > dmesg logs from before and after this commit are available at: > >  https://gist.github.com/RadxaNaoki/fca2bfca2ee80fefee7b00c7967d2e3d > > > > I have confirmed that reverting the following commits fixes the issue: > >  commit ec9fd499b9c6 ("PCI: dw-rockchip: Don't wait for link since we > > can detect Link Up") > >  commit 0e0b45ab5d77 ("PCI: dw-rockchip: Enumerate endpoints based on > > dll_link_up IRQ") > > > > Then these two commits would like to reply on link up irq instead of > fixed delay in dwc framework. Here is a not very precise timeline > description. > > time(ms) | dw_pcie_wait_for_link（） | sys irq_thread() | Hot reset > ------------------------------------------------------------------------- > 0: | dw_pcie_link_up return false | link up irq | > 1x | Physical link up happend | | > 90: | dw_pcie_link_up return true | | > 100: | | msleep(100) done| > 10x: | | pci_rescan_bus | > 1xx: | | | <==occur > 190: | msleep(90) done | | > 19x: | pci_host_probe | | > > What if the hot reset happens when pci_rescan_bus() starts. I think > scan devices possible fail when seeing 0xffffffff from cfg read. But > a 90ms delay perfectly avoids this event in dw_pcie_wait_for_link(), and by > the time the 90ms delay is completed, the link is actually in an > accessible state. The pcie-dw-rockchip.c driver is modelled after the qcom driver. So if this is a problem when a ASM2806 switch is connected, I would expect qcom platforms to have the same problem. Do we have a PCI trace that can tell us exactly what goes wrong? FUKAUMI-san tells us that the enumeration does not detect any devices, but also that there is no crash. If we assume the scenario from your timeline above, that a hot reset happens just after pci_rescan_bus(), after a hot reset, LTSSM should re-enter link training. I verified this: # bc=$(setpci -s 0000:00:00.0 BRIDGE_CONTROL) # setpci -s 0000:00:00.0 BRIDGE_CONTROL=$(printf "%04x" $((0x$bc | 0x40))) && sl eep 0.01 && setpci -s 0000:00:00.0 BRIDGE_CONTROL=$bc [ 65.723990] rockchip-dw-pcie a40000000.pcie: PCIE_CLIENT_INTR_STATUS_MISC: 0x7 [ 65.724701] rockchip-dw-pcie a40000000.pcie: LTSSM_STATUS: 0x30011 [ 65.825787] rockchip-dw-pcie a40000000.pcie: Received Link up event. Starting enumeration! So we get another link up IRQ after the hot reset. The IRQ handler for this IRQ will once again call pci_rescan_bus(). So I would expect that this second pci_rescan_bus() call would actually be able to find the device behind the switch. Mani, Bjorn, thoughts? Kind regards, Niklas