public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Kees Cook <kees@kernel.org>, Mika Westerberg <westeri@kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Saravana Kannan <saravanak@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andy Shevchenko <andy@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Srinivas Kandagatla <srini@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	Alexey Klimov <alexey.klimov@linaro.org>,
	linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v3 10/10] regulator: make the subsystem aware of shared GPIOs
Date: Wed, 29 Oct 2025 17:21:27 +0200	[thread overview]
Message-ID: <aQIw97qdO43NXHWi@smile.fi.intel.com> (raw)
In-Reply-To: <CAMRc=McT+HinKvajHmBYPcQKoboapAf2E3ErJSP=2jXW9B0omA@mail.gmail.com>

On Wed, Oct 29, 2025 at 01:41:10PM +0100, Bartosz Golaszewski wrote:
> On Wed, Oct 29, 2025 at 12:54 PM Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> > On Wed, Oct 29, 2025 at 12:20:46PM +0100, Bartosz Golaszewski wrote:
> > >
> > > GPIOLIB is now aware of shared GPIOs and - for platforms where access to
> > > such pins is managed internally - we don't need to keep track of the
> > > enable count.
> > >
> > > Once all users in the kernel switch to using the new mechanism, we'll be
> > > able to drop the internal counting of users from the regulator code.
> >
> > I am wondering if you took into account the layering violation (or others
> > put it as "transferring of ownership") in the regulator core for the platform
> > based GPIO regulators? This popped up during the discussion of
> > https://lore.kernel.org/platform-driver-x86/20251024050537.92440-1-qiuwenbo@gnome.org/
> 
> I am aware of this weird ownership transfer in regulator but these
> changes don't affect it. The layering is still being violated though.
> 
> This should be fixed and I've looked into it but it's not trivial so
> it's another big rework for the future.

OK, thanks for clarifications!

-- 
With Best Regards,
Andy Shevchenko




  reply	other threads:[~2025-10-29 15:21 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-29 11:20 [PATCH v3 00/10] gpio: improve support for shared GPIOs Bartosz Golaszewski
2025-10-29 11:20 ` [PATCH v3 01/10] string: provide strends() Bartosz Golaszewski
2025-10-29 11:41   ` Andy Shevchenko
2025-10-29 12:36     ` Bartosz Golaszewski
2025-10-29 15:20       ` Andy Shevchenko
2025-10-29 11:20 ` [PATCH v3 02/10] gpiolib: define GPIOD_FLAG_SHARED Bartosz Golaszewski
2025-11-11 10:39   ` Linus Walleij
2025-10-29 11:20 ` [PATCH v3 03/10] gpiolib: implement low-level, shared GPIO support Bartosz Golaszewski
2025-10-29 11:44   ` Andy Shevchenko
2025-10-29 12:39     ` Bartosz Golaszewski
2025-10-29 15:18       ` Andy Shevchenko
2025-10-29 15:57         ` Bartosz Golaszewski
2025-10-30  9:30           ` Andy Shevchenko
2025-11-11 10:41   ` Linus Walleij
2025-10-29 11:20 ` [PATCH v3 04/10] gpio: shared-proxy: implement the shared GPIO proxy driver Bartosz Golaszewski
2025-11-11 10:43   ` Linus Walleij
2025-10-29 11:20 ` [PATCH v3 05/10] gpiolib: support shared GPIOs in core subsystem code Bartosz Golaszewski
2025-11-11 10:43   ` Linus Walleij
2025-10-29 11:20 ` [PATCH v3 06/10] gpio: provide gpiod_is_shared() Bartosz Golaszewski
2025-10-29 11:20 ` [PATCH v3 07/10] arm64: select HAVE_SHARED_GPIOS for ARCH_QCOM Bartosz Golaszewski
2025-10-29 11:20 ` [PATCH v3 08/10] ASoC: wsa881x: drop GPIOD_FLAGS_BIT_NONEXCLUSIVE flag from GPIO lookup Bartosz Golaszewski
2025-10-29 11:20 ` [PATCH v3 09/10] ASoC: wsa883x: " Bartosz Golaszewski
2025-10-29 11:20 ` [PATCH v3 10/10] regulator: make the subsystem aware of shared GPIOs Bartosz Golaszewski
2025-10-29 11:54   ` Andy Shevchenko
2025-10-29 12:41     ` Bartosz Golaszewski
2025-10-29 15:21       ` Andy Shevchenko [this message]
2025-11-10  9:45 ` [PATCH v3 00/10] gpio: improve support for " Bartosz Golaszewski
2025-11-11 10:46   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aQIw97qdO43NXHWi@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexey.klimov@linaro.org \
    --cc=andy@kernel.org \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kees@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=saravanak@google.com \
    --cc=srini@kernel.org \
    --cc=tiwai@suse.com \
    --cc=westeri@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox