Re: [PATCH v3 6/8] reset: imx8mp-audiomix: Extend the driver usage

Frank Li
2025-10-29T16:42:59Z

On Wed, Oct 29, 2025 at 06:52:27AM -0700, Laurentiu Mihalcea wrote:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>
> Replace the previous approach, in which a single reset map is used, by a
> per-driver approach, in which each auxiliary device driver holds a
> reference to a certain reset map.

Needn't "Replace the previous approach".

Replace single reset map with per-device reset map to allow the driver to
be reused for other NXP block.

>
> This change is needed to allow the driver to be reused for other NXP block
> control IPs such as i.MX8ULP's SIM LPAV.

avoid use words "this change[patch]"

Frank
>
> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> ---
> drivers/reset/reset-imx8mp-audiomix.c | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-imx8mp-audiomix.c
> index 3f6d11270918..5ee5a32c6950 100644
> --- a/drivers/reset/reset-imx8mp-audiomix.c
> +++ b/drivers/reset/reset-imx8mp-audiomix.c
> @@ -23,7 +23,12 @@ struct imx8mp_reset_map {
> bool active_low;
> };
>
> -static const struct imx8mp_reset_map reset_map[] = {
> +struct imx8mp_reset_info {
> + const struct imx8mp_reset_map *map;
> + int num_lines;
> +};
> +
> +static const struct imx8mp_reset_map imx8mp_reset_map[] = {
> [IMX8MP_AUDIOMIX_EARC_RESET] = {
> .offset = IMX8MP_AUDIOMIX_EARC_RESET_OFFSET,
> .mask = BIT(0),
> @@ -41,10 +46,16 @@ static const struct imx8mp_reset_map reset_map[] = {
> },
> };
>
> +static const struct imx8mp_reset_info imx8mp_reset_info = {
> + .map = imx8mp_reset_map,
> + .num_lines = ARRAY_SIZE(imx8mp_reset_map),
> +};
> +
> struct imx8mp_audiomix_reset {
> struct reset_controller_dev rcdev;
> void __iomem *base;
> struct regmap *regmap;
> + const struct imx8mp_reset_info *rinfo;
> };
>
> static struct imx8mp_audiomix_reset *to_imx8mp_audiomix_reset(struct reset_controller_dev *rcdev)
> @@ -56,6 +67,7 @@ static int imx8mp_audiomix_update(struct reset_controller_dev *rcdev,
> unsigned long id, bool assert)
> {
> struct imx8mp_audiomix_reset *priv = to_imx8mp_audiomix_reset(rcdev);
> + const struct imx8mp_reset_map *reset_map = priv->rinfo->map;
> unsigned int mask, offset, active_low, shift, val;
>
> mask = reset_map[id].mask;
> @@ -140,7 +152,8 @@ static int imx8mp_audiomix_reset_probe(struct auxiliary_device *adev,
> return -ENOMEM;
>
> priv->rcdev.owner = THIS_MODULE;
> - priv->rcdev.nr_resets = ARRAY_SIZE(reset_map);
> + priv->rinfo = (void *)id->driver_data;
> + priv->rcdev.nr_resets = priv->rinfo->num_lines;
> priv->rcdev.ops = &imx8mp_audiomix_reset_ops;
> priv->rcdev.of_node = dev->parent->of_node;
> priv->rcdev.dev = dev;
> @@ -164,6 +177,7 @@ static int imx8mp_audiomix_reset_probe(struct auxiliary_device *adev,
> static const struct auxiliary_device_id imx8mp_audiomix_reset_ids[] = {
> {
> .name = "clk_imx8mp_audiomix.reset",
> + .driver_data = (kernel_ulong_t)&imx8mp_reset_info,
> },
> { }
> };
> --
> 2.43.0
>