Re: [PATCH v3 7/8] reset: imx8mp-audiomix: Support i.MX8ULP SIM LPAV

Frank Li
2025-10-29T16:44:06Z

On Wed, Oct 29, 2025 at 06:52:28AM -0700, Laurentiu Mihalcea wrote:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>
> Support i.MX8ULP's SIM LPAV by adding its reset map definition.
>
> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> ---
> drivers/reset/reset-imx8mp-audiomix.c | 45 +++++++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
> diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-imx8mp-audiomix.c
> index 5ee5a32c6950..4e420c6b8fdc 100644
> --- a/drivers/reset/reset-imx8mp-audiomix.c
> +++ b/drivers/reset/reset-imx8mp-audiomix.c
> @@ -3,6 +3,7 @@
> * Copyright 2024 NXP
> */
>
> +#include <dt-bindings/reset/fsl,imx8ulp-sim-lpav.h>
> #include <dt-bindings/reset/imx8mp-reset-audiomix.h>
>
> #include <linux/auxiliary_bus.h>
> @@ -17,6 +18,8 @@
> #define IMX8MP_AUDIOMIX_EARC_RESET_OFFSET 0x200
> #define IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET 0x108
>
> +#define IMX8ULP_SIM_LPAV_SYSCTRL0_OFFSET 0x8
> +
> struct imx8mp_reset_map {
> unsigned int offset;
> unsigned int mask;
> @@ -51,6 +54,44 @@ static const struct imx8mp_reset_info imx8mp_reset_info = {
> .num_lines = ARRAY_SIZE(imx8mp_reset_map),
> };
>
> +static const struct imx8mp_reset_map imx8ulp_reset_map[] = {
> + [IMX8ULP_SIM_LPAV_HIFI4_DSP_DBG_RST] = {
> + .offset = IMX8ULP_SIM_LPAV_SYSCTRL0_OFFSET,
> + .mask = BIT(25),
> + .active_low = false,
> + },
> + [IMX8ULP_SIM_LPAV_HIFI4_DSP_RST] = {
> + .offset = IMX8ULP_SIM_LPAV_SYSCTRL0_OFFSET,
> + .mask = BIT(16),
> + .active_low = false,
> + },
> + [IMX8ULP_SIM_LPAV_HIFI4_DSP_STALL] = {
> + .offset = IMX8ULP_SIM_LPAV_SYSCTRL0_OFFSET,
> + .mask = BIT(13),
> + .active_low = false,
> + },
> + [IMX8ULP_SIM_LPAV_DSI_RST_BYTE_N] = {
> + .offset = IMX8ULP_SIM_LPAV_SYSCTRL0_OFFSET,
> + .mask = BIT(5),
> + .active_low = true,
> + },
> + [IMX8ULP_SIM_LPAV_DSI_RST_ESC_N] = {
> + .offset = IMX8ULP_SIM_LPAV_SYSCTRL0_OFFSET,
> + .mask = BIT(4),
> + .active_low = true,
> + },
> + [IMX8ULP_SIM_LPAV_DSI_RST_DPI_N] = {
> + .offset = IMX8ULP_SIM_LPAV_SYSCTRL0_OFFSET,
> + .mask = BIT(3),
> + .active_low = true,
> + },
> +};
> +
> +static const struct imx8mp_reset_info imx8ulp_reset_info = {
> + .map = imx8ulp_reset_map,
> + .num_lines = ARRAY_SIZE(imx8ulp_reset_map),
> +};
> +
> struct imx8mp_audiomix_reset {
> struct reset_controller_dev rcdev;
> void __iomem *base;
> @@ -179,6 +220,10 @@ static const struct auxiliary_device_id imx8mp_audiomix_reset_ids[] = {
> .name = "clk_imx8mp_audiomix.reset",
> .driver_data = (kernel_ulong_t)&imx8mp_reset_info,
> },
> + {
> + .name = "clk_imx8ulp_sim_lpav.reset",
> + .driver_data = (kernel_ulong_t)&imx8ulp_reset_info,
> + },
> { }
> };
> MODULE_DEVICE_TABLE(auxiliary, imx8mp_audiomix_reset_ids);
> --
> 2.43.0
>