From: Will Deacon <will@kernel.org>
To: Punit Agrawal <punit.agrawal@oss.qualcomm.com>
Cc: catalin.marinas@arm.com, guohanjun@huawei.com,
chenl311@chinatelecom.cn, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: acpi: Fix incorrect check for default console message
Date: Thu, 30 Oct 2025 14:21:21 +0000 [thread overview]
Message-ID: <aQN0YWUYaPYWpgJM@willie-the-truck> (raw)
In-Reply-To: <20251027141941.3089914-1-punit.agrawal@oss.qualcomm.com>
On Mon, Oct 27, 2025 at 02:19:41PM +0000, Punit Agrawal wrote:
> bad3fa2fb920 ("ACPI: Suppress misleading SPCR console message when
> SPCR table is absent") mistakenly assumes acpi_parse_spcr() returning
> 0 to indicate a failure to parse SPCR and prints a message to the
> kernel logs accordingly. In reality acpi_parse_spcr() returns 0 on
> success and -ERRNO on failure.
>
> Fix the faulty check to output the correct logging message.
>
> Fixes: bad3fa2fb920 ("ACPI: Suppress misleading SPCR console message when SPCR table is absent")
> Signed-off-by: Punit Agrawal <punit.agrawal@oss.qualcomm.com>
> ---
> Hi,
>
> After sending a patch to fix incorrect parsing of SPCR[0], I was still
> seeing inconsistent logging on arm64. The result is this nugget.
>
> Considering the pointless churn - I wondered if it isn't better to
> drop the message? If others agree, I can send a patch (and revert
> bad3fa2fb920 while at it).
I'd be happy dropping the message as it looks pretty useless to me,
especially given that the current logic is broken.
Will
next prev parent reply other threads:[~2025-10-30 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 14:19 [PATCH] arm64: acpi: Fix incorrect check for default console message Punit Agrawal
2025-10-30 14:21 ` Will Deacon [this message]
2025-11-21 2:40 ` Hanjun Guo
2025-11-21 13:44 ` Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQN0YWUYaPYWpgJM@willie-the-truck \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=chenl311@chinatelecom.cn \
--cc=guohanjun@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=punit.agrawal@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox