From: Andrea della Porta <andrea.porta@suse.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Andrea della Porta <andrea.porta@suse.com>,
Andrew Lunn <andrew@lunn.ch>, Conor Dooley <conor+dt@kernel.org>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
"Ivan T. Ivanov" <iivanov@suse.de>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Phil Elwell <phil@raspberrypi.com>, Rob Herring <robh@kernel.org>,
Stanimir Varbanov <svarbanov@suse.de>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v2] arm64: dts: broadcom: bcm2712: rpi-5: Add ethernet0 alias
Date: Mon, 3 Nov 2025 10:29:10 +0100 [thread overview]
Message-ID: <aQh15uaWYYHCaSTb@apocalypse> (raw)
In-Reply-To: <20251102111443.18206-1-laurent.pinchart@ideasonboard.com>
Hi Laurent,
On 13:14 Sun 02 Nov , Laurent Pinchart wrote:
> The RP1 ethernet controller DT node contains a local-mac-address
> property to pass the MAC address from the boot loader to the kernel. The
> boot loader does not fill the MAC address as the ethernet0 alias is
> missing. Add it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v1:
>
> - Moved the alias to bcm2712-rpi-5-b.dts
> ---
> arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts
> index 09a849dd09b1..3e0319fdb93f 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts
> +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts
> @@ -18,6 +18,12 @@
>
> #include "bcm2712-rpi-5-b-ovl-rp1.dts"
>
> +/ {
> + aliases {
> + ethernet0 = &rp1_eth;
> + };
> +};
> +
> &pcie2 {
> #include "rp1-nexus.dtsi"
> };
LGTM,
Reviewed-by: Andrea della Porta <andrea.porta@suse.com>
Many thanks,
Andrea
>
> base-commit: dcb6fa37fd7bc9c3d2b066329b0d27dedf8becaa
> --
> Regards,
>
> Laurent Pinchart
>
next prev parent reply other threads:[~2025-11-03 9:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-02 11:14 [PATCH v2] arm64: dts: broadcom: bcm2712: rpi-5: Add ethernet0 alias Laurent Pinchart
2025-11-02 15:35 ` Andrew Lunn
2025-11-02 15:48 ` Laurent Pinchart
2025-11-02 16:16 ` Florian Fainelli
2025-11-03 9:29 ` Andrea della Porta [this message]
2025-11-03 16:57 ` Florian Fainelli
2025-12-11 18:42 ` Rob Herring
2025-12-12 2:37 ` Laurent Pinchart
2025-12-12 10:25 ` Andrea della Porta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQh15uaWYYHCaSTb@apocalypse \
--to=andrea.porta@suse.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=iivanov@suse.de \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=phil@raspberrypi.com \
--cc=robh@kernel.org \
--cc=svarbanov@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).