From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D84D4CCF9FE for ; Mon, 3 Nov 2025 07:34:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=V0m3sVl2ck4+Zey5odT1IPn1VaXPf5UOt9cSm4kUU/Q=; b=XDHLR3nQjnSOXCUUgHMFFLWONJ s7sQrX9b4mVXx8Telfpt1F5h11EewFF3eonsnktaskphz4U7TK0ZxJqd6ZEdpKJu459o1kbpddoHu hugoejKYcFGLzNIK2KH+/zWgdfCo61j7hbVYNac5IdEFk7g3ebdDGchPUg77+V2Dm5UufjTahjnjd lZ8Dl2aWeFyRYi7DhchiMXjx1leUiaxzm35UyA0o9Uz84GTtcP0JGJ14UMAcpqUEq8SB19wwtcHnx l7N0LteF5xlKeZ3MJ/KWhX6WyABulq0BT/6qIaCJV6sl6pF1Qd+fY+UsFIfGVy9wsTUFKyEPVFGqH tf2+xNJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vFp5G-00000009MoS-3ab3; Mon, 03 Nov 2025 07:34:34 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vFp5E-00000009Mnx-0jjJ for linux-arm-kernel@lists.infradead.org; Mon, 03 Nov 2025 07:34:33 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vFp4z-0001MA-7R; Mon, 03 Nov 2025 08:34:17 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vFp4x-006ouR-2B; Mon, 03 Nov 2025 08:34:15 +0100 Received: from sha by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1vFp4x-00GZkn-1n; Mon, 03 Nov 2025 08:34:15 +0100 Date: Mon, 3 Nov 2025 08:34:15 +0100 From: Sascha Hauer To: Bryan Brattlof Cc: Nishanth Menon , Vignesh Raghavendra , Andrew Davis , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Tony Lindgren , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v7 2/3] arm64: dts: ti: k3-am62l: add initial infrastructure Message-ID: References: <20251031-am62lx-v7-0-cb426be9d6ee@ti.com> <20251031-am62lx-v7-2-cb426be9d6ee@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251031-am62lx-v7-2-cb426be9d6ee@ti.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251102_233432_217720_F407981A X-CRM114-Status: GOOD ( 18.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 31, 2025 at 09:08:05AM -0500, Bryan Brattlof wrote: > + gpio0: gpio@600000 { > + compatible = "ti,am64-gpio", "ti,keystone-gpio"; > + reg = <0x00 0x00600000 0x00 0x100>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-parent = <&gic500>; > + interrupts = , > + , > + , > + , > + , > + , > + , > + ; > + interrupt-controller; > + #interrupt-cells = <2>; > + power-domains = <&scmi_pds 34>; > + clocks = <&scmi_clk 140>; > + clock-names = "gpio"; > + ti,ngpio = <126>; > + ti,davinci-gpio-unbanked = <0>; > + status = "disabled"; Virtually all boards use GPIOs and a GPIO controller doesn't have any external dependencies, so could you enable them by default like done on many other SoCs? > + > + target-module@2b300050 { > + compatible = "ti,sysc-omap2", "ti,sysc"; > + reg = <0x00 0x2b300050 0x00 0x4>, > + <0x00 0x2b300054 0x00 0x4>, > + <0x00 0x2b300058 0x00 0x4>; > + reg-names = "rev", "sysc", "syss"; > + ranges = <0x00 0x00 0x2b300000 0x100000>; > + #address-cells = <1>; > + #size-cells = <1>; > + power-domains = <&scmi_pds 83>; > + clocks = <&scmi_clk 324>; > + clock-names = "fck"; > + ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP | > + SYSC_OMAP2_SOFTRESET | > + SYSC_OMAP2_AUTOIDLE)>; > + ti,sysc-sidle = , > + , > + , > + ; > + ti,syss-mask = <1>; > + ti,no-reset-on-init; > + status = "disabled"; This node is present on many other TI SoCs, all I have looked at have this node enabled by default. I think it makes sense to have this node enabled given that it has child nodes like this UART: > + > + wkup_uart0: serial@0 { > + compatible = "ti,am64-uart", "ti,am654-uart"; > + reg = <0x00 0x100>; > + interrupts = ; > + clocks = <&scmi_clk 324>; > + assigned-clocks = <&scmi_clk 324>; > + clock-names = "fclk"; > + status = "disabled"; > + }; Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |