From: Johan Hovold <johan@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org, Frank Li <Frank.Li@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] media: imx8-isi: Drop unused module alias
Date: Tue, 4 Nov 2025 11:13:05 +0100 [thread overview]
Message-ID: <aQnRsVPq1ndQrLr_@hovoldconsulting.com> (raw)
In-Reply-To: <20251102234438.8022-1-laurent.pinchart@ideasonboard.com>
Hi Laurent,
On Mon, Nov 03, 2025 at 01:44:38AM +0200, Laurent Pinchart wrote:
> The driver has never supported anything but OF probing so drop the
> unused platform module alias.
The commit message needs some more work since this isn't a platform
module alias (i.e. has a "platform:" prefix), and judging from a quick
look it seems like the driver did support platform probing before commit
605b57c4e888 ("media: nxp: imx8-isi: Drop partial support for i.MX8QM
and i.MX8QXP"), at least in theory.
It's probably fine to remove the "ISI" alias, but it should not affect
module autoloading.
> Suggested-by: Johan Hovold <johan@kernel.org>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Johan, I've got the idea from similar patches you submitted for other
> NXP media drivers, hence the Suggested-by tag. Please let me know if I
> can keep it.
Sure, please do.
> -MODULE_ALIAS("ISI");
Johan
next prev parent reply other threads:[~2025-11-04 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-02 23:44 [PATCH] media: imx8-isi: Drop unused module alias Laurent Pinchart
2025-11-03 15:11 ` Frank Li
2025-11-04 10:13 ` Johan Hovold [this message]
2025-11-04 14:36 ` Laurent Pinchart
2025-11-04 14:45 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQnRsVPq1ndQrLr_@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox