From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE60CCCFA04 for ; Tue, 4 Nov 2025 12:30:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=idf6TGuG776FXuqAZf7DcuUko1yPAW/KVXySw9Pv3mw=; b=yodxXPOpmicUHIx352gMlKJ4Rt 2R1MbbQzvdZGPFr0Ee/vo9thcToslfMZmFITncLmmS5VrIHUeN7+V3NhIQA031+fThLel5SvQrpcc qUSz7civAZRrNpjQpEP8Qws2fH3xHQJMrDSNdMPVeKnl287/7dy27HiHiY5AyQWss8IjC8TnvEfLd SfETnC37fDmt0LO+CbZ+o84hjjre29nidMtd/Vmr8Hi75U67WI+ysElUaSLPkOcCD0s4p+LoDUYrT vi1LbSDUw9a4fabjEbpAcfqS6fWQsLxG+hvr/jIEyzOj2zUej7LY5ipWe/7FP6J7Tk3Llyzf8CSJy XI5EmW0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vGGBJ-0000000Bmt8-2y38; Tue, 04 Nov 2025 12:30:37 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vGGBI-0000000Bmso-0T5x; Tue, 04 Nov 2025 12:30:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 88E71601EC; Tue, 4 Nov 2025 12:30:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CB33C4CEF7; Tue, 4 Nov 2025 12:30:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762259435; bh=FSpG5YsbzDPakXOv7zcHt6Bb8WRjzWGwnycLNiPNIws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fNaXCyHmH2JWtxXKdCRrOaKgCy6dFh9Tf8n9Pz4ygElOxC42vTsmmQLq2WOYqVDf3 I09YelFRLWNEihcMjgnwpphg6vjCR+vhwxYZJYU7IVSeB/sDkponxhJL9t7acnsGEJ UZm3rusrz7hj9+nE3dORF531A4gqGnZkyV6HrXn10qC1Gq1BEn4ZYaTUFgmkJRgLPc ROKurA28vLp4yqqifk/345Pbj2NKVLi5B+xNAQNkzuoXFKVuoskw90P31nO7p9N+s7 sku/hjVKyVt35LVarrN9ElmDsLdwcHd0/MOLiefy2+rgXkjtfc5f0n+n1LVbdlsX06 T2y7oUZS6kSGQ== Date: Tue, 4 Nov 2025 13:30:28 +0100 From: Niklas Cassel To: Manivannan Sadhasivam Cc: Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Shawn Lin , Kever Yang , Simon Xue , Damien Le Moal , Dragan Simic , FUKAUMI Naoki , Diederik de Haas , stable@vger.kernel.org, Manivannan Sadhasivam , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3] PCI: dw-rockchip: Prevent advertising L1 Substates support Message-ID: References: <20251017164558.GA1034609@bhelgaas> <54FD6159-AE45-432B-8F0E-4654721D16A6@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Mani, On Tue, Oct 21, 2025 at 08:02:01AM +0530, Manivannan Sadhasivam wrote: > On Sat, Oct 18, 2025 at 07:07:35AM +0200, Niklas Cassel wrote: > > On 17 October 2025 18:45:58 CEST, Bjorn Helgaas wrote: > > > > (snip) > > > > >> > > >> Thus, prevent advertising L1 Substates support until proper driver support > > >> is added. > > > > > >I think Mani is planning a change so we don't try to enable L1 > > >Substates by default, which should avoid the regression even without a > > >patch like this. > > > > Sounds good, I suggested the same: > > https://lore.kernel.org/linux-pci/aO9tWjgHnkATroNa@ryzen/ > > > > > > > > > >That will still leave the existing CONFIG_PCIEASPM_POWER_SUPERSAVE=y > > >and sysfs l1_1_aspm problems. > > > > Indeed, which is why I think that this patch is v6.18 material. > > > > Not strictly a 6.18 material as the Kconfig/sysfs/cmdline issues existed even > before we enabled the ASPM states by default in v6.18-rc1. I don't agree that "strictly 6.18 material" means "only fixes for bugs introduced in the 6.18 merge window". Normally, for a strict bug fix, the fix is merged during the current kernel release cycle (rather than waiting for the next merge window), even if the bug was introduced in an earlier kernel version. E.g. a fix for a bug introduced during the 6.17 release cycle is definitely 6.18 material, IMO. Sure, if the bug is extremely old, that probably means that it is okay to wait until the next merge window. In this case, the Fixes tag is a commit first introduced in kernel v5.15, released Sun Oct 31 13:53:10 2021. Having that said, I'm perfectly fine with delaying. Kind regards, Niklas