Re: [PATCH] media: imx8-isi: Drop unused module alias

Laurent Pinchart
2025-11-04T14:36:57Z

On Tue, Nov 04, 2025 at 11:13:05AM +0100, Johan Hovold wrote:
> On Mon, Nov 03, 2025 at 01:44:38AM +0200, Laurent Pinchart wrote:
> > The driver has never supported anything but OF probing so drop the
> > unused platform module alias.
>
> The commit message needs some more work since this isn't a platform
> module alias (i.e. has a "platform:" prefix),

Oops indeed.

> and judging from a quick
> look it seems like the driver did support platform probing before commit
> 605b57c4e888 ("media: nxp: imx8-isi: Drop partial support for i.MX8QM
> and i.MX8QXP"), at least in theory.

That has never been used upstream. It was code from the BSP that should
never have been imported in the first place, I missed removing it when I
rewrote the driver for upstreaming.

> It's probably fine to remove the "ISI" alias, but it should not affect
> module autoloading.

How about the following commit message ?

media: imx8-isi: Drop unneeded module alias

The imx8-isi driver has a module alias named "ISI". This is not
required, as there is no reason to load this module through an alias:
the device is probed through OF, and the module has never been named
"ISI". Drop the alias.

> > Suggested-by: Johan Hovold <johan@kernel.org>
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > Johan, I've got the idea from similar patches you submitted for other
> > NXP media drivers, hence the Suggested-by tag. Please let me know if I
> > can keep it.
>
> Sure, please do.
>
> > -MODULE_ALIAS("ISI");

--
Regards,

Laurent Pinchart