From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 448D3CCFA05 for ; Thu, 6 Nov 2025 16:08:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IbP1KearppWvvqn0sMoFf+o4oP7lZ12WSv+DIZyMOSE=; b=mKqdGk2UQBjwuWUuwk0i+1xRJX DcVynI/Utc1AxT5N/WzCrgmLhW3u5JKYl5iQopjukb1A5D8qXGqI5zKlD3pqeYox2ss/xklYnzeMM bEwl37ocyon3GC+NWbVZywg6P9R5dRVFrIortg4hTQ+f4jqCBgzQ46e53erdmFBCrrEx3YFXXKf74 1zu6cb1/WmVU89Vjb3lVSAkjqq/fTMSzvjsWk5XsiyguD1Z5A0JIbux+cJXgRkzRB8S9YqS+Pq1Mq Ri/puoKrQToC6mCYm4R+o3E20kiWAkRn9yr+r6NBVwTxdnr3jOzz97jfNQr043Zeg+2V/o8xi9jPX yP1wMAQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vH2X9-0000000FsLD-3p4b; Thu, 06 Nov 2025 16:08:23 +0000 Received: from mail-westeuropeazlp170110003.outbound.protection.outlook.com ([2a01:111:f403:c201::3] helo=AS8PR04CU009.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vH2X7-0000000FsKJ-3vtB for linux-arm-kernel@lists.infradead.org; Thu, 06 Nov 2025 16:08:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TyH+WtNFBJTQjiWWR8wzc0vHwOg++RWrk9jwngjXEkGCwe5mkvuhTHWzYyBW/W7cPb8j6A5cgo5l/p4BJFkQ5SeV82TIc1QIhU3gPEeeXy5B5VSeNtEfY3lxNXqRSB1qzvzLMtb/tot7TYFcymbOJv8lcfzTcXBbYPe/qL/IvJJMzHLGYjhZsGcCxlqTwacnna+EVNyDHy7vNx7f0cVzeBkY0UwHlXQAvkbBiEDND7/evkyoQawDkGP15doFYZ4L3DX6ASdjml7wNnFR+lc9V43lYvfD9cVs0uGGFAHTa63pyY31KWHp0rBCOAvo8iXKnCn9zOA0dmdSsmskMfu2LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IbP1KearppWvvqn0sMoFf+o4oP7lZ12WSv+DIZyMOSE=; b=AykKU1lUlIQ6Xu+7IWsWMZmwOmuOlBiMXuhYw29iPx9csIUb+EkDk3TBIMUwki4Rq+HRQSjfM8zDmPu7x+B7VehOniKk2VRDB5KmwMZN3xy0mkZ5pzawa+7+FVySdIj190c3UtctvDuUURXWH2HrC8H3AHbP/hsAGwFo0cVkv744JZxt9rerGC8zWjOzRmeMKH/AyZzOHsbZ1i+jMVntvf5SaEoRE7VbQE7vC5vUMBk/kGOcrnxa015v0wYCs0YeyHn3QncM2QgDlh2YfMf05F1W19dOgGV0L/ZfTiRJChI+8wVD67RZhS6zZhTdukGCXXL/A+sPA/ySzBA4GQ9iRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IbP1KearppWvvqn0sMoFf+o4oP7lZ12WSv+DIZyMOSE=; b=dXzqQtAkTJT7cCF7k4s88wdNQITPgYsDVFLYGO6InCQfoYQ5H5urKv8UTACt+GeJoS9XHpF7cVlb4DSO26pyuvXYSIbrdy3r3Z6I8eJoGAuOklsO6QksvRz2EjFGEaerxGW9wQmQ35TPGEIK04WddQAuLQfUMVZJ7Ylb94d2Z/vjtr8lS/TVmsw/8z9RVUpMECOP76eZOp/RwfFk1V8AMtd8HH0jqlgRaFE7au3oosrKER5ih6Evjdo/7IvlJJ6McieHd7ForgXFtMOD4BJbkRv6M/PJ7HcWIQnccd3B/Gn6vBtY3nRiX7gAVUaXsfgcRfkJctzYgzEKOJXfUOat+w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXSPRMB0053.eurprd04.prod.outlook.com (2603:10a6:102:23f::21) by VI1PR04MB9977.eurprd04.prod.outlook.com (2603:10a6:800:1d9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.12; Thu, 6 Nov 2025 16:08:16 +0000 Received: from PAXSPRMB0053.eurprd04.prod.outlook.com ([fe80::504f:2a06:4579:5f15]) by PAXSPRMB0053.eurprd04.prod.outlook.com ([fe80::504f:2a06:4579:5f15%6]) with mapi id 15.20.9298.006; Thu, 6 Nov 2025 16:08:16 +0000 Date: Thu, 6 Nov 2025 11:08:07 -0500 From: Frank Li To: Peng Fan Cc: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Daniel Baluta , Shengjiu Wang , Iuliana Prodan , linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/11] remoteproc: imx_dsp_rproc: Use dev_err_probe() for firmware and mode errors Message-ID: References: <20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com> <20251106-imx-dsp-2025-11-06-v1-4-46028bc3459a@nxp.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251106-imx-dsp-2025-11-06-v1-4-46028bc3459a@nxp.com> X-ClientProxiedBy: SJ0PR03CA0354.namprd03.prod.outlook.com (2603:10b6:a03:39c::29) To PAXSPRMB0053.eurprd04.prod.outlook.com (2603:10a6:102:23f::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXSPRMB0053:EE_|VI1PR04MB9977:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e7135c4-8959-4ff7-8955-08de1d4eb197 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|7416014|376014|19092799006|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?1y0svSTdlRPprHDIcIEs42ZetLisLWYGLSbbXRluWfmNF0adjvbdeW+Qs6pr?= =?us-ascii?Q?gZPzS3IhgDVtH7TJDFkdL28UpbB2iBdsQbvwUcOKSxsBccnyl/TjwIy3TL92?= =?us-ascii?Q?gRMZR3q48FvpXr31m92KfNvPNHdhGC16IwbROSbTHGrp/PjTEJtNIcQ2f2yR?= =?us-ascii?Q?hW6fK6ykX+ZRsIW0+zA+dLPG/DaZdLZjBWDASBBb5zv2pJP7iwMMjM+G9I0I?= =?us-ascii?Q?0ha8AZyx3s1x2lRxvDWgamm2+KP+CrtJVPsnsK7jVhAC+sEn4wQvFFKtoWO+?= =?us-ascii?Q?TzRs6NE60BY+xgF0j/YOXlcK0H0Cd7V+uYdL0Z7D0YD5F/Iq0vbhymDYlY3v?= =?us-ascii?Q?mB7NSdVjWVa19ZquuaeJg0nEI+2Qd865YDaAN5Sp++E2sUDNR2qiP5wFG0xX?= =?us-ascii?Q?V4xf20Dy2Qwtb0c2zhiKDGp5TUozjR7JG6yH9sp+UUmKhZOpDb2JOEK84xzd?= =?us-ascii?Q?gtJmNChusUzBHXWMG3bb63grFLZtJm9+WKQfuqfioqS7Zf+zOQsS/2T/PydN?= =?us-ascii?Q?aIm4imXxTOSCBAnC/XWtUEb8I5T5u14o4chnk61Wc99ykvqlbinEkF409BkZ?= =?us-ascii?Q?z5NxWwYQAG3d5Js8x2XqSrtLVoZNx2DAdPSON9+j0sF7UcBsilqsPOvo/SMC?= =?us-ascii?Q?iv/uVQXFVXpf1laU/BLyc5FsY6bdVbj0yXhIX7ZXo4IxLZwKGlb36VVUAojE?= =?us-ascii?Q?U48EXEqumUuT5bFwJzhpTO00j8/YFOb9Kh/Zx8qnOa3VrMTFdITKw9ky7Y2S?= =?us-ascii?Q?ppEhcKcv7szD8aDKXT8r+NWfjPOf6b2A5UDo+Nk+bimnGIV1ngIxhGqlxYnO?= =?us-ascii?Q?EaWDRqn+/u9/d7Cds8PaXf/aKcjpcRoHA3GGSz0sN44vwbCeI/XSmKYV4rpV?= =?us-ascii?Q?2qBX0qyxNkbrnPa5DzusZ9w4QyLzhU7S767Flh1FZoNwIekCKYnMikw9VWEs?= =?us-ascii?Q?cGNn9ybrNpauumNUSuUo66c7zgLXf8tMj98bI275auJ/p/xQOmXQxDKAYv/0?= =?us-ascii?Q?0LyCmsx1c2CLT4qp+dVxqRmiCEWdWeKo9ETl5zGWNhYh2SZeFWXFp3m0UMjr?= =?us-ascii?Q?ebwSTznpDAy/q7yy+5rIfnt9WeUKdQHFfGjwp8uRrDxxLiqIr8juu0hq3fHx?= =?us-ascii?Q?BwJC89SD4k2MuSNJvrcT0CuQzl6jjWHtpsWkROK3KSFhQWIZETym/tt2uCuy?= =?us-ascii?Q?TqPDapdi8PTSfL86CVkhkyNhyHzN4E6XzxQWBJFJhJmOBnz6ZxR702Hy7FAr?= =?us-ascii?Q?KceTw+L3el/+26FVEgcYZwJqrxcDFXR2porLvLL7E58YQuQqX08GCGpAh7rW?= =?us-ascii?Q?8SNCTMlKKXKy7YKU8H4jHg8SCt98dV+rIFfRmA0oVox59izQJ9sKPVsVQkul?= =?us-ascii?Q?F8LtKSdrWZesWquvjADM2iJlD7//2djupSxs7COKgruoymN+GQM2cnZewmyH?= =?us-ascii?Q?Oel8CLFT9NUamoTnxyQ4IpyVFXXviPhLRKZpP9xaSoYNBK4YdhpWCQk4lzZF?= =?us-ascii?Q?oOGgf4M0odJmBes2k0AMYLg3B5z/MPaJSr0M?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXSPRMB0053.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(7416014)(376014)(19092799006)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iFC3eKDeCClqboP8MUPQROHhZlT1onqx1pqoZWA7oB5vXKSzjEiMzmtNboRw?= =?us-ascii?Q?YwbuQC0PrKr6K+UsPdi6PRQC8MttwzaEu++9w1Zf5v2oIDJp6WNFTjp4kUTv?= =?us-ascii?Q?xtmfKHS3NuTusyouItQcJ+sQY/Ds0eL56LGYSalPzqsW+M3WHVL7xXRup12C?= =?us-ascii?Q?9i4y2tzQtmxCrjkX0reqZ1CkWhyPz4kNsCcL22UHwX6HnfqhLYY3ZxZOEaax?= =?us-ascii?Q?eDYW7M9VNDP8I5XaFIEWkKV8b89986aqbfhPw08UUsQLSXLADh8b3ig1zSsg?= =?us-ascii?Q?sVFL0KpT8yVhq+m+b0Npg3474AFcwBKM0Meey0G8/7sBomlkdH8UJIs5WA65?= =?us-ascii?Q?nFMAxXEke1BHesORGBPsZQlFKKQJJpLBAnAjY9KcCvwsL5m1xyx29FHkGR2x?= =?us-ascii?Q?oNg7BA703b/SCjOid+Hls4koCgYhE65gEpU3OJmqPsI0NOkANuhslYjL/BYR?= =?us-ascii?Q?DgZCF2+4gspjuAIVCINnph5oO4Bvhf2oqQ3Wce6NaOy5WzJyooCzZvJY3tnG?= =?us-ascii?Q?qxkMMZVkC6g1XbnyHLYMTMIcxOeb8KJ1cYI2/19OPwmi8lLM9F7mGoGeia+k?= =?us-ascii?Q?R7NGpkOwyG9Qg9JXq482/RCUNHzmOqGq9iDHft+lAZ8j9DYueBB2TxZU7BOS?= =?us-ascii?Q?xRJp1rW3Vg9EzvV6aeUffC9eFYI0SR5TPKg2bQmLhIQCBtmHPvuf9id1axVC?= =?us-ascii?Q?F5itG0XJvR3HZ2BDzN6Jhobbas47w9nBffqSbBue5gi1dvX5Qzl8iCHRSeE2?= =?us-ascii?Q?YapPqOvzpQ/Y/3Bxcf+IkEXqL4TlugMqLIiTFmBi1k7ehRUN0fvK/cfLBfm+?= =?us-ascii?Q?C1VFnVNQxSXfLnhPKAzE/cpYGRCq9kGegeYPLSSObp4o0V835Ap7tlg1HSlk?= =?us-ascii?Q?p3qeX4Jmvt7/zQJSYPYS01AeDmbZ1eDIojetK/8wUVr28kBVnijFBFJpBHxj?= =?us-ascii?Q?GH+W2C5acG41PvbLuiZKv8uvGhdt8jeUt5a1fr4j7tF/Yrhv3/fRMGDHv5Vo?= =?us-ascii?Q?c51zuKRfWXvH2P8w9ZsxNF/FncT5NddbZjYkmWH0zy386No3do+Fy17I5GYP?= =?us-ascii?Q?O/I6f6gO/ee0WuFRAqL/BnyYTPvBy1jG0NI80AL/jKL588Y5ebPBXu+rNHc+?= =?us-ascii?Q?BZvJgEWYsLmPFLtitofqXM5FYHcwrSrxlrtjsvr010KVj/BvOMgrRP/rq6lp?= =?us-ascii?Q?QtVJ3S//lyay7OJh6nm5Y9AqAqMyGpb8nV3H827Wq4L8Dtbj+bF4zV3Bqtfn?= =?us-ascii?Q?QZHpPw09LxPx4FOOIug4eEsgbcQXFxDBstvzuJY9O1A8mgYE/fjBlN/fXzvv?= =?us-ascii?Q?JJE+N5LLmnqtRxKQlzPoPwQEA1j87GJBUBMlIGI2z3iBCPLoxVCkP+G6ndFk?= =?us-ascii?Q?Tdiszp5oTm3eheSvtSUlMYPtAUcKinE97MnNo5bC2zqwk/MOIt/j6YXxBDV8?= =?us-ascii?Q?A3ywRxO/rnLplx0mjHj3krQO7KrR4Jbaq1wHIxpq6WuiarQenNgM0PMsadyd?= =?us-ascii?Q?HOBxVuBD+aXOCNKd+npHqIT4QglgTz5BofQhRdVtYryLCaqHvcHETNjDlBy7?= =?us-ascii?Q?a3KqgjgdOmPpEiD3xqHKgipV9Pxv1gJih+GBheFP?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e7135c4-8959-4ff7-8955-08de1d4eb197 X-MS-Exchange-CrossTenant-AuthSource: PAXSPRMB0053.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2025 16:08:16.0745 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wr5rRSQ6A9PghoDht+tcjnRPFmhIQAPGsNz8UhjP69v10iXPOGB9Lc7tMJo6/fV0683SBkfOeWgoilnVCAbbtw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9977 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251106_080821_980782_F7A329BB X-CRM114-Status: GOOD ( 19.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 06, 2025 at 11:30:30AM +0800, Peng Fan wrote: > Replace error logging and return handling in rproc_of_parse_firmware() and > imx_dsp_rproc_detect_mode() with dev_err_probe() to streamline error > reporting and improve consistency. > > Reduces boilerplate and aligns with modern kernel error handling practices. Nit: simple said Use dev_err_probe() simplify the code. No functional change. Reviewed-by: Frank Li > > Reviewed-by: Daniel Baluta > Reviewed-by: Shengjiu Wang > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_dsp_rproc.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c > index f5d0aec52c56664d6074272e276edb0c4175c9ea..87f4a026c05fbf1c9371058290b2d33cb94b9e54 100644 > --- a/drivers/remoteproc/imx_dsp_rproc.c > +++ b/drivers/remoteproc/imx_dsp_rproc.c > @@ -1150,11 +1150,8 @@ static int imx_dsp_rproc_probe(struct platform_device *pdev) > return -ENODEV; > > ret = rproc_of_parse_firmware(dev, 0, &fw_name); > - if (ret) { > - dev_err(dev, "failed to parse firmware-name property, ret = %d\n", > - ret); > - return ret; > - } > + if (ret) > + return dev_err_probe(dev, ret, "failed to parse firmware-name property\n"); > > rproc = devm_rproc_alloc(dev, "imx-dsp-rproc", &imx_dsp_rproc_ops, > fw_name, sizeof(*priv)); > @@ -1177,10 +1174,8 @@ static int imx_dsp_rproc_probe(struct platform_device *pdev) > INIT_WORK(&priv->rproc_work, imx_dsp_rproc_vq_work); > > ret = imx_dsp_rproc_detect_mode(priv); > - if (ret) { > - dev_err(dev, "failed on imx_dsp_rproc_detect_mode\n"); > - return ret; > - } > + if (ret) > + return dev_err_probe(dev, ret, "failed on imx_dsp_rproc_detect_mode\n"); > > /* There are multiple power domains required by DSP on some platform */ > ret = imx_dsp_attach_pm_domains(priv); > > -- > 2.37.1 >