Re: [PATCH v17 09/12] arm64: dts: qcom: qcs6490-rb3gen2: Add PSCI SYSTEM_RESET2 types

Bjorn Andersson
2025-11-11T16:55:05Z

On Sun, Nov 09, 2025 at 08:07:22PM +0530, Shivendra Pratap wrote:
> From: Elliot Berman <elliot.berman@oss.qualcomm.com>
>
> Add support for SYSTEM_RESET2 vendor-specific resets in

Please rewrite this to start with the purpose of the patch, introduce
the fact that we can use SYSTEM_RESET2 to affect the reboot mode.

Make sure you include the information that this isn't broadly available
on all sc7280 devices.

Please line break at 72 characters, not less.

> qcs6490-rb3gen2 as reboot-modes. Describe the resets:

This looks like the header for a list, that documents "bootloader" and
"edl", but it's just one lump of text. Please improve the formatting. If
it is a list, then make it look like a list.

Regards,
Bjorn

> "bootloader" will cause device to reboot and stop in the
> bootloader's fastboot mode. "edl" will cause device to reboot
> into "emergency download mode", which permits loading images via
> the Firehose protocol.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Elliot Berman <elliot.berman@oss.qualcomm.com>
> Signed-off-by: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> index 721a26d49ccaeb1429e2cc1c3a5c8d9517da3be6..cebdedd5d614b9efb6dfbee91dd67f3c3e322a38 100644
> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> @@ -935,6 +935,13 @@ &pon_resin {
> status = "okay";
> };
>
> +&psci {
> + reboot-mode {
> + mode-bootloader = <0x10001 0x2>;
> + mode-edl = <0 0x1>;
> + };
> +};
> +
> &qup_uart7_cts {
> /*
> * Configure a bias-bus-hold on CTS to lower power
>
> --
> 2.34.1
>