Re: [PATCH v17 09/12] arm64: dts: qcom: qcs6490-rb3gen2: Add PSCI SYSTEM_RESET2 types

Bjorn Andersson
2025-11-10T15:26:36Z

On Mon, Nov 10, 2025 at 05:58:24PM +0530, Mukesh Ojha wrote:
> On Sun, Nov 09, 2025 at 08:07:22PM +0530, Shivendra Pratap wrote:
> > From: Elliot Berman <elliot.berman@oss.qualcomm.com>
> >
> > Add support for SYSTEM_RESET2 vendor-specific resets in
> > qcs6490-rb3gen2 as reboot-modes. Describe the resets:
> > "bootloader" will cause device to reboot and stop in the
> > bootloader's fastboot mode. "edl" will cause device to reboot
> > into "emergency download mode", which permits loading images via
> > the Firehose protocol.
> >
> > Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> > Signed-off-by: Elliot Berman <elliot.berman@oss.qualcomm.com>
> > Signed-off-by: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
> > ---
> > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > index 721a26d49ccaeb1429e2cc1c3a5c8d9517da3be6..cebdedd5d614b9efb6dfbee91dd67f3c3e322a38 100644
> > --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > @@ -935,6 +935,13 @@ &pon_resin {
> > status = "okay";
> > };
> >
> > +&psci {
> > + reboot-mode {
> > + mode-bootloader = <0x10001 0x2>;
> > + mode-edl = <0 0x1>;
> > + };
> > +};
> > +
>
> Make sense for this as it leverages sc7280 and adding it there would not
> have made sense.
>

Why wouldn't it make sense?

> Acked-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
>

Please read submitting-patches.rst about Acked-by, and use Reviewed-by
going forward.

Regards,
Bjorn

> > &qup_uart7_cts {
> > /*
> > * Configure a bias-bus-hold on CTS to lower power
> >
> > --
> > 2.34.1
> >
>
> --
> -Mukesh Ojha
>