public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: Hongxing Zhu <hongxing.zhu@nxp.com>
Cc: Shawn Guo <shawnguo2@yeah.net>,
	"robh@kernel.org" <robh@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/7] arm64: dts: imx8dxl-evk: Add vpcie3v3aux regulator for PCIe M.2 connector
Date: Tue, 11 Nov 2025 11:11:06 -0500	[thread overview]
Message-ID: <aRNgGhZEmp9TLi9m@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <AS8PR04MB88332E188669CAA95CC89AEC8CCFA@AS8PR04MB8833.eurprd04.prod.outlook.com>

On Tue, Nov 11, 2025 at 08:02:20AM +0000, Hongxing Zhu wrote:
> > -----Original Message-----
> > From: Shawn Guo <shawnguo2@yeah.net>
> > Sent: 2025年11月11日 15:37
> > To: Hongxing Zhu <hongxing.zhu@nxp.com>
> > Cc: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
> > shawnguo@kernel.org; Frank Li <frank.li@nxp.com>;
> > s.hauer@pengutronix.de; festevam@gmail.com; kernel@pengutronix.de;
> > devicetree@vger.kernel.org; imx@lists.linux.dev;
> > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH v1 1/7] arm64: dts: imx8dxl-evk: Add vpcie3v3aux
> > regulator for PCIe M.2 connector
> >
> > On Fri, Oct 24, 2025 at 03:31:46PM +0800, Richard Zhu wrote:
> > > Refer to PCI Express M.2 Specification r5.1 sec3.1.1 Power Sources and
> > > Grounds.
> > >
> > > PCI Express M.2 Socket 1 utilizes a 3.3 V power source. The voltage
> > > source, 3.3 V, is expected to be available during the system’s
> > > stand-by/suspend state to support wake event processing on the
> > > communications card.
> > >
> > > Add vpcie3v3aux regulator to let this 3.3 V power source always on for
> > > PCIe M.2 Key E connector on i.MX8DXL EVK board.
> > >
> > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > > ---
> > >  arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
> > > b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
> > > index 25a77cac6f0b5..7704dba9e37c0 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
> > > +++ b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
> > > @@ -649,6 +649,7 @@ &pcie0 {
> > >  	pinctrl-names = "default";
> > >  	reset-gpio = <&lsio_gpio4 0 GPIO_ACTIVE_LOW>;
> > >  	vpcie-supply = <&reg_pcieb>;
> > > +	vpcie3v3aux-supply = <&reg_pcieb>;
> >
> > Is it a documented binding?
> Yes, it is. Please refer to what's Rob said below.
>
> "
> It is standard because PCIe spec defines them. pci-bus-common.yaml already defines these:
>
>   vpcie12v-supply:
>     description: 12v regulator phandle for the slot
>
>   vpcie3v3-supply:
>     description: 3.3v regulator phandle for the slot
>
>   vpcie3v3aux-supply:
>     description: 3.3v AUX regulator phandle for the slot
>
> Note that these should really be defined in the root port node rather than the host bridge node. We've done the latter because the RP node is often not defined.
>
> Rob
> "

Shawn:

	Check https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/pci/pci-bus-common.yaml

Frank

>
> Best Regards
> Richard Zhu
> >
> > Shawn
> >
> > >  	status = "okay";
> > >  };
> > >
> > > --
> > > 2.37.1
> > >
>


  reply	other threads:[~2025-11-11 16:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-24  7:31 [PATCH v1 0/7] Add vpcie3v3aux regulator for i.MX PCIe M.2 connector Richard Zhu
2025-10-24  7:31 ` [PATCH v1 1/7] arm64: dts: imx8dxl-evk: Add vpcie3v3aux regulator for " Richard Zhu
2025-11-11  7:37   ` Shawn Guo
2025-11-11  8:02     ` Hongxing Zhu
2025-11-11 16:11       ` Frank Li [this message]
2025-10-24  7:31 ` [PATCH v1 2/7] arm64: dts: imx8mp-evk: " Richard Zhu
2025-10-24  7:31 ` [PATCH v1 3/7] arm64: dts: imx8mq-evk: " Richard Zhu
2025-10-24  7:31 ` [PATCH v1 4/7] arm64: dts: imx8qm-mek: " Richard Zhu
2025-10-24  7:31 ` [PATCH v1 5/7] arm64: dts: imx8qxp-mek: " Richard Zhu
2025-10-24  7:31 ` [PATCH v1 6/7] arm64: dts: imx95-15x15-evk: " Richard Zhu
2025-10-24  7:31 ` [PATCH v1 7/7] arm64: dts: imx95-19x19-evk: Add vpcie3v3aux regulator for PCIe[0,1] Richard Zhu
2025-10-24 13:53 ` [PATCH v1 0/7] Add vpcie3v3aux regulator for i.MX PCIe M.2 connector Frank Li
2025-11-12  1:58 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aRNgGhZEmp9TLi9m@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=hongxing.zhu@nxp.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo2@yeah.net \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox