From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9379ACCF9F8 for ; Wed, 12 Nov 2025 08:40:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3aMWqppAqL+YZ7KPSgCDFNd7g1/pnbpNiizDPJTjwdw=; b=BDrtoq2A1+xjwEzSMuKY1Ve2oN Knlfod0UOS7wg/r3BIWlPnTw84Z0iXaBw48r2KSisQorWaVIGLH4I0NNK+buTfT3e+Tusle4J+YgM CNU/ApuhyBhb6UkPAwobTv2rmnLMaCzB6aNRJT1ip8sC/FvACZREor4lXmDUvhQeQWhjM4W7tvwzb /gE9F5lgZtlFm+F8f7fv7T9d9rjRVOCmdJTPeMX8f7M5ZMjnhAe/Ipb5HyehhzniO8NwQT6NxbAKv U6sb3ZJ7JBowxbKZWS9V+3llODJ+3e6VWf7eoR4ucm1Z+b1rGoBukLQkXsgNvexoNgnx+3sf0KpKS el7jjLSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJ6Om-00000008N3c-0yP4; Wed, 12 Nov 2025 08:40:16 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJ6Oj-00000008N3C-2xYr; Wed, 12 Nov 2025 08:40:14 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id E22E9443C4; Wed, 12 Nov 2025 08:40:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F370CC19421; Wed, 12 Nov 2025 08:40:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762936812; bh=24AR814wLA55Qc7z3MU0tNwo9drr/C1xImdNGy5q2O0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UvaW3kwlNSnW6HuOEIaJ/EsL2sNWRr/khWI8ueFg+45xLnNr6VEwJKymoqQcdxYcb NsrjK5c9QT0AJOITRlsKoSbw18w5uVEUKGPXCprJZylbKbkMPMHptIGkY/ru10J8o4 AiogQZmLOHr0aOrDBK7NErbcj0SPg+I0w/rL/3ppYId+x0lIqyJPipebEW/xFYlWoI v9BKwVOWhQt1k6y8Eu1joGAUX28fQkfz3uNK4V3sHJpVJXL5fQuC3nB2WtfbVqt248 gKp2uhiU1xgu7T6lyq8ayY/7rMCOkP8JMRq1cWbQcheQxa6WP+YYcPeOg9+ikgHm/Q QgqAGbyUxTCJA== Date: Wed, 12 Nov 2025 09:40:06 +0100 From: Niklas Cassel To: Bjorn Helgaas Cc: Manivannan Sadhasivam , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Shawn Lin , Kever Yang , Simon Xue , Damien Le Moal , Dragan Simic , FUKAUMI Naoki , Diederik de Haas , stable@vger.kernel.org, Manivannan Sadhasivam , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3] PCI: dw-rockchip: Prevent advertising L1 Substates support Message-ID: References: <20251111214336.GA2190667@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251111214336.GA2190667@bhelgaas> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251112_004013_784028_62EA2D3B X-CRM114-Status: GOOD ( 20.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 11, 2025 at 03:43:36PM -0600, Bjorn Helgaas wrote: > On Tue, Nov 11, 2025 at 02:08:36PM +0100, Niklas Cassel wrote: > > On Tue, Oct 21, 2025 at 08:05:17AM +0530, Manivannan Sadhasivam wrote: > > > On Fri, 17 Oct 2025 18:32:53 +0200, Niklas Cassel wrote: > > > > The L1 substates support requires additional steps to work, namely: > > > > -Proper handling of the CLKREQ# sideband signal. (It is mostly handled by > > > > hardware, but software still needs to set the clkreq fields in the > > > > PCIE_CLIENT_POWER_CON register to match the hardware implementation.) > > > > -Program the frequency of the aux clock into the > > > > DSP_PCIE_PL_AUX_CLK_FREQ_OFF register. (During L1 substates the core_clk > > > > is turned off and the aux_clk is used instead.) > > > > > > > > [...] > > > > > > Applied, thanks! > > > > > > [1/1] PCI: dw-rockchip: Prevent advertising L1 Substates support > > > commit: 40331c63e7901a2cc75ce6b5d24d50601efb833d > > > > Last update in this thread was "Applied, thanks!" > > > > and the patch was applied to pci/controller/dw-rockchip > > > > since then it seems to have been demoted to > > pci/controller/dw-rockchip-pend > > That was Oct 20, and we had some conversation about a more generic > approach after that, so I moved it to dw-rockchip-pend while we worked > that out. > > I fleshed it out the generic approach and will post it soon. Ok, thank you! Kind regards, Niklas