From: Will Deacon <will@kernel.org>
To: Mostafa Saleh <smostafa@google.com>
Cc: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, robin.murphy@arm.com,
joro@8bytes.org, jgg@ziepe.ca, praan@google.com
Subject: Re: [PATCH v6 0/4] Move io-pgtable-arm selftest to KUnit
Date: Thu, 13 Nov 2025 09:48:51 +0000 [thread overview]
Message-ID: <aRWpg0MXrnVH3E4Z@willie-the-truck> (raw)
In-Reply-To: <20251103123355.1769093-1-smostafa@google.com>
On Mon, Nov 03, 2025 at 12:33:48PM +0000, Mostafa Saleh wrote:
> This is a small series to clean up the io-pgtable-arm library.
>
> The first patch is a small clean up to reduce the depedencies of the
> test before moving it.
>
> The second patch was originally part of the SMMUv3 KVM driver support[1],
> which needed to factor out the kernel code from the io-pgtable-arm
> library, and based on Jason’s suggestion this can be taken out as a
> cleanup, and a step further to convert it to kunit.
>
> The second patch just moves the code to a new file with no other changes,
> so it can be easier to review with “--color-moved”
>
> The third patch converts the sefltest to be modular, that is useful as
> kunit can be a module and it can run anytime after boot.
>
> The fourth patch registers the test using kunit, and converges some of
> the APIs, some notes about that:
This all looks good to me, thanks for persevering with it!
Acked-by: Will Deacon <will@kernel.org>
Joerg -- please can you pick this up?
Cheers,
Will
next prev parent reply other threads:[~2025-11-13 9:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 12:33 [PATCH v6 0/4] Move io-pgtable-arm selftest to KUnit Mostafa Saleh
2025-11-03 12:33 ` [PATCH v6 1/4] iommu/io-pgtable-arm: Remove arm_lpae_dump_ops() Mostafa Saleh
2025-11-03 18:40 ` Jason Gunthorpe
2025-11-03 12:33 ` [PATCH v6 2/4] iommu/io-pgtable-arm: Move selftests to a separate file Mostafa Saleh
2025-11-03 12:33 ` [PATCH v6 3/4] iommu/io-pgtable-arm-selftests: Modularize the test Mostafa Saleh
2025-11-03 12:33 ` [PATCH v6 4/4] iommu/io-pgtable-arm-selftests: Use KUnit Mostafa Saleh
2025-11-13 9:48 ` Will Deacon [this message]
2025-11-13 15:26 ` [PATCH v6 0/4] Move io-pgtable-arm selftest to KUnit Jörg Rödel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRWpg0MXrnVH3E4Z@willie-the-truck \
--to=will@kernel.org \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=praan@google.com \
--cc=robin.murphy@arm.com \
--cc=smostafa@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox