[PATCH 1/2] clkdev: improve ID length error message

[PATCH 1/2] clkdev: improve ID length error message

[Alexander Stein]

From: Matthias Schiffer <matthias.schiffer@tq-group.com>

"is greater than X" is very unclear if you're not familiar with the
code. Change the wording to "is longer than X bytes". In addition, add a
space between device and connection ID to make it easier to determine
which part of the ID is responsible for the length.

Signed-off-by: Matthias Schiffer <matthias.schiffer@tq-group.com>
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 drivers/clk/clkdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
index e0bede6350e11..f46324622cca0 100644
--- a/drivers/clk/clkdev.c
+++ b/drivers/clk/clkdev.c
@@ -201,7 +201,7 @@ vclkdev_alloc(struct clk_hw *hw, const char *con_id, const char *dev_fmt,
 	else
 		vaf.fmt = "null-device";
 	vaf.va = &ap_copy;
-	pr_err("%pV:%s: %s ID is greater than %zu\n",
+	pr_err("%pV: %s: %s ID is longer than %zu bytes\n",
 	       &vaf, con_id, failure, max_size);
 	va_end(ap_copy);
 
-- 
2.43.0

[PATCH 2/2] clkdev: increase MAX_DEV_ID to 64

[Alexander Stein]

From: Matthias Schiffer <matthias.schiffer@tq-group.com>

On the TI AM335x, there are clock IDs like
"48000000.interconnect:segment@200000:target-module@0:mpu@0", which is
58 characters long.

Signed-off-by: Matthias Schiffer <matthias.schiffer@tq-group.com>
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 drivers/clk/clkdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
index f46324622cca0..8771fe9453830 100644
--- a/drivers/clk/clkdev.c
+++ b/drivers/clk/clkdev.c
@@ -144,7 +144,7 @@ void clkdev_add_table(struct clk_lookup *cl, size_t num)
 	mutex_unlock(&clocks_mutex);
 }
 
-#define MAX_DEV_ID	24
+#define MAX_DEV_ID	64
 #define MAX_CON_ID	16
 
 struct clk_lookup_alloc {
-- 
2.43.0

Re: [PATCH 2/2] clkdev: increase MAX_DEV_ID to 64

[Russell King (Oracle)]

On Fri, Nov 14, 2025 at 10:09:33AM +0100, Alexander Stein wrote:
> From: Matthias Schiffer <matthias.schiffer@tq-group.com>
> 
> On the TI AM335x, there are clock IDs like
> "48000000.interconnect:segment@200000:target-module@0:mpu@0", which is
> 58 characters long.

This looks like a device that is using DT. Clocks for such devices
should be described in DT, not using clkdev. When using DT, there
is no need to register clocks into clkdev - this is used for cases
where its not possible to describe such relationships (e.g. non-DT
systems.)

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!