From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09382CEB2C9 for ; Sat, 15 Nov 2025 09:56:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xXnS95zIUe4oTXytX7J90dCvdMH5uRG/iOxKBN187eo=; b=IcqLjxF1rWIzDFI7o8D3RQPdAi j3uhIMMd1KeIgjwjFG2JsAzBYexgygSJR6Udszwwr9dDsg8om0QylAclmDL+9fonjWj6pp/hSQi/C pxpbhaW2GJLqqoOWetzxOl3SAdM2yU3Si6PPiPJh6Em1IQ5ZZbXfzwBefmjkFUhNzzzTXHz3vtNpT 0DPOEQw9wfRHi1lzc4qUfF+It9+ZacSUSB/bS4+dO9z0cBLUhgO2Tpg09/jPOE7I9sL7zoYr9EMBc D53lSfKVdw+vSxByURvjkved3CQnGN+hs1DrIJNWgYs6+mUUEAEfdgwrHHxVAwnGhX4hR4vUgurJW g93riG+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vKD0p-0000000Dg5J-1BH1; Sat, 15 Nov 2025 09:56:07 +0000 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vKD0m-0000000Dg4c-0SWG for linux-arm-kernel@lists.infradead.org; Sat, 15 Nov 2025 09:56:06 +0000 Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-b98983bae8eso1705223a12.0 for ; Sat, 15 Nov 2025 01:56:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763200563; x=1763805363; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xXnS95zIUe4oTXytX7J90dCvdMH5uRG/iOxKBN187eo=; b=d4+YlvqCPXRaAulmbaopwUWYYzU6pBlGjbPXrCPr30uFft0XjBwx7IXekwQU16XMZp JM1qaLqLURxE4OX405Rqxgsp/G1p9UNcTojHSDUL48WCR9VGIFKhBF0Bph8/SxVyk/jk Kwwd2d6rzjfXQlI7u5dzsj4p0UNs61HGkuP0/fsp8wa3IMtBDZakt7uRrefGkkYnc/mC qPi6kin8mKmkeYNzDuffOeIUgZLDbuY2uWxQceCiAnBNGqvi+Nvb5BpDSgq4NET6zbNN PgWY+lJi3YCi2W1CSWzWvDT4DcA+cbjiveywtZzHR4j/udxm99fykhns8AzzbB76iY1E Q4Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763200563; x=1763805363; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xXnS95zIUe4oTXytX7J90dCvdMH5uRG/iOxKBN187eo=; b=h4OsQHHi4yKyt/DUBdJGnpHziseSrrFB6lLefTsZp1ZMhWV5PQY3sYls5FoJs5DSR0 mY8teg2xsScS1gAwGlJGyQPkFspOiKKtGOxxiw2U4pjZmTXzzjWlmzZANAzYz7DppjTJ ucg2x6IVWzQnxd9SRzlOc6Fyf3A8k246KifdrrpIzfce5tfk+/8qKWtX33MvJMW4ZAWo 1QybUC07F346JuTOcyYC1ptraufPQMNASD+eGp8eLOspNDa5ucPBvnTS7wTQev+N3ZKh 8EjC2u3cbj9YWYYt2Wh5bHFeR1oGps1u6i59dYWdo6KCztuA6hAe8O/eFq+nR15VaOgv tN9w== X-Forwarded-Encrypted: i=1; AJvYcCUMFZkLxVqjN01bknKygW2IHL1kCYW034JNFt7aTOrIDpOj7/g0C3iG1SledRFIh6aZiYGdC6fGKXPCRKyEEfpW@lists.infradead.org X-Gm-Message-State: AOJu0Yyp3wjDZlay7p65pmbbi71laYimnZ79Oo5vWSkHJUUpSW71hnVP xkiZMkhKbEKTfsI/55aUxDvV76c8/MFAA69B3H2bwEa8hkcuKAoRzEC99XcYzzAZ X-Gm-Gg: ASbGncuIOswKQQUP08scpNIEvZsdAbgKtcduUpt5yjonHSYXeKOVr7Dv5psTbG6r8Dy RUXTByaiRVlbikSN3fEwFkP3+Mzs7iZSU4YwiuhVU91SzO74GbwV83TUzcGbTIwXULd+tvMrvn3 hTViLYYn90BFR2wr0nIIobGew6bCJGUYVPIf502gYXYT5Ou6Z8rBgphAeandUksMYUnm860AB4J J6wRPuaTQ5Br4LPEUilW+KhUd1yLYu5WqJNJ17N0yoMObJ8JqNrqN+zAbA8b+lolE2pCMoou5kV L6AGPQGu7q7T0itzUsg9q9nwfSIe0dcCQd+8iFKgg0RWuPJBgLnzUUQYlTVkD90Ef0Aej3Pxeqe B9j2Q1xpHlTpu8iirvjvkZM5YzgAu/qoZtHr1J4RbG55NlrAJRsfSKQ2DNVPmM88zBpHW+3fsLs sD4HGAvC1lqaego8dE7Rc= X-Google-Smtp-Source: AGHT+IHUlupuM7szZcYDg9/TlMwVZ71HSLpjpZExx6vY1jp09oOh8FYjiJ3nZkXQKy+o63KI20P1NQ== X-Received: by 2002:a05:7300:ec89:b0:2a4:3592:cf6d with SMTP id 5a478bee46e88-2a4ab8a9516mr1719763eec.17.1763200563112; Sat, 15 Nov 2025 01:56:03 -0800 (PST) Received: from geday ([2804:7f2:800b:a121::dead:c001]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2a49db102f5sm16240515eec.4.2025.11.15.01.55.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Nov 2025 01:56:02 -0800 (PST) Date: Sat, 15 Nov 2025 06:55:55 -0300 From: Geraldo Nascimento To: Dragan Simic Cc: linux-rockchip@lists.infradead.org, Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski , Conor Dooley , Johan Jonker Subject: Re: [PATCH 3/3] arm64: dts: rockchip: drop max-link-speed = <2> in helios64 PCIe Message-ID: References: <53332edec449b84d8a962f2b5995667766359772.1763197368.git.geraldogabriel@gmail.com> <3f13841d-030b-0202-61be-412c0ab9df6b@manjaro.org> <7d300769-9803-9c0c-60bb-4a724619d8e0@manjaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7d300769-9803-9c0c-60bb-4a724619d8e0@manjaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251115_015604_832569_73BFA141 X-CRM114-Status: GOOD ( 25.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Nov 15, 2025 at 10:42:40AM +0100, Dragan Simic wrote: > On Saturday, November 15, 2025 10:36 CET, "Dragan Simic" wrote: > > On Saturday, November 15, 2025 10:10 CET, Geraldo Nascimento wrote: > > > Shawn Lin from Rockchip strongly discourages attempts to use their > > > RK3399 PCIe core at 5.0 GT/s speed, citing concerns about catastrophic > > > failures that may happen. Even if the odds are low, drop from last user > > > of this property for the RK3399 platform, helios64. > > > > > > Fixes: 755fff528b1b ("arm64: dts: rockchip: add variables for pcie completion to helios64") > > > Link: https://lore.kernel.org/all/ffd05070-9879-4468-94e3-b88968b4c21b@rock-chips.com/ > > > Reported-by: Shawn Lin > > > Signed-off-by: Geraldo Nascimento > > > --- > > > arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts > > > index e7d4a2f9a95e..78a7775c3b22 100644 > > > --- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts > > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts > > > @@ -424,7 +424,6 @@ &pcie_phy { > > > > > > &pcie0 { > > > ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>; > > > - max-link-speed = <2>; > > > num-lanes = <2>; > > > pinctrl-names = "default"; > > > status = "okay"; > > > > Looking good to me, this rounds up the prevention of issues > > coming from buggy PCIe Gen2 on RK3399. > > > > Please feel free to include > > > > Reviewed-by: Dragan Simic > > > > Though, could you, please, add patch 4/3 to this series, which > > would remove the redundant parameter "max-link-speed = <1>" from > > rk3399-nanopi-r4s.dtsi? > > Sorry, I forgot to note that the patch summary would read a bit > better if it were reworded like this: > > arm64: dts: rockchip: Remove redundant max-link-speed from helios64 board dts > No, I think: arm64: dts: rockchip: Remove dangerous max-link-speed from helios64 board dts Is more accurately described. With focus on the dangerous, we're not liable. Redudant max-link-speed only for nanopi-r4s include definitions I think! Thanks, Geraldo Nascimento