From: Geraldo Nascimento <geraldogabriel@gmail.com>
To: Dragan Simic <dsimic@manjaro.org>
Cc: linux-rockchip@lists.infradead.org,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Heiko Stuebner" <heiko@sntech.de>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Johan Jonker" <jbx6244@gmail.com>
Subject: Re: [PATCH 2/3] PCI: rockchip-host: comment danger of 5.0 GT/s speed
Date: Sat, 15 Nov 2025 07:04:33 -0300 [thread overview]
Message-ID: <aRhQMRjffbeCeArE@geday> (raw)
In-Reply-To: <85d1543b-ea91-5f0f-59d6-e00fcf720938@manjaro.org>
On Sat, Nov 15, 2025 at 11:01:21AM +0100, Dragan Simic wrote:
> On Saturday, November 15, 2025 10:51 CET, Geraldo Nascimento <geraldogabriel@gmail.com> wrote:
> > On Sat, Nov 15, 2025 at 10:30:49AM +0100, Dragan Simic wrote:
> > > Looking good to me, thanks for this patch! There's no need
> > > to emit warnings here, because they'd be emitted already in
> > > the rockchip_pcie_parse_dt() function.
> > >
> > > Please feel free to include
> > >
> > > Reviewed-by: Dragan Simic <dsimic@manjaro.org>
> > >
> >
> > I disagree, I think the comment stands.
> >
> > Even if we reduce to one line, ex:
> >
> > + May cause damage
>
> Ah, perhaps I wasn't clear enough, so let me clarify a bit. The
> comment you added is fine, I just referred to no need for emitting
> a warning at that point, because it would be emitted already.
OK, I get it now so I think it's time to send v2 with all that in mind
:)
Thanks,
Geraldo Nascimento
next prev parent reply other threads:[~2025-11-15 10:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-15 9:10 [PATCH 0/3] PCI: rockchip: 5.0 GT/s speed may be dangerous Geraldo Nascimento
2025-11-15 9:10 ` [PATCH 1/3] PCI: rockchip: warn of danger of 5.0 GT/s speeds Geraldo Nascimento
2025-11-15 9:24 ` Dragan Simic
2025-11-15 9:49 ` Geraldo Nascimento
2025-11-15 9:10 ` [PATCH 2/3] PCI: rockchip-host: comment danger of 5.0 GT/s speed Geraldo Nascimento
2025-11-15 9:30 ` Dragan Simic
2025-11-15 9:51 ` Geraldo Nascimento
2025-11-15 10:01 ` Dragan Simic
2025-11-15 10:04 ` Geraldo Nascimento [this message]
2025-11-15 10:09 ` Dragan Simic
2025-11-15 10:11 ` Geraldo Nascimento
2025-11-15 9:10 ` [PATCH 3/3] arm64: dts: rockchip: drop max-link-speed = <2> in helios64 PCIe Geraldo Nascimento
2025-11-15 9:36 ` Dragan Simic
2025-11-15 9:42 ` Dragan Simic
2025-11-15 9:55 ` Geraldo Nascimento
2025-11-15 10:03 ` Dragan Simic
2025-11-15 9:53 ` Geraldo Nascimento
2025-11-17 3:42 ` [PATCH 0/3] PCI: rockchip: 5.0 GT/s speed may be dangerous Shawn Lin
2025-11-17 3:57 ` Dragan Simic
2025-11-17 7:02 ` Geraldo Nascimento
2025-11-17 15:59 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRhQMRjffbeCeArE@geday \
--to=geraldogabriel@gmail.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).