* [PATCH v1 1/5] arm64: dts: imx8-apalis: cleanup todo
2025-10-27 9:30 [PATCH v1 0/5] arm64: dts: imx8-apalis: add additional functionality max.oss.09
@ 2025-10-27 9:30 ` max.oss.09
2025-10-27 10:08 ` Daniel Baluta
2025-10-27 9:30 ` [PATCH v1 2/5] arm64: dts: imx8-apalis: add thermal nodes max.oss.09
` (4 subsequent siblings)
5 siblings, 1 reply; 8+ messages in thread
From: max.oss.09 @ 2025-10-27 9:30 UTC (permalink / raw)
To: Max Krummenacher, Stefan Eichenberger
Cc: Conor Dooley, Fabio Estevam, Krzysztof Kozlowski,
Pengutronix Kernel Team, Rob Herring, Sascha Hauer, Shawn Guo,
devicetree, imx, linux-arm-kernel, linux-kernel
From: Max Krummenacher <max.krummenacher@toradex.com>
Functionality has been added without removing the associated TODO
comments.
Clean that up by removing TODOs no longer applicable.
Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
---
arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi | 8 --------
arch/arm64/boot/dts/freescale/imx8qm-apalis.dtsi | 2 --
2 files changed, 10 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
index 86d018f470c1..6ebeade2ce72 100644
--- a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
@@ -31,12 +31,6 @@ gpio_fan: gpio-fan {
3000 1>;
};
- /* TODO: LVDS Panel */
-
- /* TODO: Shared PCIe/SATA Reference Clock */
-
- /* TODO: PCIe Wi-Fi Reference Clock */
-
/*
* Power management bus used to control LDO1OUT of the
* second PMIC PF8100. This is used for controlling voltage levels of
@@ -269,8 +263,6 @@ &adc1 {
pinctrl-0 = <&pinctrl_adc1>;
};
-/* TODO: Asynchronous Sample Rate Converter (ASRC) */
-
&cpu_alert0 {
temperature = <95000>;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8qm-apalis.dtsi b/arch/arm64/boot/dts/freescale/imx8qm-apalis.dtsi
index f97feee52c81..7594ac61fe56 100644
--- a/arch/arm64/boot/dts/freescale/imx8qm-apalis.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qm-apalis.dtsi
@@ -314,8 +314,6 @@ &pinctrl_pcie_sata_refclk {
<IMX8QM_PCIE_CTRL0_CLKREQ_B_LSIO_GPIO4_IO27 0x00000021>;
};
-/* TODO: On-module Wi-Fi */
-
/* Apalis MMC1 */
&usdhc2 {
/*
--
2.42.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v1 1/5] arm64: dts: imx8-apalis: cleanup todo
2025-10-27 9:30 ` [PATCH v1 1/5] arm64: dts: imx8-apalis: cleanup todo max.oss.09
@ 2025-10-27 10:08 ` Daniel Baluta
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Baluta @ 2025-10-27 10:08 UTC (permalink / raw)
To: max.oss.09
Cc: Max Krummenacher, Stefan Eichenberger, Conor Dooley,
Fabio Estevam, Krzysztof Kozlowski, Pengutronix Kernel Team,
Rob Herring, Sascha Hauer, Shawn Guo, devicetree, imx,
linux-arm-kernel, linux-kernel
On Mon, Oct 27, 2025 at 11:32 AM <max.oss.09@gmail.com> wrote:
>
> From: Max Krummenacher <max.krummenacher@toradex.com>
>
> Functionality has been added without removing the associated TODO
> comments.
> Clean that up by removing TODOs no longer applicable.
>
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v1 2/5] arm64: dts: imx8-apalis: add thermal nodes
2025-10-27 9:30 [PATCH v1 0/5] arm64: dts: imx8-apalis: add additional functionality max.oss.09
2025-10-27 9:30 ` [PATCH v1 1/5] arm64: dts: imx8-apalis: cleanup todo max.oss.09
@ 2025-10-27 9:30 ` max.oss.09
2025-10-27 9:30 ` [PATCH v1 3/5] arm64: dts: imx8-apalis: specify adc reference voltage regulator max.oss.09
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: max.oss.09 @ 2025-10-27 9:30 UTC (permalink / raw)
To: Max Krummenacher, Stefan Eichenberger
Cc: Conor Dooley, Fabio Estevam, Krzysztof Kozlowski,
Pengutronix Kernel Team, Rob Herring, Sascha Hauer, Shawn Guo,
devicetree, imx, linux-arm-kernel, linux-kernel
From: Max Krummenacher <max.krummenacher@toradex.com>
Add the thermal-zones and cooling-maps nodes for the PMIC device.
Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
---
.../boot/dts/freescale/imx8-apalis-v1.1.dtsi | 30 +++++++++++++++++--
.../dts/freescale/imx8qm-apalis-v1.1.dtsi | 10 ++++++-
2 files changed, 37 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
index 6ebeade2ce72..686fce7443bb 100644
--- a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
@@ -226,6 +226,34 @@ sound-spdif {
spdif-out;
};
+ thermal-zones {
+ pmic-thermal {
+ polling-delay-passive = <250>;
+ polling-delay = <2000>;
+ thermal-sensors = <&tsens IMX_SC_R_PMIC_0>;
+
+ cooling-maps {
+ cooling_maps_map0: map0 {
+ trip = <&pmic_alert0>;
+ };
+ };
+
+ trips {
+ pmic_alert0: trip0 {
+ hysteresis = <2000>;
+ temperature = <110000>;
+ type = "passive";
+ };
+
+ pmic_crit0: trip1 {
+ hysteresis = <2000>;
+ temperature = <125000>;
+ type = "critical";
+ };
+ };
+ };
+ };
+
touchscreen: touchscreen {
compatible = "toradex,vf50-touchscreen";
interrupt-parent = <&lsio_gpio3>;
@@ -833,8 +861,6 @@ &spdif0 {
status = "okay";
};
-/* TODO: Thermal Zones */
-
/* TODO: Apalis USBH2, Apalis USBH3 and on-module Wi-Fi via on-module HSIC Hub */
/* Apalis USBH4 */
diff --git a/arch/arm64/boot/dts/freescale/imx8qm-apalis-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8qm-apalis-v1.1.dtsi
index b1c3f331c4ed..8a37cbe922ac 100644
--- a/arch/arm64/boot/dts/freescale/imx8qm-apalis-v1.1.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qm-apalis-v1.1.dtsi
@@ -11,4 +11,12 @@ / {
model = "Toradex Apalis iMX8QM V1.1";
};
-/* TODO: Cooling Maps */
+&cooling_maps_map0 {
+ cooling-device =
+ <&A53_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&A53_1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&A53_2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&A53_3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&A72_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&A72_1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+};
--
2.42.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v1 3/5] arm64: dts: imx8-apalis: specify adc reference voltage regulator
2025-10-27 9:30 [PATCH v1 0/5] arm64: dts: imx8-apalis: add additional functionality max.oss.09
2025-10-27 9:30 ` [PATCH v1 1/5] arm64: dts: imx8-apalis: cleanup todo max.oss.09
2025-10-27 9:30 ` [PATCH v1 2/5] arm64: dts: imx8-apalis: add thermal nodes max.oss.09
@ 2025-10-27 9:30 ` max.oss.09
2025-10-27 9:30 ` [PATCH v1 4/5] arm64: dts: imx8-apalis: rename wifi regulator max.oss.09
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: max.oss.09 @ 2025-10-27 9:30 UTC (permalink / raw)
To: Max Krummenacher, Stefan Eichenberger
Cc: Conor Dooley, Fabio Estevam, Krzysztof Kozlowski,
Pengutronix Kernel Team, Rob Herring, Sascha Hauer, Shawn Guo,
devicetree, imx, linux-arm-kernel, linux-kernel
From: Max Krummenacher <max.krummenacher@toradex.com>
This sets in_voltage_scale to calculate the measured voltage from the
raw digital value of the ADC.
Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
---
arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
index 686fce7443bb..abf6d543380c 100644
--- a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
@@ -284,11 +284,13 @@ &asrc0 {
&adc0 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_adc0>;
+ vref-supply = <®_vref_1v8>;
};
&adc1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_adc1>;
+ vref-supply = <®_vref_1v8>;
};
&cpu_alert0 {
--
2.42.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v1 4/5] arm64: dts: imx8-apalis: rename wifi regulator
2025-10-27 9:30 [PATCH v1 0/5] arm64: dts: imx8-apalis: add additional functionality max.oss.09
` (2 preceding siblings ...)
2025-10-27 9:30 ` [PATCH v1 3/5] arm64: dts: imx8-apalis: specify adc reference voltage regulator max.oss.09
@ 2025-10-27 9:30 ` max.oss.09
2025-10-27 9:30 ` [PATCH v1 5/5] arm64: dts: imx8-apalis: use startup-delay-us for " max.oss.09
2025-11-16 3:56 ` [PATCH v1 0/5] arm64: dts: imx8-apalis: add additional functionality Shawn Guo
5 siblings, 0 replies; 8+ messages in thread
From: max.oss.09 @ 2025-10-27 9:30 UTC (permalink / raw)
To: Max Krummenacher, Stefan Eichenberger
Cc: Conor Dooley, Fabio Estevam, Krzysztof Kozlowski,
Pengutronix Kernel Team, Rob Herring, Sascha Hauer, Shawn Guo,
devicetree, imx, linux-arm-kernel, linux-kernel
From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
Rename the wifi regulator to what is the net name in the schematic.
Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
---
arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
index abf6d543380c..4234289d4012 100644
--- a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
@@ -77,7 +77,7 @@ reg_module_wifi: regulator-module-wifi {
gpio = <&lsio_gpio1 28 GPIO_ACTIVE_HIGH>;
enable-active-high;
regulator-always-on;
- regulator-name = "wifi_pwrdn_fake_regulator";
+ regulator-name = "Wi-Fi_POWER_DOWN"; /* Wi-Fi module PDn */
regulator-settling-time-us = <100>;
};
--
2.42.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v1 5/5] arm64: dts: imx8-apalis: use startup-delay-us for wifi regulator
2025-10-27 9:30 [PATCH v1 0/5] arm64: dts: imx8-apalis: add additional functionality max.oss.09
` (3 preceding siblings ...)
2025-10-27 9:30 ` [PATCH v1 4/5] arm64: dts: imx8-apalis: rename wifi regulator max.oss.09
@ 2025-10-27 9:30 ` max.oss.09
2025-11-16 3:56 ` [PATCH v1 0/5] arm64: dts: imx8-apalis: add additional functionality Shawn Guo
5 siblings, 0 replies; 8+ messages in thread
From: max.oss.09 @ 2025-10-27 9:30 UTC (permalink / raw)
To: Max Krummenacher, Stefan Eichenberger
Cc: Conor Dooley, Fabio Estevam, Krzysztof Kozlowski,
Pengutronix Kernel Team, Rob Herring, Sascha Hauer, Shawn Guo,
devicetree, imx, linux-arm-kernel, linux-kernel
From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
We used regulator-settling-time-us for the wifi regulator which is
wrong for regulator-fixed. We have to use startup-delay-us instead.
Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
---
arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
index 4234289d4012..f2646db74a5f 100644
--- a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
@@ -78,7 +78,7 @@ reg_module_wifi: regulator-module-wifi {
enable-active-high;
regulator-always-on;
regulator-name = "Wi-Fi_POWER_DOWN"; /* Wi-Fi module PDn */
- regulator-settling-time-us = <100>;
+ startup-delay-us = <100>;
};
reg_pcie_switch: regulator-pcie-switch {
--
2.42.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v1 0/5] arm64: dts: imx8-apalis: add additional functionality
2025-10-27 9:30 [PATCH v1 0/5] arm64: dts: imx8-apalis: add additional functionality max.oss.09
` (4 preceding siblings ...)
2025-10-27 9:30 ` [PATCH v1 5/5] arm64: dts: imx8-apalis: use startup-delay-us for " max.oss.09
@ 2025-11-16 3:56 ` Shawn Guo
5 siblings, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2025-11-16 3:56 UTC (permalink / raw)
To: max.oss.09
Cc: Max Krummenacher, Stefan Eichenberger, Conor Dooley,
Fabio Estevam, Krzysztof Kozlowski, Pengutronix Kernel Team,
Rob Herring, Sascha Hauer, Shawn Guo, devicetree, imx,
linux-arm-kernel, linux-kernel
On Mon, Oct 27, 2025 at 10:30:06AM +0100, max.oss.09@gmail.com wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
>
> Cleanup the regulator used for the Wi-Fi module.
> Improve ADC node by specifing the used reference volatage.
> Add thermal nodes and cooling devices for the PMIC.
> Cleanup TODOs no longer applicable.
>
>
> Max Krummenacher (3):
> arm64: dts: imx8-apalis: cleanup todo
> arm64: dts: imx8-apalis: add thermal nodes
> arm64: dts: imx8-apalis: specify adc reference voltage regulator
>
> Stefan Eichenberger (2):
> arm64: dts: imx8-apalis: rename wifi regulator
> arm64: dts: imx8-apalis: use startup-delay-us for wifi regulator
Applied all, thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread